[GitHub] [incubator-apisix] sshniro commented on issue #1243: request help: How to white-list consumers for the Keyauth plugin

2020-03-24 Thread GitBox
sshniro commented on issue #1243: request help: How to white-list consumers for the Keyauth plugin URL: https://github.com/apache/incubator-apisix/issues/1243#issuecomment-603065789 Yes, Agree @soulsoul I think this can be a separate Access Control Plugin. This is the scenario I

[GitHub] [incubator-apisix] sshniro edited a comment on issue #1243: request help: How to white-list consumers for the Keyauth plugin

2020-03-24 Thread GitBox
sshniro edited a comment on issue #1243: request help: How to white-list consumers for the Keyauth plugin URL: https://github.com/apache/incubator-apisix/issues/1243#issuecomment-603065789 Yes, Agree @soulsoul I think this can be a separate Access Control Plugin. This is the sce

[GitHub] [incubator-apisix] sshniro edited a comment on issue #1243: request help: How to white-list consumers for the Keyauth plugin

2020-03-24 Thread GitBox
sshniro edited a comment on issue #1243: request help: How to white-list consumers for the Keyauth plugin URL: https://github.com/apache/incubator-apisix/issues/1243#issuecomment-603065789 Yes, Agree @soulsoul I think this can be a separate Access Control Plugin. This is the sce

[GitHub] [incubator-apisix] sshniro commented on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
sshniro commented on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603070348 Thanks, Yes it was working but gave 500 intermittently, I will try with another service and get back to you. BTW, a s

[GitHub] [incubator-apisix] sshniro commented on issue #965: HTTP logger to send logs to external log management tool

2020-03-24 Thread GitBox
sshniro commented on issue #965: HTTP logger to send logs to external log management tool URL: https://github.com/apache/incubator-apisix/issues/965#issuecomment-603071593 The coroutine bug has been resolved for the batch processor, I will send a PR during the weekend for the HTTP logger.

[GitHub] [incubator-apisix] sshniro edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
sshniro edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603070348 Thanks, Yes it was working but gave 500 intermittently, I will try with another service and get back to you. B

[GitHub] [incubator-apisix] sshniro edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
sshniro edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603070348 Thanks, Yes it was working but gave 500 intermittently, I will try with another service and get back to you. B

[GitHub] [incubator-apisix-dashboard] sshniro commented on a change in pull request #159: Adding script to verify commit message

2020-03-24 Thread GitBox
sshniro commented on a change in pull request #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#discussion_r396946029 ## File path: scripts/verifyCommit.js ## @@ -0,0 +1,26 @@ +// Invoked on the commit-msg git

[GitHub] [incubator-apisix-dashboard] dingchaofa opened a new pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
dingchaofa opened a new pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160 This is an automated message from the Apache Git Servic

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396953056 ## File path: vue.config.js ## @@ -28,7 +28,7 @@ module.exports = {

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396953680 ## File path: src/components/VarArgs/index.vue ## @@ -0,0 +1,128 @@ +

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
juzhiyuan commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396953265 ## File path: src/views/schema/routes/edit.vue ## @@ -497,5 +511,15 @@

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new issue #161: Request: we can add vars filter in route configuration page

2020-03-24 Thread GitBox
lilien1010 opened a new issue #161: Request: we can add vars filter in route configuration page URL: https://github.com/apache/incubator-apisix-dashboard/issues/161 for now ,the apisix route is already support filter nginx built-in parameter, and it's better we can have this in dashboard

[GitHub] [incubator-apisix-dashboard] dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396960211 ## File path: vue.config.js ## @@ -28,7 +28,7 @@ module.exports = {

[GitHub] [incubator-apisix-dashboard] dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396960805 ## File path: src/components/VarArgs/index.vue ## @@ -0,0 +1,128 @@ +

[GitHub] [incubator-apisix-dashboard] dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
dingchaofa commented on a change in pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160#discussion_r396960714 ## File path: src/views/schema/routes/edit.vue ## @@ -497,5 +511,15 @

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #160: feature:allow set vars filter in router configuration page

2020-03-24 Thread GitBox
juzhiyuan merged pull request #160: feature:allow set vars filter in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/160 This is an automated message from the Apache Git Service. To r

[incubator-apisix-dashboard] branch master updated: feature:allow set vars filter in router configuration page (#160)

2020-03-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new df4c6be feature:allow se

[GitHub] [incubator-apisix-dashboard] dingchaofa opened a new issue #162: Allow set filter_func in router configuration page

2020-03-24 Thread GitBox
dingchaofa opened a new issue #162: Allow set filter_func in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/issues/162 Add filter_func in router This is an automated message from the Apach

[GitHub] [incubator-apisix-dashboard] dingchaofa opened a new pull request #163: feature:allow set filter_func in router configuration page

2020-03-24 Thread GitBox
dingchaofa opened a new pull request #163: feature:allow set filter_func in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/163 add filter_func feature https://github.com/apache/incubator-apisix-dashboard/issues/162#issue-586830526

[GitHub] [incubator-apisix-dashboard] dingchaofa closed pull request #163: feature:allow set filter_func in router configuration page

2020-03-24 Thread GitBox
dingchaofa closed pull request #163: feature:allow set filter_func in router configuration page URL: https://github.com/apache/incubator-apisix-dashboard/pull/163 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix-dashboard] dingchaofa opened a new pull request #164: feature:allow set filter_func in router configuation page

2020-03-24 Thread GitBox
dingchaofa opened a new pull request #164: feature:allow set filter_func in router configuation page URL: https://github.com/apache/incubator-apisix-dashboard/pull/164 add feature: https://github.com/apache/incubator-apisix-dashboard/issues/162#issue-586830526

[GitHub] [incubator-apisix] membphis opened a new pull request #1334: bugfix: added `key` field when parse route from local yaml.

2020-03-24 Thread GitBox
membphis opened a new pull request #1334: bugfix: added `key` field when parse route from local yaml. URL: https://github.com/apache/incubator-apisix/pull/1334 Fix #1329 . This is an automated message from the Apache Git

[incubator-apisix] branch master updated (5d8e39d -> 67b63b2)

2020-03-24 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 5d8e39d doc: add udp logger docs. (#1330) add 67b63b2 bugfix: added `key` field when parse route fr

[GitHub] [incubator-apisix] moonming closed issue #1329: apisix in Stand-alone mode Health check does not take effect

2020-03-24 Thread GitBox
moonming closed issue #1329: apisix in Stand-alone mode Health check does not take effect URL: https://github.com/apache/incubator-apisix/issues/1329 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-apisix] moonming merged pull request #1334: bugfix: added `key` field when parse route from local yaml.

2020-03-24 Thread GitBox
moonming merged pull request #1334: bugfix: added `key` field when parse route from local yaml. URL: https://github.com/apache/incubator-apisix/pull/1334 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-apisix] membphis commented on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
membphis commented on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603207149 > BTW, a suggestion why don't we host an echo service for APISIX itself? https://docs.google.com/document/d/1BNMWjXB

[GitHub] [incubator-apisix] membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603207502 > I see some of the docs use this IP `http://39.97.63.215/` we should change it to another address. -

[GitHub] [incubator-apisix] membphis commented on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
membphis commented on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603207502 > I see some of the docs use this IP `http://39.97.63.215/` we should remove it or use another address.

[GitHub] [incubator-apisix] membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603207502 > I see some of the docs use this IP `http://39.97.63.215/` we should change it to another address. PR welcome

[GitHub] [incubator-apisix] membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org

2020-03-24 Thread GitBox
membphis edited a comment on issue #1250: APISIX occasionally returns 500 for httpbin.org URL: https://github.com/apache/incubator-apisix/issues/1250#issuecomment-603207149 > BTW, a suggestion why don't we host an echo service for APISIX itself? https://github.com/apache/incubator-a

[GitHub] [incubator-apisix] membphis commented on issue #1329: apisix in Stand-alone mode Health check does not take effect

2020-03-24 Thread GitBox
membphis commented on issue #1329: apisix in Stand-alone mode Health check does not take effect URL: https://github.com/apache/incubator-apisix/issues/1329#issuecomment-603225266 @isNextJuly please make a try with the latest master branch, we have fixed this bug.

[incubator-apisix] branch master updated: deletion: drop webdocket enable control in proxy-rewrite plugin (#1332)

2020-03-24 Thread liling
This is an automated email from the ASF dual-hosted git repository. liling pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 5be1daa deletion: drop webdocket enab

[GitHub] [incubator-apisix] lilien1010 closed issue #1331: request help: I think we can remove websocket in proxy-write plguin

2020-03-24 Thread GitBox
lilien1010 closed issue #1331: request help: I think we can remove websocket in proxy-write plguin URL: https://github.com/apache/incubator-apisix/issues/1331 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-apisix] lilien1010 merged pull request #1332: deletion: drop webdocket enable control in proxy-rewrite plugin

2020-03-24 Thread GitBox
lilien1010 merged pull request #1332: deletion: drop webdocket enable control in proxy-rewrite plugin URL: https://github.com/apache/incubator-apisix/pull/1332 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1312: Kafka Logger.

2020-03-24 Thread GitBox
Akayeshmantha commented on issue #1312: Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1312#issuecomment-603233395 @membphis done This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397146805 ## File path: lua/apisix.lua ## @@ -32,14 +32,21 @@ local pairs = pairs local tostring = tostring local load

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397146090 ## File path: conf/config.yaml ## @@ -80,7 +80,7 @@ apisix: # udp:# UDP proxy port list #

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397142249 ## File path: bin/apisix ## @@ -119,6 +122,9 @@ stream { .. [=[{*lua_cpath*};"; lua_socket_log_

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397145027 ## File path: bin/apisix ## @@ -260,7 +266,12 @@ http { init_by_lua_block { require "resty.core" api

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397150826 ## File path: lua/apisix.lua ## @@ -32,14 +32,21 @@ local pairs = pairs local tostring = tostring local load

[GitHub] [incubator-apisix] membphis commented on issue #1312: Kafka Logger.

2020-03-24 Thread GitBox
membphis commented on issue #1312: Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1312#issuecomment-603241569 @Akayeshmantha It missing doc now. The source code is fine. This is an automated message

[GitHub] [incubator-apisix] membphis commented on issue #1332: deletion: drop webdocket enable control in proxy-rewrite plugin

2020-03-24 Thread GitBox
membphis commented on issue #1332: deletion: drop webdocket enable control in proxy-rewrite plugin URL: https://github.com/apache/incubator-apisix/pull/1332#issuecomment-603244789 @lilien1010 It is recommended to increase the version number of this plugin. https://github.com/lilien1

[GitHub] [incubator-apisix] membphis commented on issue #1243: request help: How to white-list consumers for the Keyauth plugin

2020-03-24 Thread GitBox
membphis commented on issue #1243: request help: How to white-list consumers for the Keyauth plugin URL: https://github.com/apache/incubator-apisix/issues/1243#issuecomment-603252306 > @membphis This is how the implementation will look like this: It looks good to me. @moonming What

[GitHub] [incubator-apisix] membphis commented on issue #1284: feature: support to print log with specific prefix.

2020-03-24 Thread GitBox
membphis commented on issue #1284: feature: support to print log with specific prefix. URL: https://github.com/apache/incubator-apisix/pull/1284#issuecomment-603254993 > why we need this feature? It is easier to view the error log by printing the error log with a specific prefix. -

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397176156 ## File path: lua/apisix/plugins/cors.lua ## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundat

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397174708 ## File path: lua/apisix/plugins/cors.lua ## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundat

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397175648 ## File path: lua/apisix/plugins/cors.lua ## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundat

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397174107 ## File path: lua/apisix/plugins/cors.lua ## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundat

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397178542 ## File path: t/plugin/cors.t ## @@ -0,0 +1,414 @@ +# +# Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r397175160 ## File path: lua/apisix/plugins/cors.lua ## @@ -0,0 +1,142 @@ +-- +-- Licensed to the Apache Software Foundat

[GitHub] [incubator-apisix] membphis commented on issue #1100: bug: 【CORS Problem】Browser auto sends OPTIONS request, cannot match header, CURL request is fine

2020-03-24 Thread GitBox
membphis commented on issue #1100: bug: 【CORS Problem】Browser auto sends OPTIONS request, cannot match header, CURL request is fine URL: https://github.com/apache/incubator-apisix/issues/1100#issuecomment-603268207 https://github.com/apache/incubator-apisix/pull/1327/files#diff-5caafc3385

[GitHub] [incubator-apisix] membphis closed issue #1100: bug: 【CORS Problem】Browser auto sends OPTIONS request, cannot match header, CURL request is fine

2020-03-24 Thread GitBox
membphis closed issue #1100: bug: 【CORS Problem】Browser auto sends OPTIONS request, cannot match header, CURL request is fine URL: https://github.com/apache/incubator-apisix/issues/1100 This is an automated message from the

[GitHub] [incubator-apisix] membphis commented on issue #1326: Is it possible to have a script to convert etcd data and apisix.yaml file to each other?

2020-03-24 Thread GitBox
membphis commented on issue #1326: Is it possible to have a script to convert etcd data and apisix.yaml file to each other? URL: https://github.com/apache/incubator-apisix/issues/1326#issuecomment-603269376 No such feature at present, welcome to contribute PR -

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397202735 ## File path: bin/apisix ## @@ -260,7 +266,12 @@ http { init_by_lua_block { require "resty.core" api

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397203146 ## File path: conf/config.yaml ## @@ -80,7 +80,7 @@ apisix: # udp:# UDP proxy port list #

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397203754 ## File path: t/APISIX.pm ## @@ -196,7 +196,7 @@ _EOC_ lua_shared_dict upstream-healthcheck 32m; lua_shared_dict

[GitHub] [incubator-apisix] moonming opened a new issue #1335: This is a backwards incompatible modification and should be specifically noted in PR

2020-03-24 Thread GitBox
moonming opened a new issue #1335: This is a backwards incompatible modification and should be specifically noted in PR URL: https://github.com/apache/incubator-apisix/issues/1335 This is a backwards incompatible modification and should be specifically noted in PR @lilien1010 _Or

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1312: Kafka Logger.

2020-03-24 Thread GitBox
Akayeshmantha commented on issue #1312: Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1312#issuecomment-603466683 Added @membphis. And rebased with the master :smiley: This is an automated message from the

[GitHub] [incubator-apisix] Akayeshmantha opened a new issue #1336: Cron Job to clear travis ci cache daily .

2020-03-24 Thread GitBox
Akayeshmantha opened a new issue #1336: Cron Job to clear travis ci cache daily . URL: https://github.com/apache/incubator-apisix/issues/1336 With the no of builds taking place from time to time, Travis ci gets slow. Will it be a good solution to remove cache daily with a cron job in Travi

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1217: enable local DNS

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1217: enable local DNS URL: https://github.com/apache/incubator-apisix/pull/1217#discussion_r397495748 ## File path: lua/apisix.lua ## @@ -32,14 +32,20 @@ local pairs = pairs local tostring = tostring local load

[GitHub] [incubator-apisix] membphis commented on issue #1336: Cron Job to clear travis ci cache daily .

2020-03-24 Thread GitBox
membphis commented on issue #1336: Cron Job to clear travis ci cache daily . URL: https://github.com/apache/incubator-apisix/issues/1336#issuecomment-603537293 These caches are mainly used to speed up environment installation. If we remove it, it will cause Travis to create the environment

[GitHub] [incubator-apisix] membphis opened a new issue #1337: doc(kafka-logger): Chinese version with minor changes.

2020-03-24 Thread GitBox
membphis opened a new issue #1337: doc(kafka-logger): Chinese version with minor changes. URL: https://github.com/apache/incubator-apisix/issues/1337 https://github.com/apache/incubator-apisix/pull/1312/files#diff-50701cc078da868ee61347ef72b1ab43 --

[GitHub] [incubator-apisix] moonming merged pull request #1312: Kafka Logger.

2020-03-24 Thread GitBox
moonming merged pull request #1312: Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-apisix] moonming closed issue #1259: Add support to kafka publisher plugin

2020-03-24 Thread GitBox
moonming closed issue #1259: Add support to kafka publisher plugin URL: https://github.com/apache/incubator-apisix/issues/1259 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-apisix] branch master updated: feature: add Kafka Logger plugin. (#1312)

2020-03-24 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 8adafa3 feature: add Kafka Logger pl

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397551915 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397549527 ## File path: doc/discovery-cn.md ## @@ -0,0 +1,79 @@ + + +# 集成服务发现注册中心 + +

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397551739 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397552118 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397551409 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] membphis removed a comment on issue #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis removed a comment on issue #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#issuecomment-603583845 I think this PR is ready for review. What do you think? @qiujiayu ---

[GitHub] [incubator-apisix] membphis commented on issue #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
membphis commented on issue #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#issuecomment-603583845 I think this PR is ready for review. What do you think? @qiujiayu ---

[incubator-apisix-dashboard] branch master updated: feature:allow set filter_func in router configuation page (#164)

2020-03-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new cfb3ee7 feature:allow se

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #164: feature:allow set filter_func in router configuation page

2020-03-24 Thread GitBox
juzhiyuan merged pull request #164: feature:allow set filter_func in router configuation page URL: https://github.com/apache/incubator-apisix-dashboard/pull/164 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-apisix] membphis closed issue #1202: bug: prometheus and zipkin do not support global_rule

2020-03-24 Thread GitBox
membphis closed issue #1202: bug: prometheus and zipkin do not support global_rule URL: https://github.com/apache/incubator-apisix/issues/1202 This is an automated message from the Apache Git Service. To respond to the messa

[incubator-apisix] branch master updated: feature: run log plugins in the global rule (#1333)

2020-03-24 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new be34880 feature: run log plugins in

[GitHub] [incubator-apisix] membphis merged pull request #1333: feature: run log plugins in the global rule

2020-03-24 Thread GitBox
membphis merged pull request #1333: feature: run log plugins in the global rule URL: https://github.com/apache/incubator-apisix/pull/1333 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-apisix-website] moonming opened a new issue #19: add committer page and team page

2020-03-24 Thread GitBox
moonming opened a new issue #19: add committer page and team page URL: https://github.com/apache/incubator-apisix-website/issues/19 for example: https://shardingsphere.apache.org/community/en/contribute/committer/ https://shardingsphere.apache.org/community/en/team/ --

[GitHub] [incubator-apisix] ShiningRush commented on issue #1202: bug: prometheus and zipkin do not support global_rule

2020-03-24 Thread GitBox
ShiningRush commented on issue #1202: bug: prometheus and zipkin do not support global_rule URL: https://github.com/apache/incubator-apisix/issues/1202#issuecomment-603600053 It seems just run log phase for global rules but did not run header_filter and body_filter phase, cors plugin will

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397569901 ## File path: doc/discovery-cn.md ## @@ -0,0 +1,79 @@ + + +# 集成服务发现注册中心 + +

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397570035 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397570094 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397570067 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397569969 ## File path: lua/apisix/discovery/eureka.lua ## @@ -0,0 +1,178 @@ +-- +--

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397570824 ## File path: .travis/linux_openresty_runner.sh ## @@ -94,6 +94,13 @@ do_in

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397571158 ## File path: conf/config.yaml ## @@ -93,7 +93,7 @@ apisix: listen_por

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397570921 ## File path: .travis/linux_tengine_runner.sh ## @@ -231,6 +231,12 @@ do_in

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397571025 ## File path: .travis/osx_openresty_runner.sh ## @@ -43,11 +43,14 @@ do_ins

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397571801 ## File path: conf/config.yaml ## @@ -146,3 +146,11 @@ plugins:

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #19: add committer page and team page

2020-03-24 Thread GitBox
juzhiyuan commented on issue #19: add committer page and team page URL: https://github.com/apache/incubator-apisix-website/issues/19#issuecomment-603603194 Noted, I will handle this this week. This is an automated message fro

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #19: add committer page and team page

2020-03-24 Thread GitBox
juzhiyuan commented on issue #19: add committer page and team page URL: https://github.com/apache/incubator-apisix-website/issues/19#issuecomment-603603239 If it's urgent, please let me know. This is an automated message from

[GitHub] [incubator-apisix] membphis commented on issue #1312: Kafka Logger.

2020-03-24 Thread GitBox
membphis commented on issue #1312: Kafka Logger. URL: https://github.com/apache/incubator-apisix/pull/1312#issuecomment-603604329 @Akayeshmantha many thx This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397574059 ## File path: .travis/linux_openresty_runner.sh ## @@ -94,6 +94,13 @@ do_in

[GitHub] [incubator-apisix] membphis opened a new issue #1338: feature: support to run `header_filter` and `body_filter` phase for global rules

2020-03-24 Thread GitBox
membphis opened a new issue #1338: feature: support to run `header_filter` and `body_filter` phase for global rules URL: https://github.com/apache/incubator-apisix/issues/1338 original comments: https://github.com/apache/incubator-apisix/issues/1202#issuecomment-603600053

[GitHub] [incubator-apisix] membphis commented on issue #1202: bug: prometheus and zipkin do not support global_rule

2020-03-24 Thread GitBox
membphis commented on issue #1202: bug: prometheus and zipkin do not support global_rule URL: https://github.com/apache/incubator-apisix/issues/1202#issuecomment-603605701 @ShiningRush I have created a new issue: https://github.com/apache/incubator-apisix/issues/1338 PR welcome --

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
moonming commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397575813 ## File path: .travis/linux_openresty_runner.sh ## @@ -94,6 +94,13 @@ do_in

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397577139 ## File path: conf/config.yaml ## @@ -93,7 +93,7 @@ apisix: listen_por

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397578591 ## File path: conf/config.yaml ## @@ -93,7 +93,7 @@ apisix: listen_por

[GitHub] [incubator-apisix] qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center

2020-03-24 Thread GitBox
qiujiayu commented on a change in pull request #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#discussion_r397580963 ## File path: .travis/linux_openresty_runner.sh ## @@ -94,6 +94,13 @@ do_in

  1   2   >