imjoey commented on pull request #293:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/293#issuecomment-655319035
@juzhiyuan @gxthrj Thank you very much.
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 89bcb7b Format codes by
juzhiyuan merged pull request #293:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
wrl96 commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451444391
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-upstream_uri =
membphis commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451455993
##
File path: t/router/radixtree-sni.t
##
@@ -448,15 +448,15 @@ location /t {
local ssl_key = t.read_file("conf/cert/test2.key")
DHB-liuhong opened a new pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819
Signed-off-by: liuhong
NOTE: Please read the Contributing.md guidelines before submitting your
patch:
Rapiz1 opened a new pull request #299:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/299
Add a commit-msg checker
Resolves https://github.com/apache/incubator-apisix-dashboard/issues/140
@juzhiyuan Can you test this on Mac?
membphis commented on pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819#issuecomment-655531461
Why do we need this feature?
This is an automated message from the Apache Git Service.
To respond to
membphis commented on issue #1820:
URL:
https://github.com/apache/incubator-apisix/issues/1820#issuecomment-655527361
read request body, please take a look at this document:
https://github.com/openresty/lua-nginx-module#ngxreqread_body
read URL parameters, you can take a look at
wrl96 commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451437233
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-upstream_uri =
membphis commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451435752
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-
membphis commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451555616
##
File path: apisix/http/router/radixtree_sni.lua
##
@@ -172,13 +171,13 @@ function _M.match_and_set(api_ctx)
end
end
membphis commented on pull request #1813:
URL: https://github.com/apache/incubator-apisix/pull/1813#issuecomment-655431764
@yongboy many thx, merged
This is an automated message from the Apache Git Service.
To respond to the
membphis closed issue #1812:
URL: https://github.com/apache/incubator-apisix/issues/1812
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 6fec021 doc: fixed
membphis merged pull request #1813:
URL: https://github.com/apache/incubator-apisix/pull/1813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nic-chen opened a new issue #1817:
URL: https://github.com/apache/incubator-apisix/issues/1817
### Issue description
In the case of multiple ssl certificates, some certificates are not
available.
### Environment
* apisix version (cmd: `apisix version`): 1.4
nic-chen opened a new pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818
### Summary
fix multi ssl bug
This bug affects released version 1.4
### Issues resolved
Fix #1817
UnderTreeTech opened a new issue #1820:
URL: https://github.com/apache/incubator-apisix/issues/1820
In apisix core.request it only expose apis to get/set header, get remote ip.
I wanna develop a plugin to check request signature is valid or not, How to
get request body and url
UnderTreeTech commented on issue #1820:
URL:
https://github.com/apache/incubator-apisix/issues/1820#issuecomment-655534394
I think it's better to expose apis to get body and url parameters in
core.request. Users can start to develop quickly based on apisix. @membphis
juzhiyuan commented on pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#issuecomment-655564820
> Add a commit-msg checker
>
> Resolves #140
>
> @juzhiyuan Can you test this on Mac?
Not yet. I switched to Windows those days..
Rapiz1 commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451602355
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
membphis commented on issue #1820:
URL:
https://github.com/apache/incubator-apisix/issues/1820#issuecomment-655593707
yes, that is better. welcome PR ^_^
This is an automated message from the Apache Git Service.
To respond
Rapiz1 commented on pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#issuecomment-655569824
> Not yet. I switched to Windows those days..
Not a big deal. This will probably works well on Mac according to
juzhiyuan commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451600800
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
Rapiz1 commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451603611
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
membphis commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451637246
##
File path: apisix/http/router/radixtree_sni.lua
##
@@ -159,7 +158,7 @@ function _M.match_and_set(api_ctx)
local sni_rev = sni:reverse()
membphis merged pull request #1814:
URL: https://github.com/apache/incubator-apisix/pull/1814
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git
The following commit(s) were added to refs/heads/master by this push:
new a4c3c0f doc: update the text of DP
spacewander commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451904860
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-
nic-chen commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451909297
##
File path: .travis/osx_openresty_runner.sh
##
@@ -23,8 +23,8 @@ export_or_prefix() {
}
before_install() {
-HOMEBREW_NO_AUTO_UPDATE=1
moonming commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451908370
##
File path: .travis/osx_openresty_runner.sh
##
@@ -23,8 +23,8 @@ export_or_prefix() {
}
before_install() {
-HOMEBREW_NO_AUTO_UPDATE=1
moonming opened a new pull request #1822:
URL: https://github.com/apache/incubator-apisix/pull/1822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
membphis commented on pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793#issuecomment-655912271
@wingsjj many thx, merged
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on pull request #1822:
URL: https://github.com/apache/incubator-apisix/pull/1822#issuecomment-655913056
We can merge this PR after 3-5 days. We need to confirm that GitHub action
CI is running steadily.
DHB-liuhong commented on pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819#issuecomment-655917700
ok
This is an automated message from the Apache Git Service.
To respond to the message, please
DHB-liuhong closed pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
membphis commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451913029
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-
wrl96 commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451924979
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-upstream_uri =
tiger333777 opened a new issue #300:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/300
After the SSL certificate is started in the dashboard, switch to another
page and return. SSL is not enabled again
membphis commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451936133
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-
membphis commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655869410
please make a try:
```shell
curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri":
jackwoods commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655871370
The other question is: when proxy pass to upstream, some times we need to
change the header host to the upstream host, seems not easy to do it.
membphis commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655874083
> I have a question about the route id, we always need to specified it?
> In the admin panel, if I create a route, then the id will be
auto-generated.
you can
Rapiz1 commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451946124
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
wrl96 commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-apisix/pull/1816#discussion_r451948319
##
File path: apisix/plugins/proxy-rewrite.lua
##
@@ -153,10 +154,20 @@ function _M.rewrite(conf, ctx)
end
end
-upstream_uri =
membphis commented on a change in pull request #1818:
URL: https://github.com/apache/incubator-apisix/pull/1818#discussion_r451913826
##
File path: t/router/radixtree-sni.t
##
@@ -951,7 +951,7 @@ connected: 1
failed to do SSL handshake: certificate host mismatch
---
DHB-liuhong commented on pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819#issuecomment-655853292
I think it is need to separate prometheus and access log，it is good for
analysing log.
This
jackwoods opened a new issue #1821:
URL: https://github.com/apache/incubator-apisix/issues/1821
### Issue description
请教个问题，我有个具体需求，就是路由叫/search/api, 有2个upstream 10.10.10.1:, 10.10.10.2:,
需要rewrite：["^/search/api(.*)$","$1"],这种情况下如何在1.3完成这个配置（最佳实践）？多谢！
### Environment
membphis commented on pull request #1819:
URL: https://github.com/apache/incubator-apisix/pull/1819#issuecomment-655866623
I do not think so. the `uri` is very different, it is easy to confirm if it
is `prometheus` request.
jackwoods commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655870553
I have a question about the route id, we always need to specified it?
In the admin panel, if I create a route, then the id will be auto-generated.
jackwoods commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655871944
The final question is, to make the upstream reusable, I'd better create an
independent upstream, then change it in the admin panel?
jackwoods edited a comment on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655871370
Another question is: when proxy pass to upstream, some times we need to
change the header host to the upstream host, seems not easy to do it.
jackwoods edited a comment on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655871370
Another question is: when proxy pass to upstream, sometimes we need to
change the header host to the upstream host, seems not easy to do it.
membphis commented on issue #1821:
URL:
https://github.com/apache/incubator-apisix/issues/1821#issuecomment-655874642
> The final question is, to make the upstream reusable, I'd better create an
independent upstream, then change it in the admin panel?
you are right.
Rapiz1 commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451945375
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
Rapiz1 commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451945375
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
juzhiyuan commented on a change in pull request #299:
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/299#discussion_r451945022
##
File path: scripts/verifyCommit.js
##
@@ -0,0 +1,44 @@
+/*
+The MIT License (MIT)
+
+Copyright (c) 2018-present, Yuxi (Evan) You
+
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 0e517a2 feature: using GitHub
moonming merged pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
moonming closed issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
61 matches
Mail list logo
