[GitHub] [apisix-website] moonming commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
moonming commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488364826 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[apisix-dashboard] branch master updated: feat: remove netlify (#472)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 361392f feat: remove netlify

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #472: feat: remove netlify

2020-09-14 Thread GitBox
juzhiyuan merged pull request #472: URL: https://github.com/apache/apisix-dashboard/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468901 > This is what identity authentication needs to do, such as ACL, right? Yes. This is an automated message

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469543 Assigned to me. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469486 the same as https://github.com/apache/apisix/issues/385 This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Caelebs closed issue #2224: request help: k8s部署日志提示failed to read `apisix` field from yaml file

2020-09-14 Thread GitBox
Caelebs closed issue #2224: URL: https://github.com/apache/apisix/issues/2224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] Firstsawyou opened a new issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou opened a new issue #2229: URL: https://github.com/apache/apisix/issues/2229 ### Issue description Configure multiple "service" objects. I want to restrict the "service" on the "consumer". What should I do? For example: "service" has: serv1, serv2 and serv3. In "consumer",

[apisix] branch master updated (2999541 -> 12a0b13)

2020-09-14 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 2999541 fix: change the config file when deploying apisix in k8s #2182 (#2185) add 12a0b13 bugfix: use the

[GitHub] [apisix] moonming merged pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
moonming merged pull request #2211: URL: https://github.com/apache/apisix/pull/2211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692472362 > How do you plan to implement this feature? It is planned to create a whitelisted plug-in through "service_id", which is bound to "consumer".

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692476896 please take a look at kong's ACL plugin too: https://docs.konghq.com/hub/kong-inc/acl/ Thanks, Ming Wen Twitter: _WenMing Firstsawyou 于2020年9月15日周二

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692473633 > the same as #385 Ok,let me take a look. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488403217 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[apisix-website] branch feat-trademarks updated (46dc0ec -> 69a1a4f)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-trademarks in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 46dc0ec feat: added desc add 69a1a4f feat: added tagline2 No new revisions were added by

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488400764 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468240 This is what identity authentication needs to do, such as ACL, right? This is an automated message from the Apache

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692470173 How do you plan to implement this feature? This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488339941 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +-

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488343173 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +-

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

2020-09-14 Thread GitBox
juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-692423742 @moonming @membphis Please provide the priority for every category and plugin. This is an automated

[GitHub] [apisix] shuaijinchao commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
shuaijinchao commented on pull request #2211: URL: https://github.com/apache/apisix/pull/2211#issuecomment-692425998 Follow-up can support dynamic upstream according to request information, cool. This is an automated

[GitHub] [apisix] tokers commented on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

2020-09-14 Thread GitBox
tokers commented on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-692426801 @membphis May i pick it up? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488348093 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] Miss-you commented on pull request #2226: doc: added channel at slack and added new qq group.

2020-09-14 Thread GitBox
Miss-you commented on pull request #2226: URL: https://github.com/apache/apisix/pull/2226#issuecomment-692431848 ![image](https://user-images.githubusercontent.com/3816205/93160059-22162400-f742-11ea-98d3-300e4269365a.png) 836398818

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487712284 ## File path: t/plugin/custom_hmac_auth.t ## @@ -0,0 +1,364 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on issue #2175: bug: kafka-logger plugin comes with exception logs

2020-09-14 Thread GitBox
moonming commented on issue #2175: URL: https://github.com/apache/apisix/issues/2175#issuecomment-691904413 the default value of `max_retry_count` is 0, you can increase this value then try. @sshniro Is it small to set `max_retry_count` default value to 0?

[GitHub] [apisix] gxthrj commented on a change in pull request #2185: fix: change the config file when deploying apisix in k8s #2182

2020-09-14 Thread GitBox
gxthrj commented on a change in pull request #2185: URL: https://github.com/apache/apisix/pull/2185#discussion_r487748006 ## File path: kubernetes/README.md ## @@ -57,11 +48,15 @@ etcd: Create configmap for apache apisix +you will change some config by use

[GitHub] [apisix] moonming commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r487758643 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check

[GitHub] [apisix] moonming closed issue #2186: bug: The log keeps printing "wait for more time, context: ngx.timer"

2020-09-14 Thread GitBox
moonming closed issue #2186: URL: https://github.com/apache/apisix/issues/2186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487773165 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487798835 ## File path: conf/config-default.yaml ## @@ -185,6 +185,7 @@ plugins: # plugin list - proxy-cache - proxy-mirror -

[GitHub] [apisix] membphis commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-691957197 one more thing, we need to check the `etcd` version in `bin/apisix`, confirm the `etcd` version `>= 3.4` .

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487799703 ## File path: apisix/plugins/slslog/rfc5424.lua ## @@ -0,0 +1,107 @@ +-- Review comment: I reference it and change some codes for aliyun.

[apisix] branch kv/k8s-config updated (8f3e458 -> b9b1e2d)

2020-09-14 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8f3e458 fix: change the config file when deploying apisix in k8s #2182 add b9b1e2d docs: Simplify the

[apisix] branch kv/k8s-config updated (8f3e458 -> b9b1e2d)

2020-09-14 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8f3e458 fix: change the config file when deploying apisix in k8s #2182 add b9b1e2d docs: Simplify the

[apisix] branch kv/k8s-config updated (b9b1e2d -> d2a30b5)

2020-09-14 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git. from b9b1e2d docs: Simplify the configuration and description of configmap add 47d39e7 bugfix:

[GitHub] [apisix] moonming commented on issue #2184: bug: limit-conn,After limiting concurrency for the first time, all subsequent requests are blocked

2020-09-14 Thread GitBox
moonming commented on issue #2184: URL: https://github.com/apache/apisix/issues/2184#issuecomment-691906343 Can you provide reproduction steps using admin API? @y934317258 thx This is an automated message from the Apache

[GitHub] [apisix] idbeta commented on issue #2215: Used TscanCode scan the lua code,it report two code defects

2020-09-14 Thread GitBox
idbeta commented on issue #2215: URL: https://github.com/apache/apisix/issues/2215#issuecomment-691954151 @spacewander it's apisix 1.5 master branch [.../apisix/http/router/radixtree_sni.lua:162]: (Critical) [radixtree_router] is used after check at line 147

[GitHub] [apisix] moonming commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487694974 ## File path: t/plugin/custom_hmac_auth.t ## @@ -0,0 +1,364 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #2177: feat: support logger for aliyun log service

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487745645 ## File path: apisix/plugins/slslog/rfc5424.lua ## @@ -0,0 +1,107 @@ +-- Review comment: Is this file from

[GitHub] [apisix] moonming commented on pull request #2177: feat: support logger for aliyun log service

2020-09-14 Thread GitBox
moonming commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-691919137 @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? This is an

[GitHub] [apisix] spacewander merged pull request #2174: optimize set nginx conf env

2020-09-14 Thread GitBox
spacewander merged pull request #2174: URL: https://github.com/apache/apisix/pull/2174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: define env in nginx.conf template (#2174)

2020-09-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 312a97c feat: define env in nginx.conf

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487799703 ## File path: apisix/plugins/slslog/rfc5424.lua ## @@ -0,0 +1,107 @@ +-- Review comment: I reference it and change some codes for aliyun.

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487800878 ## File path: t/plugin/sls-logger.t ## @@ -0,0 +1,174 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] moonming commented on issue #2190: request help: What is the current circuit breaker strategy and where is it introduced

2020-09-14 Thread GitBox
moonming commented on issue #2190: URL: https://github.com/apache/apisix/issues/2190#issuecomment-691887326 @y934317258 sorry for the late reply. This is configurable, please take a look at https://github.com/apache/apisix/blob/master/doc/health-check.md.

[GitHub] [apisix] moonming commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
moonming commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-691920387 No, we need to change 4 files if we upgrade etcd version. Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月14日周一 下午4:55写道: > *@membphis*

[GitHub] [apisix] membphis commented on a change in pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487731432 ## File path: t/admin/schema.t ## @@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/ --- request GET /apisix/admin/schema/service --- response_body

[GitHub] [apisix] membphis commented on a change in pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487732038 ## File path: t/admin/services.t ## @@ -1085,3 +1085,50 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 31: set service(id:

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487736639 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] moonming commented on pull request #2177: feat: support logger for aliyun log service

2020-09-14 Thread GitBox
moonming commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-691917779 @membphis @nic-chen please take a look This is an automated message from the Apache Git Service. To respond to

[apisix] branch kv/k8s-config updated (d2a30b5 -> 7e530a4)

2020-09-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git. from d2a30b5 Merge branch 'master' into kv/k8s-config add faae61e bugfix: load yaml config in

[GitHub] [apisix] EnableAsync opened a new pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
EnableAsync opened a new pull request #2225: URL: https://github.com/apache/apisix/pull/2225 ### What this PR does / why we need it: #2125 move etcd cluster in docker for CI ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or

[GitHub] [apisix] moonming commented on issue #2125: request help: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
moonming commented on issue #2125: URL: https://github.com/apache/apisix/issues/2125#issuecomment-691872136 > Then I changed the version of etcd to `3.2` and found that `openresty` passes all test cases, but `tengine` has one test case that does not pass. >

[GitHub] [apisix] moonming commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487706803 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] tokers commented on pull request #2216: improve: use optimistic locking to avoid concurrency problem in admin…

2020-09-14 Thread GitBox
tokers commented on pull request #2216: URL: https://github.com/apache/apisix/pull/2216#issuecomment-691908751 @membphis :) This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487755488 ## File path: .travis/linux_tengine_runner.sh ## @@ -259,6 +259,12 @@ do_install() { sudo luarocks install luacheck > build.log 2>&1 || (cat

[apisix] branch master updated (4b756ec -> faae61e)

2020-09-14 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4b756ec doc: fix formatting (#2210) add faae61e bugfix: load yaml config in privileged agent (#2218) No new

[GitHub] [apisix] moonming merged pull request #2218: bugfix: load yaml config in privileged agent

2020-09-14 Thread GitBox
moonming merged pull request #2218: URL: https://github.com/apache/apisix/pull/2218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487783372 ## File path: t/plugin/hmac-auth.t ## @@ -0,0 +1,581 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] Caelebs opened a new issue #2224: request help: k8s部署日志提示failed to read `apisix` field from yaml file

2020-09-14 Thread GitBox
Caelebs opened a new issue #2224: URL: https://github.com/apache/apisix/issues/2224 ### Issue description ``` /usr/local/openresty/luajit/bin/luajit: /usr/bin/apisix:701: failed to read `apisix` field from yaml file stack traceback: [C]: in function 'error'

[apisix] branch master updated: fix: change the config file when deploying apisix in k8s #2182 (#2185)

2020-09-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2999541 fix: change the config file when

[GitHub] [apisix-dashboard] juzhiyuan closed issue #457: request help: How to resolve the license conflict in the file header.

2020-09-14 Thread GitBox
juzhiyuan closed issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #457: request help: How to resolve the license conflict in the file header.

2020-09-14 Thread GitBox
juzhiyuan commented on issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457#issuecomment-692076245 closed now, feel free to reopen it if needed. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487937146 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,156 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487958081 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] membphis closed issue #2197: request help: How to ensure the security of token without password

2020-09-14 Thread GitBox
membphis closed issue #2197: URL: https://github.com/apache/apisix/issues/2197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis commented on issue #2197: request help: How to ensure the security of token without password

2020-09-14 Thread GitBox
membphis commented on issue #2197: URL: https://github.com/apache/apisix/issues/2197#issuecomment-692104510 the client needs to know the valid `user-key` first, then the client can request the source he needs with token. for more information about JWT token, you can take a look at:

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487791781 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487799703 ## File path: apisix/plugins/slslog/rfc5424.lua ## @@ -0,0 +1,107 @@ +-- Review comment: I reference it and change some codes ,this codes is not

[GitHub] [apisix] tokers commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
tokers commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487852649 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487924251 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487938697 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,156 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487970495 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487992864 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487867038 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] gy09535 commented on pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special config, we

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487837001 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] spacewander merged pull request #2185: fix: change the config file when deploying apisix in k8s #2182

2020-09-14 Thread GitBox
spacewander merged pull request #2185: URL: https://github.com/apache/apisix/pull/2185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487800878 ## File path: t/plugin/sls-logger.t ## @@ -0,0 +1,174 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487989714 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487990382 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488008439 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488014261 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488063399 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] moonming commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488025254 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487997453 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488064180 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488101612 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488042113 ## File path: .travis/linux_tengine_runner.sh ## @@ -259,6 +259,12 @@ do_install() { sudo luarocks install luacheck > build.log 2>&1 || (cat

[GitHub] [apisix] moonming commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488027011 ## File path: t/plugin/custom_hmac_auth.t ## @@ -0,0 +1,364 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2225: URL: https://github.com/apache/apisix/pull/2225#discussion_r488031603 ## File path: .github/workflows/build.yml ## @@ -28,9 +28,13 @@ jobs: #

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488062025 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488073128 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487997808 ## File path: README.md ## @@ -166,10 +166,9 @@ There are several ways to install the Apache Release version of APISIX: apisix start

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488019814 ## File path: t/core/etcd-auth-fail.t ## @@ -18,24 +18,33 @@ BEGIN { $ENV{"ETCD_ENABLE_AUTH"} = "false" } -use t::APISIX 'no_plan'; +use

[GitHub] [apisix] moonming commented on a change in pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2225: URL: https://github.com/apache/apisix/pull/2225#discussion_r488032627 ## File path: .github/workflows/build.yml ## @@ -28,9 +28,13 @@ jobs: #

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488057502 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[],

  1   2   >