tokers commented on a change in pull request #2233:
URL: https://github.com/apache/apisix/pull/2233#discussion_r489186175
##
File path: bin/apisix
##
@@ -885,20 +939,44 @@ local function init_etcd(show_output)
yaml_conf.etcd.host = {yaml_conf.etcd.host}
end
+
tokers commented on a change in pull request #2233:
URL: https://github.com/apache/apisix/pull/2233#discussion_r489186316
##
File path: bin/apisix
##
@@ -885,20 +939,44 @@ local function init_etcd(show_output)
yaml_conf.etcd.host = {yaml_conf.etcd.host}
end
+
moonming closed issue #1653:
URL: https://github.com/apache/apisix/issues/1653
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming commented on issue #1653:
URL: https://github.com/apache/apisix/issues/1653#issuecomment-693203832
fixed by https://github.com/apache/apisix/pull/2192
This is an automated message from the Apache Git Service.
To
ShiningRush commented on pull request #:
URL: https://github.com/apache/apisix/pull/#issuecomment-693263708
This bug should result in an error for each request, then test case 5 should
fail, proving that the case does not cover the situation, I guess it should be
caused by the
This is an automated email from the ASF dual-hosted git repository.
vinci pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/refactor by this push:
new 24c627a fmt project
24c627a is
moonming commented on pull request #2230:
URL: https://github.com/apache/apisix/pull/2230#issuecomment-693237220
I don't think so, `YOUR_OWN_API_TOKEN` is good as hint, not the real token.
we can keep the current token
tokers commented on a change in pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#discussion_r489240353
##
File path: apisix/http/router/radixtree_sni.lua
##
@@ -95,14 +109,22 @@ local function create_router(ssl_items)
end
--
tokers commented on a change in pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#discussion_r489240639
##
File path: apisix/http/router/radixtree_sni.lua
##
@@ -62,6 +62,20 @@ local function parse_pem_priv_key(sni, pkey)
end
+local function
liuxiran commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693247410
admin/admin
This is an automated message from the Apache Git Service.
To respond to the message, please
membphis merged pull request #2193:
URL: https://github.com/apache/apisix/pull/2193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 84ce7ba feat: add AK/SK(HMAC) auth plugin. (#2192)
add d1fe72c bugfix: fixed wrong zipkin Arguments (#2193)
membphis closed issue #2191:
URL: https://github.com/apache/apisix/issues/2191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis commented on issue #2235:
URL: https://github.com/apache/apisix/issues/2235#issuecomment-693252142
@dickens7 welcome to fix this issue when you have time
This is an automated message from the Apache Git Service.
To
tokers commented on pull request #2216:
URL: https://github.com/apache/apisix/pull/2216#issuecomment-693237994
@membphis @moonming This PR should be adjusted to the ETCD v3 data
structure, So i mark it as work in progress.
membphis commented on a change in pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#discussion_r489233605
##
File path: apisix/http/router/radixtree_sni.lua
##
@@ -62,6 +62,20 @@ local function parse_pem_priv_key(sni, pkey)
end
+local function
Caelebs opened a new issue #478:
URL: https://github.com/apache/apisix-dashboard/issues/478
Please answer these questions before submitting your issue.
### Question
- What is the default account password of the dashboard?
membphis commented on pull request #2216:
URL: https://github.com/apache/apisix/pull/2216#issuecomment-693242116
@tokers got it, we can merge this PR later
This is an automated message from the Apache Git Service.
To respond
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489260881
##
File path: t/admin/services.t
##
@@ -1085,3 +1085,97 @@ GET /t
--- error_code: 400
--- no_error_log
[error]
+
+
+
+=== TEST 31: set empty service.
ShiningRush removed a comment on pull request #:
URL: https://github.com/apache/apisix/pull/#issuecomment-693263708
This bug should result in an error for each request, then test case 5 should
fail, proving that the case does not cover the situation, I guess it should be
caused by
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 84ce7ba feat: add AK/SK(HMAC) auth plugin.
moonming merged pull request #2192:
URL: https://github.com/apache/apisix/pull/2192
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tokers removed a comment on pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#issuecomment-693219910
@moonming OK.
This is an automated message from the Apache Git Service.
To respond to the message, please
tokers commented on pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#issuecomment-693219910
@moonming OK.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
moonming commented on pull request #1947:
URL: https://github.com/apache/apisix/pull/1947#issuecomment-693204403
@UnderTreeTech any update?
This is an automated message from the Apache Git Service.
To respond to the message,
tokers commented on pull request #2233:
URL: https://github.com/apache/apisix/pull/2233#issuecomment-693204656
@membphis Fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log
moonming commented on issue #2149:
URL: https://github.com/apache/apisix/issues/2149#issuecomment-693203897
fixed by https://github.com/apache/apisix/pull/2192
This is an automated message from the Apache Git Service.
To
moonming closed issue #2149:
URL: https://github.com/apache/apisix/issues/2149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming commented on issue #2234:
URL: https://github.com/apache/apisix/issues/2234#issuecomment-693209618
good catch, welcome PR to fix
This is an automated message from the Apache Git Service.
To respond to the message,
tokers commented on pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#issuecomment-693221215
@moonming Rebased.
This is an automated message from the Apache Git Service.
To respond to the message, please
moonming commented on pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#issuecomment-693203064
@tokers please rebase master for this PR, thx
This is an automated message from the Apache Git Service.
To
moonming commented on a change in pull request #2120:
URL: https://github.com/apache/apisix/pull/2120#discussion_r489208626
##
File path: t/plugin/key-auth.t
##
@@ -215,3 +215,56 @@ apikey: auth-13
["passed\n", "hello world\n"]
--- no_error_log
[error]
+
+
+
+=== TEST 9:
Firstsawyou opened a new pull request #2236:
URL: https://github.com/apache/apisix/pull/2236
### What this PR does / why we need it:
"consumer" provides access to a collection of "service".
### Pre-submission checklist:
* [x] Did you explain what problem does this PR
tokers commented on pull request #2216:
URL: https://github.com/apache/apisix/pull/2216#issuecomment-693306223
@membphis Adjusted.
This is an automated message from the Apache Git Service.
To respond to the message, please
bzp2010 commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693308666
@Caelebs Please check API response by `Chrome Developer Tools (F12)`.
Normally, the response is similar to this.
`
{
"data": {
"token": "A JWT
Caelebs commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693316930
不好意思我英文不好还是中文描述吧
我这边尝试过注释掉服务端apisix配置文件config.yaml文件中admin_key这一段，这一段注释掉之后前台登录时候user/login接口直接报404，还有这个admin_key配置中的key值我应该怎样生成？
juzhiyuan commented on issue #469:
URL:
https://github.com/apache/apisix-dashboard/issues/469#issuecomment-693269716
take a look at those requests sent from Swagger UI?
This is an automated message from the Apache Git
moonming merged pull request #2231:
URL: https://github.com/apache/apisix/pull/2231
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 455e7df change: remove dashboard sub module.
moonming merged pull request #2233:
URL: https://github.com/apache/apisix/pull/2233
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new e93cdbd change: check etcd cluster version
moonming commented on issue #2234:
URL: https://github.com/apache/apisix/issues/2234#issuecomment-693298121
fixed by https://github.com/apache/apisix/pull/2233
This is an automated message from the Apache Git Service.
To
moonming closed issue #2234:
URL: https://github.com/apache/apisix/issues/2234
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis commented on issue #469:
URL:
https://github.com/apache/apisix-dashboard/issues/469#issuecomment-693268651
That is a useful feature. We can use a specified header for testing. Any
suggestion?
This is an automated
Caelebs commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693271087
我用admin/admin登录后端apisix内部的NGINX日志有报错
```
2020/09/16 16:52:09 [warn] 38#38: *559800 [lua] ctx.lua:82: __index():
failed to fetch cookie value by key: cookie_x_api_key
Caelebs edited a comment on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693271087
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Caelebs edited a comment on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693271087
我用admin/admin登录后端apisix内部的NGINX日志有报错
```
2020/09/16 16:52:09 [warn] 38#38: *559800 [lua] ctx.lua:82: __index():
failed to fetch cookie value by key:
membphis closed issue #2238:
URL: https://github.com/apache/apisix/issues/2238
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 9d1a210 chore: bump `lua-resty-etcd` to
membphis commented on pull request #2242:
URL: https://github.com/apache/apisix/pull/2242#issuecomment-693875655
@Yiyiyimu merged, many thx
This is an automated message from the Apache Git Service.
To respond to the message,
membphis merged pull request #2242:
URL: https://github.com/apache/apisix/pull/2242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bzp2010 commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693335842
@Caelebs
It seems that the Manager API is not using the latest version. Can you try
to update it?
Explanation: in the previous update, the login API was adjusted from
bzp2010 edited a comment on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693335842
@Caelebs
It seems that the Manager API is not using the latest version. Can you try
to update it?
Explanation: in the previous update, the login API was
codjust commented on issue #2151:
URL: https://github.com/apache/apisix/issues/2151#issuecomment-693349312
May be we can use
[nginx-opentracing](https://github.com/opentracing-contrib/nginx-opentracing/blob/master/example/lua/jaeger/nginx.conf)
? a nginx dynamic-module, What do you
bzp2010 edited a comment on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-693335842
@Caelebs
It seems that the Manager API is not using the latest version. Can you try
to update it?
Explanation: in the previous update, the login API was
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489450650
##
File path: t/admin/routes.t
##
@@ -2180,3 +2180,65 @@ GET /t
--- error_code: 400
--- no_error_log
[error]
+
+
+
+=== TEST 60: set empty service.
membphis commented on issue #469:
URL:
https://github.com/apache/apisix-dashboard/issues/469#issuecomment-693426115
After researching, the test request does not require any specific request
headers.
On the dashboard, it directly simulates the user's request. Very good
function,
Yiyiyimu commented on pull request #1943:
URL: https://github.com/apache/apisix/pull/1943#issuecomment-693425041
Close since #2036 is merged
This is an automated message from the Apache Git Service.
To respond to the
Yiyiyimu closed pull request #1943:
URL: https://github.com/apache/apisix/pull/1943
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r489460767
##
File path: bin/apisix
##
@@ -879,35 +887,35 @@ local function init_etcd(show_output)
local host_count = #(yaml_conf.etcd.host)
--- check
juzhiyuan commented on issue #434:
URL:
https://github.com/apache/apisix-dashboard/issues/434#issuecomment-693483449
- [ ] Refactor APIs about Route, Upstream, etc. Both backend and frontend.
- [ ] Uniform the Error Codes both on backend and frontend.
juzhiyuan edited a comment on issue #434:
URL:
https://github.com/apache/apisix-dashboard/issues/434#issuecomment-693483449
TODO according to today's meeting.
- [ ] Refactor APIs about Route, Upstream, etc. Both backend and frontend.
- [ ] Update the Error Codes both on the
Yiyiyimu commented on pull request #2233:
URL: https://github.com/apache/apisix/pull/2233#issuecomment-693424234
@tokers Thank you for the fix!
This is an automated message from the Apache Git Service.
To respond to the
membphis opened a new issue #2238:
URL: https://github.com/apache/apisix/issues/2238
https://luarocks.org/modules/membphis/lua-resty-etcd/1.2-0
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489500949
##
File path: t/admin/routes.t
##
@@ -1557,8 +1557,7 @@ location /t {
ngx.say("code: ", code)
ngx.say(body)
--- etcd v3 would
membphis opened a new issue #2240:
URL: https://github.com/apache/apisix/issues/2240
Calls the ISO C function exit to terminate the CLI program.
for example:
https://github.com/apache/apisix/blob/master/bin/apisix#L77
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693426643
> we could optimize it in another pr
@nic-chen I think we need to release a newer version of lua-resty-etcd,
since the current version would output TONS of logs.
Firstsawyou commented on pull request #2236:
URL: https://github.com/apache/apisix/pull/2236#issuecomment-693486412
> What this PR does? Can you show some examples?
This `pr` was created incorrectly, I will recreate one and explain the
reason.
Firstsawyou commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489452597
##
File path: t/admin/routes.t
##
@@ -2180,3 +2180,65 @@ GET /t
--- error_code: 400
--- no_error_log
[error]
+
+
+
+=== TEST 60: set empty service.
membphis opened a new issue #2237:
URL: https://github.com/apache/apisix/issues/2237
```
# Failed test 'TEST 13: verify: invalid signature - response_body -
response is expected (repeated req 0, req 0)'
# at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489481394
##
File path: t/admin/routes.t
##
@@ -1611,7 +1610,7 @@ location /t {
end
ngx.say("[push] succ: ", body)
-ngx.sleep(2.5)
+
moonming commented on pull request #2236:
URL: https://github.com/apache/apisix/pull/2236#issuecomment-693453228
What this PR does? Can you show some examples?
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on issue #471:
URL:
https://github.com/apache/apisix-dashboard/issues/471#issuecomment-693482289
> Allow users to directly fill in the upstream address, we can support this
feature later.
Just to make sure, does this mean users could fill in the Upstream Form
membphis commented on pull request #2230:
URL: https://github.com/apache/apisix/pull/2230#issuecomment-693481591
> I don't think so, `YOUR_OWN_API_TOKEN` is good as hint, not the real token.
> we can keep the current token
you are right.
the current way, if the APISIX
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489451763
##
File path: t/admin/routes.t
##
@@ -2180,3 +2180,65 @@ GET /t
--- error_code: 400
--- no_error_log
[error]
+
+
+
+=== TEST 60: set empty service.
membphis commented on a change in pull request #2209:
URL: https://github.com/apache/apisix/pull/2209#discussion_r489452341
##
File path: t/admin/routes.t
##
@@ -2180,3 +2180,65 @@ GET /t
--- error_code: 400
--- no_error_log
[error]
+
+
+
+=== TEST 60: set empty service.
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693429050
@Yiyiyimu you can create a new Github issue if you find some other things.
this PR has been merged, we should use the new issue to resolve the problem.
membphis commented on issue #2238:
URL: https://github.com/apache/apisix/issues/2238#issuecomment-693438111
@Yiyiyimu would you like to fix this issue?
This is an automated message from the Apache Git Service.
To respond to
Firstsawyou commented on pull request #2236:
URL: https://github.com/apache/apisix/pull/2236#issuecomment-693487383
This `pr` was created incorrectly.
This is an automated message from the Apache Git Service.
To respond to
Firstsawyou closed pull request #2236:
URL: https://github.com/apache/apisix/pull/2236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
GBXing commented on issue #2175:
URL: https://github.com/apache/apisix/issues/2175#issuecomment-693355770
@moonming Setting max_retry_count to 2 still generates an exception log,
and the log is sent three times
This is an
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693536211
TODO: we need to add doc for etcd migration
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477#issuecomment-693564981
ping @LiteSun
This is an automated message from the Apache Git Service.
To respond to the message,
liuxiran commented on a change in pull request #477:
URL: https://github.com/apache/apisix-dashboard/pull/477#discussion_r489585799
##
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##
@@ -47,7 +47,6 @@ const RequestConfigView: React.FC = ({ data, disabled,
Firstsawyou opened a new pull request #2241:
URL: https://github.com/apache/apisix/pull/2241
### What this PR does / why we need it:
The `consumer` provides access to the `service` collection . Put it in the
"consumer-restriction" plug-in to achieve, by adding the "schema" field
Yiyiyimu commented on issue #2238:
URL: https://github.com/apache/apisix/issues/2238#issuecomment-693732896
Sure thx!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r489899670
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -20,6 +20,10 @@ local core = require("apisix.core")
local schema = {
type =
nic-chen commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r489911418
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -52,16 +58,19 @@ local schema = {
clock_skew = {
type = "integer",
spacewander commented on issue #2215:
URL: https://github.com/apache/apisix/issues/2215#issuecomment-693797594
> [radixtree_router] is used after check at line 147
Look like it is a false positive.
This is an
Yiyiyimu opened a new pull request #2242:
URL: https://github.com/apache/apisix/pull/2242
### What this PR does / why we need it:
update lua-resty-etcd version to remove the unnecessary log in etcd v3
### Pre-submission checklist:
* [x] Did you explain what problem does
LiteSun opened a new pull request #479:
URL: https://github.com/apache/apisix-dashboard/pull/479
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related
tokers commented on pull request #2179:
URL: https://github.com/apache/apisix/pull/2179#issuecomment-693767787
> do we need to add some new test cases?
Will supply some test cases.
This is an automated message from
Firstsawyou commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r489903558
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -20,6 +20,10 @@ local core = require("apisix.core")
local schema = {
type =
moonming commented on pull request #2230:
URL: https://github.com/apache/apisix/pull/2230#issuecomment-693734871
In this pr, we only need to modify one file, and only need to make one
change, which is to print a warning when the Admin IP is not 127.0.0.1 and
using default token
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 68b1f9c bugfix: clear all cached object when
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 5b24ece fix: host should not be
juzhiyuan merged pull request #479:
URL: https://github.com/apache/apisix-dashboard/pull/479
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r489949071
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -29,11 +34,12 @@ local schema = {
type = "array",
items = {type =
dotSlashLu commented on pull request #:
URL: https://github.com/apache/apisix/pull/#issuecomment-693730801
@ShiningRush thanks for your guide. You are right about why the error
message was missed before, such a short waiting time will cover all kinds of
error messages including
moonming merged pull request #2168:
URL: https://github.com/apache/apisix/pull/2168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 110 matches
Mail list logo
