dabue opened a new issue #2457:
URL: https://github.com/apache/apisix/issues/2457
### Issue description
Line 240:
curl -i -X GET http://127.0.0.1:9080/samplePrefix/get?param1=foo=bar
-H 'apikey: superSecretAPIKey'
should be replaced with
curl -i -X GET
membphis commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711147574
thx for your explain
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on issue #2457:
URL: https://github.com/apache/apisix/issues/2457#issuecomment-711147817
can you provide the original doc link?
This is an automated message from the Apache Git Service.
To respond to the
dabue commented on issue #2457:
URL: https://github.com/apache/apisix/issues/2457#issuecomment-711152963
https://github.com/apache/apisix/blob/master/doc/getting-started.md#add-a-prefix-to-the-route
Line 240
and the example which in
Miss-you commented on pull request #2454:
URL: https://github.com/apache/apisix/pull/2454#issuecomment-711133448
I have fix the problem in the image attributor-over-time.png.
Jaycean commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711140040
> > Do you mean that the current function can directly remove this field?
>
> You haven't added this field yet? I do not find it in the changed files:
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711140040
> > Do you mean that the current function can directly remove this field?
>
> You haven't added this field yet? I do not find it in the changed files:
spacewander commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-711143671
My suggestion is to put `metadata`/`consumer` into the arguments, if the
argument is missing, choice the default plain `schema`.
tokers edited a comment on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-711486895
Rebased the newest master branch and reviewed the historical changes for the
old `bin/apisix` file after the birth of this branch and applied them, also
code was tweaked
imjoey commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r507458347
##
File path: t/plugin/request-validation.t
##
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
membphis commented on pull request #2408:
URL: https://github.com/apache/apisix/pull/2408#issuecomment-711605284
@sober-wang many thx, merged already
This is an automated message from the Apache Git Service.
To respond to
membphis commented on pull request #2397:
URL: https://github.com/apache/apisix/pull/2397#issuecomment-711603835
@dabue many thx
This is an automated message from the Apache Git Service.
To respond to the message, please log
liuxiran commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711265925
> My current PR does not modify the logic of this disable field. I intend to
submit a new PR for modification
>
> After all, the logic related to the disable field has
Jaycean commented on pull request #2415:
URL: https://github.com/apache/apisix/pull/2415#issuecomment-711484039
@spacewander PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please
tokers commented on a change in pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#discussion_r507395837
##
File path: bin/apisix
##
@@ -798,333 +41,30 @@ version:print the version of apisix
end
-local checked_admin_key = false
-local function init()
fukiki commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r507405839
##
File path: t/plugin/request-validation.t
##
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
membphis commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711607503
@gy09535 would like to submit a PR to fix this bug?
we can use a different key, then we can fix this issue.
spacewander opened a new pull request #2461:
URL: https://github.com/apache/apisix/pull/2461
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
dabue commented on issue #2410:
URL: https://github.com/apache/apisix/issues/2410#issuecomment-711489292
@membphis the plugin will impact all request when it be set, is that ok?
and it needs to be initialized during http_init.
membphis commented on pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#issuecomment-711573927
CI failed, please take a look at the output:
https://github.com/apache/apisix/pull/2395/checks?check_run_id=1272985327#step:9:43
imjoey commented on issue #2452:
URL: https://github.com/apache/apisix/issues/2452#issuecomment-711603899
+1 for me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
moonming closed issue #2170:
URL: https://github.com/apache/apisix/issues/2170
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming merged pull request #2397:
URL: https://github.com/apache/apisix/pull/2397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 943be09 feature(core): implement `core.sleep`
moonming commented on issue #2412:
URL: https://github.com/apache/apisix/issues/2412#issuecomment-711463434
@nic-chen got it.
please add the close reason not just close issue.
This is an automated message from the Apache
nic-chen commented on issue #2412:
URL: https://github.com/apache/apisix/issues/2412#issuecomment-711460510
@moonming
It doesn't need a PR for this issue. just upload a darwin version release
for `grpc_server_example`:
LY-GO commented on issue #2450:
URL: https://github.com/apache/apisix/issues/2450#issuecomment-711460517
> > i hope that the plugin only limit concurrency,and different users also
continue to request the router when user request the service after first .
>
> What is the difference
spacewander commented on a change in pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#discussion_r507376609
##
File path: bin/apisix
##
@@ -798,333 +41,30 @@ version:print the version of apisix
end
-local checked_admin_key = false
-local function
juzhiyuan merged pull request #561:
URL: https://github.com/apache/apisix-dashboard/pull/561
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
membphis commented on issue #2450:
URL: https://github.com/apache/apisix/issues/2450#issuecomment-711466145
I think you should provide a complete case, we need to know more detailed
step information.
Mainly two questions:
1. What is the route data?
2. What is your test
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/refactor by this push:
new 0bbcc75 feat: compatible with
membphis closed issue #2402:
URL: https://github.com/apache/apisix/issues/2402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 5fcbb4d plugin(consumer-restriction): use
membphis merged pull request #2440:
URL: https://github.com/apache/apisix/pull/2440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander opened a new pull request #2460:
URL: https://github.com/apache/apisix/pull/2460
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
tokers commented on a change in pull request #2395:
URL: https://github.com/apache/apisix/pull/2395#discussion_r507372495
##
File path: apisix/cmd/etcd.lua
##
@@ -0,0 +1,196 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license
tzssangglass commented on pull request #2443:
URL: https://github.com/apache/apisix/pull/2443#issuecomment-711271130
> @tzssangglass I think your new code is wrong. please check it first.
>
>
https://github.com/apache/apisix/pull/2443/checks?check_run_id=1266120426#step:6:373
tzssangglass commented on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-711287916
Under the condition of setting `uris` or `hosts`, I want to record the
specific elements in the `uris` or `hosts` that match the current request.
At first I tried to take
membphis commented on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-711447339
you can take a look at this, it can help you:
https://github.com/api7/lua-resty-radixtree#synopsis
```lua
-- try to match
local opts = {
membphis commented on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-711447595
here is more cases:
https://github.com/api7/lua-resty-radixtree/search?q=matched
This is an automated message from
membphis edited a comment on issue #1574:
URL: https://github.com/apache/apisix/issues/1574#issuecomment-711447595
here are more cases:
https://github.com/api7/lua-resty-radixtree/search?q=matched
This is an automated
nic-chen commented on issue #2412:
URL: https://github.com/apache/apisix/issues/2412#issuecomment-711465843
> @nic-chen got it.
> please add the close reason not just close issue.
OK, thanks for tips.
This is
spacewander merged pull request #2408:
URL: https://github.com/apache/apisix/pull/2408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 1fe4e50 chore: show help message if the
LY-GO commented on issue #2450:
URL: https://github.com/apache/apisix/issues/2450#issuecomment-711471376
> I think you should provide a complete case, we need to know more detailed
step information.
>
> Mainly two questions:
>
> 1. What is the route data?
> 2. What is your
gy09535 commented on pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#issuecomment-711474875
> @gy09535 I think we need to way to confirm this plugin can work fine with
aliyun. if we can check this in the test, it should be great.
Thanks I will try it.
qiujiayu commented on issue #2369:
URL: https://github.com/apache/apisix/issues/2369#issuecomment-711209534
Adding `up_version` is a good solution.
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on pull request #2456:
URL: https://github.com/apache/apisix/pull/2456#issuecomment-711221022
> Why remove Luacov?
the result is unstable, and it causes the test case to time out and fails.
and we have no way to view the result now.
I think we can
membphis commented on pull request #2454:
URL: https://github.com/apache/apisix/pull/2454#issuecomment-711222127
It can only be updated manually now
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on a change in pull request #2458:
URL: https://github.com/apache/apisix/pull/2458#discussion_r507176656
##
File path: doc/getting-started.md
##
@@ -237,7 +237,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H
'X-API-KEY: edd1c9f034335f13
Now you
membphis commented on issue #2457:
URL: https://github.com/apache/apisix/issues/2457#issuecomment-711162776
nice, welcome PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dabue opened a new pull request #2458:
URL: https://github.com/apache/apisix/pull/2458
### What this PR does / why we need it:
fix #2457
### Pre-submission checklist:
https://github.com/apache/apisix/blob/master/doc/getting-started.md#add-a-prefix-to-the-route
Line 240
spacewander opened a new pull request #2459:
URL: https://github.com/apache/apisix/pull/2459
Close #2288.
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been
moonming commented on issue #2412:
URL: https://github.com/apache/apisix/issues/2412#issuecomment-711174217
> fixed
Where is the fix PR? @nic-chen
This is an automated message from the Apache Git Service.
To respond
moonming commented on pull request #2454:
URL: https://github.com/apache/apisix/pull/2454#issuecomment-711173809
How to update this?
This is an automated message from the Apache Git Service.
To respond to the message, please
55 matches
Mail list logo
