[GitHub] [apisix] spacewander merged pull request #2462: fix: we didn't traverse the plugin interceptors correctly

spacewander merged pull request #2462: URL: https://github.com/apache/apisix/pull/2462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (71dcf36 -> 5906c73)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 71dcf36 change: read 8bytes from /dev/urandom as the random seed for better randomness (#2437) add

[GitHub] [apisix] membphis commented on a change in pull request #2454: doc: Contributor Over Time

membphis commented on a change in pull request #2454: URL: https://github.com/apache/apisix/pull/2454#discussion_r507547512 ## File path: README.md ## @@ -288,6 +288,10 @@ A wide variety of companies and organizations use APISIX for research, productio Users are encouraged

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

juzhiyuan commented on pull request #521: URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-711815099 cc @moonming @liuxiran This PR is going to merge into the master branch, and it depends on the api refactor branch, so it means the master branch is unstable after

[GitHub] [apisix] spacewander merged pull request #2461: doc(echo): mark it as production-unready

spacewander merged pull request #2461: URL: https://github.com/apache/apisix/pull/2461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] membphis merged pull request #2451: Plugin(request-validation): use draft7 way to rewrite the JSON Schema

membphis merged pull request #2451: URL: https://github.com/apache/apisix/pull/2451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (71dcf36 -> 5906c73)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 71dcf36 change: read 8bytes from /dev/urandom as the random seed for better randomness (#2437) add

[apisix] branch master updated (26ad5cf -> cb04193)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 26ad5cf doc(echo): mark it as production-unready (#2461) add cb04193 bugfix: modify json schema definition

[apisix] branch master updated (5906c73 -> 26ad5cf)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 5906c73 fix: we didn't traverse the plugin interceptors correctly (#2462) add 26ad5cf doc(echo): mark

[GitHub] [apisix] membphis closed issue #2432: bug: incorrect json schema definition for plugin request-validation

membphis closed issue #2432: URL: https://github.com/apache/apisix/issues/2432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] gy09535 edited a comment on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change

gy09535 edited a comment on issue #2425: URL: https://github.com/apache/apisix/issues/2425#issuecomment-711827483 > @gy09535 would like to submit a PR to fix this bug? > > we can use a different key, then we can fix this issue. yeah, please assign to me, I will fix it.

[GitHub] [apisix] gy09535 commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change

gy09535 commented on issue #2425: URL: https://github.com/apache/apisix/issues/2425#issuecomment-711827483 > @gy09535 would like to submit a PR to fix this bug? > > we can use a different key, then we can fix this issue. yeah, I will fix it.

[GitHub] [apisix] spacewander opened a new pull request #2462: fix: we didn't traverse the plugin interceptors correctly

spacewander opened a new pull request #2462: URL: https://github.com/apache/apisix/pull/2462 This bug is introduced in 6a543a9. ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what

[GitHub] [apisix] membphis commented on pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

membphis commented on pull request #2415: URL: https://github.com/apache/apisix/pull/2415#issuecomment-711655137 we need to print the value of the `limit key`, and check it in error log. This is an automated message from the

[GitHub] [apisix] membphis commented on a change in pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

membphis commented on a change in pull request #2415: URL: https://github.com/apache/apisix/pull/2415#discussion_r507502110 ## File path: t/plugin/limit-conn.t ## @@ -956,3 +956,216 @@ GET /test_concurrency 200 --- no_error_log [error] + + + +=== TEST 25: create consumer

[GitHub] [apisix] tzssangglass commented on issue #1574: feature: prometheus plugin `apisix_http_status` metric `route` tag Improve recognition

tzssangglass commented on issue #1574: URL: https://github.com/apache/apisix/issues/1574#issuecomment-711780364 I saw the example above, init `match_opts.matched` is probably the right way to think about it, as https://github.com/api7/lua-resty-radixtree#synopsis, I did. ```

[GitHub] [apisix] juzhiyuan commented on pull request #2177: feature: support plugin for aliyun log service

juzhiyuan commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-711778784 Hi, it seems that this PR is still under development, I will convert this one to Draft, feel free to make it ready when needed.

[GitHub] [apisix] membphis commented on pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

membphis commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-711793684 @LY-GO you can make a try with this PR This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] lizeming opened a new issue #2468: request help:

lizeming opened a new issue #2468: URL: https://github.com/apache/apisix/issues/2468 ### Issue description Hello, we are APISIX users. Currently using APISIX unified Internet proxy service. We have a requirement that we need to use the same Internet IP address and different ports

[GitHub] [apisix] Miss-you commented on pull request #2454: doc: Contributor Over Time

Miss-you commented on pull request #2454: URL: https://github.com/apache/apisix/pull/2454#issuecomment-711665025 > How to update this? You expect to be able to automatically update contributor trend charts on a daily or monthly, right?

[GitHub] [apisix] membphis commented on issue #2450: bug: limit-conn

membphis commented on issue #2450: URL: https://github.com/apache/apisix/issues/2450#issuecomment-711725275 let me confirm it This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] moonming commented on pull request #2454: doc: Contributor Over Time

moonming commented on pull request #2454: URL: https://github.com/apache/apisix/pull/2454#issuecomment-711753835 > > How to update this? > > You expect to be able to automatically update contributor trend charts on a daily or monthly, right? yes, monthly will be enough

[GitHub] [apisix] yanshanlangren opened a new issue #2464: request help: How to define a self-develop plugin?

yanshanlangren opened a new issue #2464: URL: https://github.com/apache/apisix/issues/2464 ### Issue description I developed a sample LUA plugin. Put the .lua file under directory of `/usr/local/apisix/apisix/plugins` Add plug-in name under `plugins` in

[GitHub] [apisix] moonming commented on a change in pull request #2460: doc: we can also use reload after configuration changed

moonming commented on a change in pull request #2460: URL: https://github.com/apache/apisix/pull/2460#discussion_r507550594 ## File path: FAQ_CN.md ## @@ -203,7 +203,7 @@ Server: APISIX web server 1、修改conf/config.yaml中的nginx log配置参数`error_log_level:

[apisix] branch master updated (26ad5cf -> cb04193)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 26ad5cf doc(echo): mark it as production-unready (#2461) add cb04193 bugfix: modify json schema definition

[GitHub] [apisix] membphis commented on issue #2464: request help: How to define a self-develop plugin?

membphis commented on issue #2464: URL: https://github.com/apache/apisix/issues/2464#issuecomment-711801630 here is the doc link: https://github.com/apache/apisix/blob/master/doc/plugin-develop.md hope this can help you.

[GitHub] [apisix] imjoey opened a new pull request #2469: feat(prometheus): Add consumer metric data support

imjoey opened a new pull request #2469: URL: https://github.com/apache/apisix/pull/2469 Signed-off-by: imjoey ### What this PR does / why we need it: Fixes #2445 . This PR is going to add `consumer` label for metric items. Based on this, we could trigger/send

[GitHub] [apisix] membphis opened a new pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

membphis opened a new pull request #2465: URL: https://github.com/apache/apisix/pull/2465 ### What this PR does / why we need it: fix #2450 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] powermanlc opened a new issue #2466: apisix frequent http code 502

powermanlc opened a new issue #2466: URL: https://github.com/apache/apisix/issues/2466 ### Issue description only access go service appear http 502 error.log : upstream prematurely closed connection while reading response header from upstream， recv() failed (104: Connection

[apisix] branch master updated (5906c73 -> 26ad5cf)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 5906c73 fix: we didn't traverse the plugin interceptors correctly (#2462) add 26ad5cf doc(echo): mark

[GitHub] [apisix] membphis commented on pull request #2463: add reopen args

membphis commented on pull request #2463: URL: https://github.com/apache/apisix/pull/2463#issuecomment-711798148 missing those 

[apisix] branch master updated (71dcf36 -> 5906c73)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 71dcf36 change: read 8bytes from /dev/urandom as the random seed for better randomness (#2437) add

[GitHub] [apisix] membphis commented on issue #2466: apisix frequent http code 502

membphis commented on issue #2466: URL: https://github.com/apache/apisix/issues/2466#issuecomment-711819854 you upstream node is unstable, you need to fix this first This is an automated message from the Apache Git Service.

[GitHub] [apisix] powermanlc commented on issue #2466: apisix frequent http code 502

powermanlc commented on issue #2466: URL: https://github.com/apache/apisix/issues/2466#issuecomment-711822679 > you upstream node is unstable, you need to fix this first how can i to do This is an automated message

[GitHub] [apisix] idbeta opened a new issue #2467: strengthen: The ulimit setting should be checked when APISIX starts，if user limits too small(like 1024),APISIX should prompt to modify, otherwise the

idbeta opened a new issue #2467: URL: https://github.com/apache/apisix/issues/2467 ### Issue description The ulimit setting should be checked when APISIX starts，if user limits too small(like 1024), APISIX should prompt to modify, otherwise, the performance is low ### Environment

[GitHub] [apisix] membphis commented on a change in pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

membphis commented on a change in pull request #2415: URL: https://github.com/apache/apisix/pull/2415#discussion_r507501479 ## File path: t/plugin/limit-conn.t ## @@ -956,3 +956,216 @@ GET /test_concurrency 200 --- no_error_log [error] + + + +=== TEST 25: create consumer

[GitHub] [apisix] Miss-you edited a comment on pull request #2454: doc: Contributor Over Time

Miss-you edited a comment on pull request #2454: URL: https://github.com/apache/apisix/pull/2454#issuecomment-711667211 > It can only be updated manually now Yes, but if needed, I could add a regular update feature, something like startchart.

[GitHub] [apisix] Miss-you commented on pull request #2454: doc: Contributor Over Time

Miss-you commented on pull request #2454: URL: https://github.com/apache/apisix/pull/2454#issuecomment-711667211 > It can only be updated manually now > It can only be updated manually now Yes, but if needed, I could add a regular update feature, something like

[apisix] branch master updated: change: read 8bytes from /dev/urandom as the random seed for better randomness (#2437)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 71dcf36 change: read 8bytes from

[GitHub] [apisix] spacewander merged pull request #2437: change: read 8bytes from /dev/urandom as the random seed for better randomness

spacewander merged pull request #2437: URL: https://github.com/apache/apisix/pull/2437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] membphis commented on issue #2450: bug: limit-conn

membphis commented on issue #2450: URL: https://github.com/apache/apisix/issues/2450#issuecomment-711763455 that is a bug, fix it soon This is an automated message from the Apache Git Service. To respond to the message,

[apisix] branch master updated (71dcf36 -> 5906c73)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 71dcf36 change: read 8bytes from /dev/urandom as the random seed for better randomness (#2437) add

[apisix] branch master updated (5906c73 -> 26ad5cf)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 5906c73 fix: we didn't traverse the plugin interceptors correctly (#2462) add 26ad5cf doc(echo): mark

[GitHub] [apisix-dashboard] moonming commented on pull request #521: feat: Refactor Frondend with Admin API

moonming commented on pull request #521: URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-711837581 got it Thanks, Ming Wen Twitter: _WenMing 琚致远 于2020年10月19日周一 下午4:15写道： > cc @moonming @liuxiran >

[GitHub] [apisix] Jaycean commented on pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

Jaycean commented on pull request #2415: URL: https://github.com/apache/apisix/pull/2415#issuecomment-711883326 > we need to print the value of the `limit key`, and check it in error log. I'm sorry that I didn't understand what you meant. I added the test error value of the key and

[GitHub] [apisix] membphis commented on pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

membphis commented on pull request #2415: URL: https://github.com/apache/apisix/pull/2415#issuecomment-711896804 @Jaycean https://github.com/apache/apisix/blob/d63f3e068c0d54ab7b2b3acec8e5f4914da0a4b7/apisix/plugins/limit-conn.lua#L71 we can print the `ctx.var[conf.key]` to

[GitHub] [apisix] membphis commented on issue #2466: apisix frequent http code 502

membphis commented on issue #2466: URL: https://github.com/apache/apisix/issues/2466#issuecomment-711900690 I can not reply to you the answer, you have to fix this question by yourself. we only can help if the APISIX has issues.

[GitHub] [apisix] fukiki commented on issue #2426: bug：enable openid-connect plugin without redirect_uri got 500 error

fukiki commented on issue #2426: URL: https://github.com/apache/apisix/issues/2426#issuecomment-712056117 @nic-chen If `redirect_uri` is not provided in schema, it will be set by `ngx.var.request_uri`, please see

[GitHub] [apisix] imjoey commented on pull request #2469: feat(prometheus): Add consumer metric data support

imjoey commented on pull request #2469: URL: https://github.com/apache/apisix/pull/2469#issuecomment-712104842 ping @membphis @nic-chen @liuxiran for reviewing. Many thanks. This is an automated message from the Apache Git

[GitHub] [apisix] LY-GO commented on pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

LY-GO commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-712118157 > @LY-GO you can make a try with this PR two question: 1.now i have a requirement.iI need to add a key that it belonds to config of limit-conn-plugin .I just modify the

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2283: release: release 2.0 version.

juzhiyuan commented on a change in pull request #2283: URL: https://github.com/apache/apisix/pull/2283#discussion_r507713111 ## File path: CHANGELOG.md ## @@ -32,6 +32,31 @@ - [0.7.0](#070) - [0.6.0](#060) +## 2.0.0 + +### Core +- :sunrise: **Migrate from etcd v2 to v3

[GitHub] [apisix] powermanlc commented on issue #2466: apisix frequent http code 502

powermanlc commented on issue #2466: URL: https://github.com/apache/apisix/issues/2466#issuecomment-711959823 > I can not reply to you the answer, you have to fix this question by yourself. > > we only can help if the APISIX has issues. ok thanks

[GitHub] [apisix] spacewander commented on a change in pull request #2460: doc: we can also use reload after configuration changed

spacewander commented on a change in pull request #2460: URL: https://github.com/apache/apisix/pull/2460#discussion_r507630701 ## File path: FAQ_CN.md ## @@ -203,7 +203,7 @@ Server: APISIX web server 1、修改conf/config.yaml中的nginx log配置参数`error_log_level:

[GitHub] [apisix] LY-GO edited a comment on pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

LY-GO edited a comment on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-712118157 > @LY-GO you can make a try with this PR two question: 1.now i have a requirement.iI need to add a key that it belonds to config of limit-conn-plugin .I just modify

[GitHub] [apisix] LY-GO edited a comment on pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

LY-GO edited a comment on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-712118157 > @LY-GO you can make a try with this PR two question: 1.now i have a requirement.iI need to add a key that it belonds to config of limit-conn-plugin .I just modify

[GitHub] [apisix] Jaycean commented on pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

Jaycean commented on pull request #2415: URL: https://github.com/apache/apisix/pull/2415#issuecomment-711972389 > @Jaycean > > https://github.com/apache/apisix/blob/d63f3e068c0d54ab7b2b3acec8e5f4914da0a4b7/apisix/plugins/limit-conn.lua#L71 > > we can print the

[GitHub] [apisix] Jaycean commented on a change in pull request #2415: feat:The limit-conn plugin supports 'consumer_name' field

Jaycean commented on a change in pull request #2415: URL: https://github.com/apache/apisix/pull/2415#discussion_r507652172 ## File path: t/plugin/limit-conn.t ## @@ -956,3 +956,216 @@ GET /test_concurrency 200 --- no_error_log [error] + + + +=== TEST 25: create consumer and

[GitHub] [apisix] liuxiran commented on a change in pull request #2469: feat(prometheus): Add consumer metric data support

liuxiran commented on a change in pull request #2469: URL: https://github.com/apache/apisix/pull/2469#discussion_r507701220 ## File path: apisix/plugins/prometheus/exporter.lua ## @@ -95,23 +95,23 @@ function _M.init() "Etcd modify index for APISIX keys",

[GitHub] [apisix] moonming merged pull request #2460: doc: we can also use reload after configuration changed

moonming merged pull request #2460: URL: https://github.com/apache/apisix/pull/2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] imjoey commented on issue #1866: request help: all $ENV{TEST_NGINX_USE_HUP} hang up in test file

imjoey commented on issue #1866: URL: https://github.com/apache/apisix/issues/1866#issuecomment-712113195 @Yiyiyimu +1 for the same issue. For convenience, I put the issue you posted to test-nginx repo: https://github.com/openresty/test-nginx/issues/104 here. @membphis Here are my

[GitHub] [apisix] membphis commented on issue #2369: bug: Unable to get the latest upstream node list by service discovery

membphis commented on issue #2369: URL: https://github.com/apache/apisix/issues/2369#issuecomment-711888356 > I used the string formed by the service ip list as up_version. `json`? `sync from eureka` -> `lua table` <- `server-picker` When data is synchronized, first

[apisix] branch master updated (cb04193 -> 26e55a3)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from cb04193 bugfix: modify json schema definition for plugin request-validation (#2451) add 26e55a3 doc: we can

[GitHub] [apisix] LY-GO commented on pull request #2465: bugfix(limit-conn): always necessary to save the data of the limit concurrency, and release the statistical status in the log phase.

LY-GO commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-712119756 > > @LY-GO you can make a try with this PR > 2.i modify the code of limit-conn according to your repair.But the response code is 500

[GitHub] [apisix] spacewander closed issue #2436: chore: change the random string length from `4` to `8`

spacewander closed issue #2436: URL: https://github.com/apache/apisix/issues/2436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #2436: chore: change the random string length from `4` to `8`

spacewander commented on issue #2436: URL: https://github.com/apache/apisix/issues/2436#issuecomment-712128528 Solved This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] gxthrj commented on issue #2452: discuss: How apisix records the request data sent to the upstream service

gxthrj commented on issue #2452: URL: https://github.com/apache/apisix/issues/2452#issuecomment-712213300 How about logging requests in the phase `log` through the plug-in? This is an automated message from the Apache Git

[GitHub] [apisix] gxthrj commented on issue #2453: discuss: apisix supports obtaining etcd data information through plugin

gxthrj commented on issue #2453: URL: https://github.com/apache/apisix/issues/2453#issuecomment-712207418 Most of the time, we don't know the route ID，It will be a good tool to quickly determine the route of concern. There are two scenarios I want. 1. Find route based on URI; 2.

[GitHub] [apisix] tzssangglass edited a comment on issue #1574: feature: prometheus plugin `apisix_http_status` metric `route` tag Improve recognition

tzssangglass edited a comment on issue #1574: URL: https://github.com/apache/apisix/issues/1574#issuecomment-711780364 I saw the example above, init `match_opts.matched` is probably the right way to think about it, as https://github.com/api7/lua-resty-radixtree#synopsis, I did. ```

[GitHub] [apisix] gxthrj opened a new issue #2470: [discuss]: Distribute traffic in percentage between similar routes

gxthrj opened a new issue #2470: URL: https://github.com/apache/apisix/issues/2470 There is such a demand, how do you think it can be solved? Description of Requirement: Distribute traffic in percentage between similar routes such as: route1 GET http://foo.com/hello

[GitHub] [apisix] Firstsawyou commented on issue #2452: discuss: How apisix records the request data sent to the upstream service

Firstsawyou commented on issue #2452: URL: https://github.com/apache/apisix/issues/2452#issuecomment-712255847 I think we can use the `serverless` plugin to execute some `lua` logic codes at the specified stage to try to achieve it.

[GitHub] [apisix] juzhiyuan closed issue #2464: request help: How to define a self-develop plugin?

juzhiyuan closed issue #2464: URL: https://github.com/apache/apisix/issues/2464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] juzhiyuan commented on issue #2464: request help: How to define a self-develop plugin?

juzhiyuan commented on issue #2464: URL: https://github.com/apache/apisix/issues/2464#issuecomment-712168282 I will close this issue now, please follow the link above. Feel free to reopen this one. This is an automated

[GitHub] [apisix] tzssangglass commented on issue #1574: feature: prometheus plugin `apisix_http_status` metric `route` tag Improve recognition

tzssangglass commented on issue #1574: URL: https://github.com/apache/apisix/issues/1574#issuecomment-712312448 In `radixtree`# `_match_from_routes` function, may be judgement if it's a prefix matching before calling the `compare_param` function, and if so, simply return. like

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #501: PluginModule: check every plugin's schema & form usability

juzhiyuan commented on issue #501: URL: https://github.com/apache/apisix-dashboard/issues/501#issuecomment-712547459 related issue https://github.com/apache/apisix/issues/2082 This is an automated message from the Apache

[GitHub] [apisix-dashboard] juzhiyuan closed issue #402: 1.5版本的kafka-log组件无法输入broker_list

juzhiyuan closed issue #402: URL: https://github.com/apache/apisix-dashboard/issues/402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan closed issue #501: PluginModule: check every plugin's schema & form usability

juzhiyuan closed issue #501: URL: https://github.com/apache/apisix-dashboard/issues/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #562: The 1.5 version of the dashboard cannot be edited again to display the previous settings

juzhiyuan commented on issue #562: URL: https://github.com/apache/apisix-dashboard/issues/562#issuecomment-712549202 Check this issue after the master branch gets updated. This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

ShiningRush commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508170091 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{})

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

ShiningRush commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508170091 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{})

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

ShiningRush commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508170091 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{})

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

ShiningRush commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508170091 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{})

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

juzhiyuan commented on pull request #521: URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712554862 There would have a lot conflict changes, once the refactor branch is merged into master, we will handle those conflicts

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #521: feat: Refactor Frondend with Admin API

juzhiyuan edited a comment on pull request #521: URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712554862 There would have a lot of conflict changes, once the refactor branch is merged into master, we will handle those conflicts

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

liuxiran commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508181051 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[apisix-dashboard] branch refactor updated: feat: compatible with HTTP status of `admin api` (#563)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/refactor by this push: new 2088156 feat: compatible with

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #563: feat: compatible with HTTP status of `admin api`

juzhiyuan merged pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #563: feat: compatible with HTTP status of `admin api`

juzhiyuan commented on pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#issuecomment-712559691 Let's merge it now This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] gy09535 opened a new issue #2471: question: some confuse with client auth

gy09535 opened a new issue #2471: URL: https://github.com/apache/apisix/issues/2471 ### Issue description Such as key-auth (https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/key-auth.md), why we add key auth plugin in route other then add consumer in route? I have not

[GitHub] [apisix] haifeng9414 commented on issue #2369: bug: Unable to get the latest upstream node list by service discovery

haifeng9414 commented on issue #2369: URL: https://github.com/apache/apisix/issues/2369#issuecomment-712569046 Both the configuration and the ip address of the upstream should affect the cache of healthchecker and server-picker. If use table as the cache version, how to know the

[GitHub] [apisix] juzhiyuan commented on issue #2470: [discuss]: Distribute traffic in percentage between similar routes

juzhiyuan commented on issue #2470: URL: https://github.com/apache/apisix/issues/2470#issuecomment-712524911 A/B Test? This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] moonming merged pull request #2403: doc: fixed minor format issue in architecture-design.md.

moonming merged pull request #2403: URL: https://github.com/apache/apisix/pull/2403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #563: feat: compatible with HTTP status of `admin api`

liuxiran commented on a change in pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#discussion_r508158329 ## File path: api/internal/core/store/validate.go ## @@ -125,17 +125,17 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[GitHub] [apisix-dashboard] membphis commented on pull request #563: feat: compatible with HTTP status of `admin api`

membphis commented on pull request #563: URL: https://github.com/apache/apisix-dashboard/pull/563#issuecomment-712540623 > No test cases https://github.com/apache/apisix-dashboard/pull/563/commits/580b88e10edd82d4c02e3d583ce56aff4123f1d1 @moonming you missed them

[GitHub] [apisix] imjoey commented on issue #2441: plugin(hmac-auth): update the schema

imjoey commented on issue #2441: URL: https://github.com/apache/apisix/issues/2441#issuecomment-712514522 > My suggestion is to put `metadata`/`consumer` into the arguments, if the argument is missing, choice the default plain `schema`. +1 . IMHO, query parameters would be more

[GitHub] [apisix] moonming commented on pull request #2283: release: release 2.0-rc version.

moonming commented on pull request #2283: URL: https://github.com/apache/apisix/pull/2283#issuecomment-712519492 @juzhiyuan fixed, please take a look This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] juzhiyuan commented on issue #2470: [discuss]: Distribute traffic in percentage between similar routes

juzhiyuan commented on issue #2470: URL: https://github.com/apache/apisix/issues/2470#issuecomment-712525323 more like Gray release This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] moonming commented on a change in pull request #2454: doc: Contributor Over Time

moonming commented on a change in pull request #2454: URL: https://github.com/apache/apisix/pull/2454#discussion_r508151613 ## File path: README.md ## @@ -288,6 +288,10 @@ A wide variety of companies and organizations use APISIX for research, productio Users are encouraged

[GitHub] [apisix] moonming commented on pull request #2368: add uri fuzzing test

moonming commented on pull request #2368: URL: https://github.com/apache/apisix/pull/2368#issuecomment-712529828 @idbeta any update? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] moonming commented on a change in pull request #2455: feat: new plugin, api breaker

moonming commented on a change in pull request #2455: URL: https://github.com/apache/apisix/pull/2455#discussion_r508153943 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,248 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[apisix] branch master updated (26e55a3 -> df6d1e9)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 26e55a3 doc: we can also use reload after configuration changed (#2460) add df6d1e9 doc: fixed minor

  1   2   >