[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366242791
##
File path: src/lang/zh.ts
##
@@ -83,5 +83,12 @@ export default {
inputMultipleValues: '输入值后并回车',
propertyHostsTip: '任何值均可'
}
+ },
+ upstream: {
+websocket: {
+ EnabledTips: 'WebSocket 打开',
+ DisabledTips: 'WebSocket 关闭'
+},
+keyTips: '你可以编辑并输入任何值,输入值后 回车确认。'
Review comment:
任何值，输
输入值后回车确认。
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366249597
##
File path: src/views/schema/upstream/edit.vue
##
@@ -348,6 +410,13 @@ export default class extends Vue {
.el-input {
width: 193px;
}
+ .tip {
+ line-height: 24px;
+ font-size: 12px;
+ margin: 0;
+ color: #8e8c8c;
+ display:inline;
Review comment:
space
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366242275
##
File path: src/lang/en.ts
##
@@ -75,5 +75,12 @@ export default {
inputMultipleValues: 'Input value then press return button',
propertyHostsTip: 'Any values are supported'
}
+ },
+ upstream: {
+websocket: {
+ EnabledTips: 'WebSocket enabled',
Review comment:
Please use tip instead of tips
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366243618 ## File path: src/views/schema/upstream/edit.vue ## @@ -53,6 +53,26 @@ + +
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366244458
##
File path: src/views/schema/upstream/edit.vue
##
@@ -73,6 +93,23 @@
:value="item.value"
/>
+
+ {{ $t('upstream.keyTips') }}
+
+
+
+
+
+
+ {{
form.enable_websocket?$t('upstream.websocket.EnabledTips'):$t('upstream.websocket.DisabledTips')
}}
Review comment:
space
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366249521
##
File path: src/views/schema/upstream/edit.vue
##
@@ -348,6 +410,13 @@ export default class extends Vue {
.el-input {
width: 193px;
}
+ .tip {
+ line-height: 24px;
Review comment:
2 spaces
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
juzhiyuan commented on a change in pull request #118: Upstream support
websocket enable and hashOn select
URL:
https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366244230
##
File path: src/views/schema/upstream/edit.vue
##
@@ -73,6 +93,23 @@
:value="item.value"
/>
+
+ {{ $t('upstream.keyTips') }}
+
+
+
+
+
