[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-22 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632527748


   Because we will separate every module, so we will use something like 
`SSLModule` namespace in ts.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-22 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632527266


   Please handle the conflict files, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632521410


   Because the current request is sent from Browser to API server directly, so 
just removed the `api` prefix I think.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632520919


   > > 
![image](https://user-images.githubusercontent.com/2106987/82638941-55382300-9c3a-11ea-84f0-4a031e948f87.png)
   > > still not woking.
   > 
   > What should it be like?🤔
   
   should be `https://apisix.iresty.com/apisix/admin/ssl` ...
   
   `api` prefix is used for Nginx or Netlify to reforward the request to real 
API server.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632519713


   > > I still think this way is not good ... We could do some changes on the 
proxy to meet our needs, though we have to keep duplicate settings 🤔
   > 
   > Using forwarding leads to complexity in various deployment environments 
(self compiling, docker, nginx or other web server), and the cost of direct 
request in browser is low.
   > At the same time, when deploying in the Intranet environment, we should 
consider how to forward and authenticate on the Admin API, and should not 
modify the dashboard to meet the special needs.
   
   The way this PR using is not clear for new developers and users :(



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632518804


   https://deploy-preview-208--apisix-dashboard.netlify.app/dashboard/settings



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632518634


   
![image](https://user-images.githubusercontent.com/2106987/82638941-55382300-9c3a-11ea-84f0-4a031e948f87.png)
   
   still not woking.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #208: feature: change request prefix

2020-05-21 Thread GitBox


juzhiyuan commented on pull request #208:
URL: 
https://github.com/apache/incubator-apisix-dashboard/pull/208#issuecomment-632446046


   I still think this way is not good ... We could do some changes on the proxy 
to meet our needs, though we have to keep duplicate settings 🤔



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org