Re: [PR] feat: add global copyable IDs and stabilize e2e flows [apisix-dashboard]

2026-03-20 Thread via GitHub


Baluduvamsi2006 commented on PR #3340:
URL: 
https://github.com/apache/apisix-dashboard/pull/3340#issuecomment-4098254363

   @Baoyuantop , could you please review this PR when you have time?
   
   I also included e2e stability fixes in this PR. Without these fixes, 
path-resolution issues and flaky UI interactions in the e2e helpers made it 
difficult to identify true pass/fail results. I fixed those issues in the same 
PR so the test output is now reliable and actionable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] feat: add global copyable IDs and stabilize e2e flows [apisix-dashboard]

2026-03-20 Thread via GitHub


Baluduvamsi2006 opened a new pull request, #3340:
URL: https://github.com/apache/apisix-dashboard/pull/3340

   
   https://github.com/user-attachments/assets/8e1689fa-a775-44b6-b4d3-64f2f514baca";
 />
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   This PR introduces global one-click copy-to-clipboard support for key 
resource identifiers and includes related e2e reliability fixes.
   
   1. Added a shared copyable text component and reused it across target list 
pages and plugin card display.
   2. Enabled copy UX for IDs/usernames in multiple resource list views to 
provide consistent behavior.
   3. Added i18n entries for copy tooltip/success text in English, Chinese, 
Spanish, German, and Turkish.
   4. Normalized copied values with string conversion where needed to avoid 
non-string edge cases.
   5. Fixed Windows e2e path handling by switching file URL path resolution to 
a cross-platform-safe approach.
   6. Stabilized e2e upstream TLS Verify interaction by toggling through a 
visible, reliable control path.
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, 
please discuss on the mailing list first
   
   Notes:
   - Existing e2e coverage was used and related e2e helper/spec behavior was 
updated for stability.
   - No backward-incompatible API or contract changes are introduced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]