Re: [PR] fix: adc backend server on different mode [apisix-ingress-controller]
bzp2010 commented on PR #2455: URL: https://github.com/apache/apisix-ingress-controller/pull/2455#issuecomment-3060243554 @dspo @AlinsRan @nic-6443 @ronething When submitting future PRs, make sure to populate the “What this PR does / why we need it” and the “Pre-submission checklist”, otherwise the purpose of this PR can only be guessed by code. Almost no one fully understands the program. On top of that, as a committor with write access to APISIX, we must first follow the rules we have set for ourselves. Of course, the pre-defined templates in the PR templates are part of that. Such arrogance in ignoring the community and a lack of transparency is unacceptable. --- I got to this page from https://github.com/apache/apisix-helm-chart/issues/847#issuecomment-3060156141, and I am completely unable to understand what the error was, and why this fix will work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: adc backend server on different mode [apisix-ingress-controller]
ronething merged PR #2455: URL: https://github.com/apache/apisix-ingress-controller/pull/2455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] fix: adc backend server on different mode [apisix-ingress-controller]
dspo opened a new pull request, #2455: URL: https://github.com/apache/apisix-ingress-controller/pull/2455 ### Type of change: - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [ ] Documentation - [ ] Refactor - [ ] Chore - [ ] CI/CD or Tests ### What this PR does / why we need it: ### Pre-submission checklist: - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
