Re: [PR] fix: `get_keys` only return first 1024 items in shared dict by default [apisix]

2025-06-25 Thread via GitHub


Baoyuantop commented on PR #12380:
URL: https://github.com/apache/apisix/pull/12380#issuecomment-3006868118

   I found a similar call 
https://github.com/apache/apisix/blob/master/apisix/init.lua#L907, do we need 
to handle it here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] fix: get_keys only return first 1024 items in shared dict by default [apisix]

2025-06-25 Thread via GitHub


nic-6443 opened a new pull request, #12380:
URL: https://github.com/apache/apisix/pull/12380

   ### Description
   
   From OpenResty Doc:
   > By default, only the first 1024 keys (if any) are returned. When the 
 argument is given the value 0, then all the keys will be returned 
even there is more than 1024 keys in the dictionary.
   
   We should return complete data in the `/v1/discovery/{service}/dump` control 
API, otherwise, it will confuse users.
   
    Which issue(s) this PR fixes:
   
   Fixes #
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]