Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3609/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Michael Blow has submitted this change and it was merged.
Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns
..
[ASTERIXDB-2024][TEST] Test fwk comment patterns
Update the test framework to match comment patterns only at head of
line, to avoid truncating other instances of these characters i.e.
http://foobar.com -> http:
Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1919
Reviewed-by: Michael Blow
Integration-Tests: Michael Blow
Tested-by: Michael Blow
---
M
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Blow: Looks good to me, approved; Verified; Verified
diff --git
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index 1079832..1c29e86 100644
---
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -105,8 +105,8 @@
private static final long MAX_URL_LENGTH = 2000l;
private static final Pattern JAVA_BLOCK_COMMENT_PATTERN =
Pattern.compile("/\\*.*\\*/",
Pattern.MULTILINE | Pattern.DOTALL);
-private static final Pattern JAVA_LINE_COMMENT_PATTERN =
Pattern.compile("//.*$", Pattern.MULTILINE);
-private static final Pattern SHELL_LINE_COMMENT_PATTERN =
Pattern.compile("#.*$", Pattern.MULTILINE);
+private static final Pattern JAVA_LINE_COMMENT_PATTERN =
Pattern.compile("^//.*$", Pattern.MULTILINE);
+private static final Pattern SHELL_LINE_COMMENT_PATTERN =
Pattern.compile("^#.*$", Pattern.MULTILINE);
private static final Pattern REGEX_LINES_PATTERN =
Pattern.compile("^(-)?/(.*)/([im]*)$");
private static final Pattern POLL_TIMEOUT_PATTERN =
Pattern.compile("polltimeoutsecs=(\\d+)(\\D|$)",
Pattern.MULTILINE);
--
To view, visit https://asterix-gerrit.ics.uci.edu/1919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1588/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Code-Review+2 Integration-Tests+1 Verified+1 Carrying forward clean votes; self +2'ing on updated commit message. -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1210/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/523/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3609/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/345/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1144/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/531/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/865/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1919 to look at the new patch set (#2). Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. [ASTERIXDB-2024][TEST] Test fwk comment patterns Update the test framework to match comment patterns only at head of line, to avoid truncating other instances of these characters i.e. http://foobar.com -> http: Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 --- M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1919/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1431/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/526/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6088/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4607/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2024][TEST] Test fwk comment patterns
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2024][TEST] Test fwk comment patterns .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1258/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/1919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c317ccee242bd5fa2f5ec5bed85a69f0a47cf11 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
