subject:"Change in asterixdb\[master\]\: \[ASTERIXDB\-2170\]\[SQL\] Fix resolution order of implicit field..."

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10: -Contrib

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2322/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2322/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-15 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/mCB6RS : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2317/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2317/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1142/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4948/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2572/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4948/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2789/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2584/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7474/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2551/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1138/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/31/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1922/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2253/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5974/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1954/
 (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1938/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4932/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2773/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2557/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2570/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4932/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1933/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2235/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1116/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/9/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5956/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7456/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1919/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2533/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 9:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1904/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-13 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/GNySmp : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2300/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2300/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4915/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2754/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4915/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2216/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-13 Thread Dmitry Lychagin (Code Review)

Hello Anon. E. Moose #1000171, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2207

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..

[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Improved name resolution rules
- Resolve field access to the nearest variable in scope
  instead of raising compile-time error
- Do not rely on type information when resolving names
- Cleanup group variable handling in GroupBy clause,
  no longer use ‘with’ map for it
- Fix ByNameToByIndexFieldAccessRule to use type environment
  of its input operator when analyzing its expression
- Fix ExternalGroupByPOperator to use input schema of its
  aggregate function when generating runtime for that function
- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggregateIntoNestedSubplanRule.java
D 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/denorm-cust-order.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orderby-desc-using-gby.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orders-aggreg.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/q01_pricing_summary_report_nt.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/query-issue562.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/split-materialization-above-join.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-10.plan
M

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2538/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1097/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1914/
 (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2553/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5937/ (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1900/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2753/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2514/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1885/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7437/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-12 Thread Steven Jacobs (Code Review)

Steven Jacobs has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Can we make sure and +2 the BAD side as well?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4909/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-12 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2548/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2533/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2748/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4909/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-12 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field
access
..

Patch Set 7:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/count-tweets.sqlpp
File
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/count-tweets.sqlpp:

PS6, Line 42:
> Do we need "t" here?
You're right. It's not necessary. Will fix

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/fj-dblp-csx.ast
File
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/fj-dblp-csx.ast:

PS6, Line 95:
> Huh?
will fix

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias2.sqlpp
File
asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias2.sqlpp:

PS6, Line 20: sum
> This is confusing, what did this query do before?
I'm puzzled too. This query belongs to the SmokeParserTest which only parses
queries and runs first chunk of the AST rewrite rules. Previously it'd run
rules until (including) first invocation of VariableCheckAndRewriteVisitor.
First invocation of that visitor would introduce resolve() function and ignore
anything that could not be unresolved at that point. With my new change this
rule fails if an identifier cannot be resolved, so the query had to be modified.

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/resolution/groupby_rename_with_sugar/groupby_rename_with_sugar.1.ddl.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/resolution/groupby_rename_with_sugar/groupby_rename_with_sugar.1.ddl.sqlpp:

PS6, Line 24: UNION ALL
> What happened to the union_negative_2 queries?
it is no longer failing so I renamed it to union_order_by_5.
https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/union/union_order_by_5/union_orderby_5.3.query.sqlpp

It used to fail because it would not find field 't' in the output schema of the
union. However now the union is handled through the sugar rewrite:
a union b union c order by x -> from ( a union b union c ) select ... order by
x.
So 'x' is resolved as a field access on the single variable iterating over the
union.

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q13_customer_distribution/q13_customer_distribution.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q13_customer_distribution/q13_customer_distribution.3.query.sqlpp:

PS6, Line 27: COL
> The support for sugars in different places seems to have changed. Do the su
Sugars work in both places. I'll revert this fragment (lined 27-30) back to
COLL_SUM. Line 44 no longer works though. It should either be 'count(gco)' or
'coll_count((select value gco from g))'. I'll change it to 'count(gco)' to
preserve SQL-92 aggregate function as it was before

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue562/query-issue562.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue562/query-issue562.3.query.sqlpp:

PS6, Line 37:
:
:
:
:
:
> Why did this go?
it's a dead code. nobody uses this variable. I can bring this back though. So
the query would remain the same as before.

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/union/union_order_by_5/union_orderby_5.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/union/union_order_by_5/union_orderby_5.3.query.sqlpp:

PS6, Line 30: t.id, id
> What do these resolve to?
field access on the result of the union. (union sugar rewrite).
so it'd be:
from ( from ... union ... union ...) as $1 select $1.t.id order by $1.t.id,
$1.id

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

PS6, Line 2790: function field-access-by-name
> Unrelated to this change, but I think that "field-access-by-name" is nothin
Agree. Although it'd require some thought. The problem is that this error is
thrown by the function type check code which is generic for all functions.

https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java
File

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-12 Thread Dmitry Lychagin (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2207

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..

[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Improved name resolution rules
- Resolve field access to the nearest variable in scope
  instead of raising compile-time error
- Do not rely on type information when resolving names
- Cleanup group variable handling in GroupBy clause,
  no longer use ‘with’ map for it
- Fix ByNameToByIndexFieldAccessRule to use type environment
  of its input operator when analyzing its expression
- Fix ExternalGroupByPOperator to use input schema of its
  aggregate function when generating runtime for that function
- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggregateIntoNestedSubplanRule.java
D 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/denorm-cust-order.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orderby-desc-using-gby.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orders-aggreg.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/q01_pricing_summary_report_nt.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/query-issue562.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/split-materialization-above-join.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-10.plan
M

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2508/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1895/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1880/ 
(8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1092/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5932/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2211/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7432/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1909/
 (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2287/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-11 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2207/6//COMMIT_MSG
Commit Message:

PS6, Line 15: nearest variable in scope
Could we add a description of "the scope" to the issue?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/count-tweets.sqlpp
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/count-tweets.sqlpp:

PS6, Line 42: t as t, 
Do we need "t" here?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/fj-dblp-csx.ast
File 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/fj-dblp-csx.ast:

PS6, Line 95:  
Huh?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias2.sqlpp
File 
asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias2.sqlpp:

PS6, Line 20: sum
This is confusing, what did this query do before?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/resolution/groupby_rename_with_sugar/groupby_rename_with_sugar.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/resolution/groupby_rename_with_sugar/groupby_rename_with_sugar.1.ddl.sqlpp:

PS6, Line 24: UNION ALL
What happened to the union_negative_2 queries?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q13_customer_distribution/q13_customer_distribution.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-with-index/q13_customer_distribution/q13_customer_distribution.3.query.sqlpp:

PS6, Line 27: SUM
The support for sugars in different places seems to have changed. Do the sugars 
work in both places or is this the only option now?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue562/query-issue562.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue562/query-issue562.3.query.sqlpp:

PS6, Line 37: 
: 
: 
: 
: 
: 
Why did this go?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/union/union_order_by_5/union_orderby_5.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/union/union_order_by_5/union_orderby_5.3.query.sqlpp:

PS6, Line 30: t.id, id
What do these resolve to?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

PS6, Line 2790: function field-access-by-name
Unrelated to this change, but I think that "field-access-by-name" is nothing a 
user would write, so we might want to adjust the error message (maybe we can 
file an issue for this).


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/InsertStatement.java:

Line 119: return null;
> MAJOR SonarQube violation:
Sounds like a good suggestion. Is that feasible in this context?


https://asterix-gerrit.ics.uci.edu/#/c/2207/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java
File 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppAstPrintVisitor.java:

PS6, Line 269: }
 : else
formatting


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-11 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/BSzQfB : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1893/
 (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1076/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1864/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2532/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2289/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-11 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/o722rw : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4892/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2289/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1862/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2193/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7414/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2490/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/1074/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2726/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2515/
 (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1879/ 
(9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7416/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5916/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2207
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...

2017-12-11 Thread Dmitry Lychagin (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2207

to look at the new patch set (#6).

Change subject: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field 
access
..

[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Improved name resolution rules
- Resolve field access to the nearest variable in scope
  instead of raising compile-time error
- Do not rely on type information when resolving names
- Cleanup group variable handling in GroupBy clause,
  no longer use ‘with’ map for it
- Fix ByNameToByIndexFieldAccessRule to use type environment
  of its input operator when analyzing its expression
- Fix ExternalGroupByPOperator to use input schema of its
  aggregate function when generating runtime for that function
- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggregateIntoNestedSubplanRule.java
D 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/count-tweets.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/denorm-cust-order.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orderby-desc-using-gby.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/orders-aggreg.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/q01_pricing_summary_report_nt.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/query-issue562.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/split-materialization-above-join.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_1.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/hints/broadcast_hint_3.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-equi-join-non-enforced/btree-equi-join-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-04.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-05.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-06.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-07.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-08.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-09.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/open-index-non-enforced/btree-index-non-enforced/btree-index-non-enforced-10.plan
M

Change in asterixdb[master]: [ASTERIXDB-2170][SQL] Fix resolution order of implicit field...