Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool - user model changes: no - storage format changes: no - interface changes: no - Restore thread names to their original names before returning them to the pool of the NC app. - Remove explicit thread name resets. - Delete unused ThreadExecutor class. Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2447 Sonar-Qube: Jenkins Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ThreadExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java 10 files changed, 66 insertions(+), 69 deletions(-) Approvals: Anon. E. Moose #1000171: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java index dacd0ee..2de8319 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java @@ -59,19 +59,12 @@ public Callable recover() { if (retryPolicyFactory == NoRetryPolicyFactory.INSTANCE) { -return () -> { -return null; -}; +return () -> null; } IRetryPolicy policy = retryPolicyFactory.create(listener); return () -> { -String nameBefore = Thread.currentThread().getName(); -try { -Thread.currentThread().setName("RecoveryTask (" + listener.getEntityId() + ")"); -doRecover(policy); -} finally { -Thread.currentThread().setName(nameBefore); -} +Thread.currentThread().setName("RecoveryTask (" + listener.getEntityId() + ")"); +doRecover(policy); return null; }; } diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java index c724952..288e5f2 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java @@ -28,7 +28,6 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; import java.util.stream.Collectors; import org.apache.asterix.active.ActiveManager; @@ -102,6 +101,7 @@ import org.apache.hyracks.storage.common.file.FileMapManager; import org.apache.hyracks.storage.common.file.ILocalResourceRepositoryFactory; import org.apache.hyracks.storage.common.file.IResourceIdFactory; +import org.apache.hyracks.util.MaintainedThreadNameExecutorService; import org.apache.logging.log4j.Level; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -171,7 +171,8 @@ @Override public void initialize(boolean initialRun) throws IOException, ACIDException { ioManager = getServiceContext().getIoManager(); -threadExecutor = Executors.newCachedThreadPool(getServiceContext().getThreadFactory()); +threadExecutor = + MaintainedThreadNameExecutorService.newCachedThreadPool(getServiceContext().getThreadFactory()); ICacheMemoryAllocator allocator = new HeapBufferAllocator(); IPageCleanerPolicy pcp = new DelayPageCleanerPo
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5842/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2831/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5842/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2831/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5841/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3411/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3387/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/DcnB7J : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3659/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5841/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/ES6N4R : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2931/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3463/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2843/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3149/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2918/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2892/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8389/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/939/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6882/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2447 to look at the new patch set (#3). Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool - user model changes: no - storage format changes: no - interface changes: no - Restore thread names to their original names before returning them to the pool of the NC app. - Remove explicit thread name resets. - Delete unused ThreadExecutor class. Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ThreadExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java 10 files changed, 66 insertions(+), 69 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/2447/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5834/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Zebcee : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3404/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3380/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3652/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2924/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5834/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/QwGVrW : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/932/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8382/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2836/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6875/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3142/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2885/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3456/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2910/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2447 to look at the new patch set (#2). Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool - user model changes: no - storage format changes: no - interface changes: no - Restore thread names to their original names before returning them to the pool of the NC app. - Remove explicit thread name resets. - Delete unused ThreadExecutor class. Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/RecoveryTask.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java D asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ThreadExecutor.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/MaterializingPipelinedPartition.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java 10 files changed, 65 insertions(+), 67 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/2447/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2819/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2819/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/NWzaw6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3642/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5825/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3395/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3371/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/jdQEhH : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3641/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5825/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2914/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/7KQZQJ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2826/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3446/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6865/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2900/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8372/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3132/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2875/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/922/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2447 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2447 Change subject: [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool .. [ASTERIXDB-2229][OTR] Restore Thread Names in Thread Pool - user model changes: no - storage format changes: no - interface changes: no - Restore thread names to their original names before returning them to the pool of the NC app. Change-Id: I3bda1b65e7aefd35d2b8cfa814f73369c3bf5a18 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java 2 files changed, 58 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/2447/1 diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java index c724952..288e5f2 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java @@ -28,7 +28,6 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; import java.util.stream.Collectors; import org.apache.asterix.active.ActiveManager; @@ -102,6 +101,7 @@ import org.apache.hyracks.storage.common.file.FileMapManager; import org.apache.hyracks.storage.common.file.ILocalResourceRepositoryFactory; import org.apache.hyracks.storage.common.file.IResourceIdFactory; +import org.apache.hyracks.util.MaintainedThreadNameExecutorService; import org.apache.logging.log4j.Level; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -171,7 +171,8 @@ @Override public void initialize(boolean initialRun) throws IOException, ACIDException { ioManager = getServiceContext().getIoManager(); -threadExecutor = Executors.newCachedThreadPool(getServiceContext().getThreadFactory()); +threadExecutor = + MaintainedThreadNameExecutorService.newCachedThreadPool(getServiceContext().getThreadFactory()); ICacheMemoryAllocator allocator = new HeapBufferAllocator(); IPageCleanerPolicy pcp = new DelayPageCleanerPolicy(60); IPageReplacementStrategy prs = new ClockPageReplacementStrategy(allocator, diff --git a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java new file mode 100644 index 000..e141758 --- /dev/null +++ b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/MaintainedThreadNameExecutorService.java @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.hyracks.util; + +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.SynchronousQueue; +import java.util.concurrent.ThreadFactory; +import java.util.concurrent.ThreadPoolExecutor; +import java.util.concurrent.TimeUnit; + +public class MaintainedThreadNameExecutorService extends ThreadPoolExecutor { + +private final Map threadNames = new HashMap<>(); + +private MaintainedThreadNameExecutorService(ThreadFactory threadFactory) { +super(0, Integer.MAX_VALUE, 60L, TimeUnit.SECONDS, new SynchronousQueue<>(), threadFactory); +} + +public static ExecutorService newCachedThreadPool(ThreadFactory threadFactory) { +return new MaintainedThreadNameExecutorService(threadFactory); +} + +@Override +protected void beforeExecute(Thread t, Runnable r) { +threadNames.put(t, t.getName()); +super.beforeExecute(t, r); +} + +@Override +protected void afterExecute(Runnable r, Throwable t) { +final String thre