subject:"Change in asterixdb\[master\]\: \[ASTERIXDB\-2476\]\[FUN\] Support array slicing in SQL\+\+"

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-27 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has submitted this change and it was merged.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


[ASTERIXDB-2476][FUN] Support array slicing in SQL++

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Added array_slice function. 2 functions were added, one that
accepts 2 arguments and the other accepts 3 arguments. The
arguments are (list, start, end) respectively.
- Added array_slice function test cases.
- Array slice syntax and documentation will be added in subsequent
changes.

Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3031
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Contrib: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.adm
A

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-27 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-27 Thread Hussain Towaileb (Code Review)

Hussain Towaileb has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp:

Line 27:   "t5": (array_slice([0, 1, 2, 3], 0, missing) IS MISSING),  // end is 
missing
> Do we have have testcases where MISSING is passed as a first or second argu
Done.
Added few more test cases for the 2 arguments version.


https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp:

Line 36:   "t14": (array_slice([0, 1, 2, 3], 0, "3") IS NULL),   // Invalid end
> Do we have have testcases where NULL is passed as a first or second argumen
Done.
Added few more test cases for the 2 arguments version.


https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java:

Line 204: 
> We try to avoid object construction inside evaluate(). You only need at mos
Done.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3816/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7602/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3816/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/TcQ5dy : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/200/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8723/ (2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4996/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Analytics Compatibility Compilation Successful
https://goo.gl/f71Gxy : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7602/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/201/
 (12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4777/
 (9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Hussain Towaileb (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3031

to look at the new patch set (#13).

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..

[ASTERIXDB-2476][FUN] Support array slicing in SQL++

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Added array_slice function. 2 functions were added, one that
accepts 2 arguments and the other accepts 3 arguments. The
arguments are (list, start, end) respectively.
- Added array_slice function test cases.
- Array slice syntax and documentation will be added in subsequent
changes.

Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_exception_result/array_slice_exception_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative_argument/array_slice_negative_argument.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.4.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_double_argument/array_slice_double_argument.3.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/array_fun/array_slice/array_slice_int_argument/array_slice_int_argument.3.adm
A

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5161/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2785/ 
(11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4686/ 
(1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10256/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4741/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5345/ (3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5115/
 (10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4775/ 
(5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-26 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..

Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_result/array_slice_missing_result.3.query.sqlpp:

Line 27: };
Do we have have testcases where MISSING is passed as a first or second argument
to the 2 argument version of array_slice()? If not then let's add those.

https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp
File
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null_result/array_slice_null_result.3.query.sqlpp:

Line 36: };
Do we have have testcases where NULL is passed as a first or second argument to
the 2 argument version of array_slice()? If not then let's add those.

https://asterix-gerrit.ics.uci.edu/#/c/3031/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
File
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java:

Line 204: IAsterixListBuilder listBuilder =
We try to avoid object construction inside evaluate(). You only need at most
two listbuilder instances: OrderedListBuilder and UnorderedListBuilder. These
instances should be reused on each evaluate() call. Take a look at how
AbstractArrayProcessEval maintains those.

--
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Hussain Towaileb
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Till Westmann
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-21 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 12: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/CHPGBh : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic609676cc068e92c6342fb0fa4c9074ec4bd98bf
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2476][FUN] Support array slicing in SQL++

2018-11-21 Thread Hussain Towaileb (Code Review)

Hussain Towaileb has posted comments on this change.

Change subject: [ASTERIXDB-2476][FUN] Support array slicing in SQL++
..


Patch Set 12:

(12 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_1/array_slice_missing_1.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_missing_1/array_slice_missing_1.3.query.sqlpp:

Line 24
> how can we be sure that array_slice returns missing and not null if input a
Done.


Line 25
> is there a testcase where the 2nd argument is missing?
Yes, it's under the array_slice_int_argument test cases.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative/array_slice_negative.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_negative/array_slice_negative.3.query.sqlpp:

Line 23
> I was slightly confused because we usually call tests "_negative" if they'r
Done.
All test cases locations were restructured to be much more meaningful.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null/array_slice_null.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_null/array_slice_null.3.query.sqlpp:

Line 24
> missing and null are both serialized into null in the result JSON. In order
Done.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java:

Line 129: 
> these are positions, so can they be "long" instead of "double"?
Done.

I had it originally as double since we accepted values such as 3.0 for 
convenience (but not 3.1), that logic has been all moved to get the getValue 
method.


Line 175: endPositionValue = listAccessor.size();
> All these Missing/Null argument checks can been eliminated if we switch to 
Done. (This comment is also related to the comment below regarding the casting 
step)

Originally I had it as auto-generated code, however, I had to change it due to 
the use of the Cast class. A loophole can occur when using a Cast class 
together with the auto-generated that ends up producing wrong results. (I'll 
report it later).

However, this behavior has been changed as suggested, function now is 
auto-generated.


Line 222: collectionType = (AbstractCollectionType) inputListType;
> Why do we need to cast here and in case of a multiset below?
Done and fixed.

The ListBuilder class takes an argument for the type, and for type "any", it 
takes a list of type any as an argument "[ any ]", I was using the Cast class 
to generate this result, however, it's been changed to directly use the 
AOrderListType and AUnorderListType classes.


Line 246: // Using double since we accept values like 3.0, but not 3.5
> why 'double' when we're essentially operating on integer values?
Done and fixed. 

This was related to receiving a double value, logic for double is fully moved 
inside the getValue method.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithEndPositionDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithEndPositionDescriptor.java:

Line 52: // the type of the input list is needed in order to use 
the same type for the new returned list
> Let's use FunctionTypeInferets.SET_ARGUMENT_TYPE. We only need a type of th
Done.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithoutEndPositionDescriptor.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithoutEndPositionDescriptor.java:

Line 52: // the type of the input list is needed in order to use 
the same type for the new returned list
> Let's use FunctionTypeInferets.SET_ARGUMENT_TYPE. We only need a type of th
Done.


Line 87: 
> The comment is not correct. There's no end position parameter
Done and fixed.


https://asterix-gerrit.ics.uci.edu/#/c/3031/10/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java:

Line 503: fc.addGenerated(ArraySliceWithEndPositionDescriptor.FACTORY);
> The

1 2 3 >

1 - 100 of 247 matches

Mail list logo