Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Ali Alsuliman : Ali Alsuliman has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator - user model changes: no - storage format changes: no - interface changes: no details: - At the end of the query optimisation if project is parent of unnest in the plan tree, project variables are pushed onto unnest operator. UnnestRuntime is changed so that it can support unnest, positional, input variables in any order. Ext-ref: MB-57625 Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 Integration-Tests: Jenkins Tested-by: Jenkins Reviewed-by: Ali Alsuliman --- M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ch2/ch2_q8.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/with-composite-pk/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-2815-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-3006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/with-3-level-record-path/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q3.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/atomic-and-array-queries/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-4/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-21.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/multiple-indexes/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-3/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/with-3-level-record-path/query1.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Ali Alsuliman : Attention is currently required from: Murtadha Hubail, Peeyush Gupta, preethampolupar...@gmail.com. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 10: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 10 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Peeyush Gupta Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 03 Dec 2024 23:34:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: Ali Alsuliman, preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 10: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1999/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 10 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Ali Alsuliman Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 03 Dec 2024 12:29:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: Ali Alsuliman, preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 10: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1998/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 10 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Ali Alsuliman Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 03 Dec 2024 11:50:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: Ali Alsuliman, preethampolupar...@gmail.com. Hello Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#10). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator - user model changes: no - storage format changes: no - interface changes: no details: - At the end of the query optimisation if project is parent of unnest in the plan tree, project variables are pushed onto unnest operator. UnnestRuntime is changed so that it can support unnest, positional, input variables in any order. Ext-ref: MB-57625 Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ch2/ch2_q8.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/with-composite-pk/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-2815-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-3006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/with-3-level-record-path/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q3.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/atomic-and-array-queries/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-4/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-21.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/multiple-indexes/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-3/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/with-3-level-record-path/query1.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/re
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: Ali Alsuliman. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 9: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1995/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 9 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Tue, 03 Dec 2024 09:03:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From :
Attention is currently required from: Ali Alsuliman.
preethampolupar...@gmail.com has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 )
Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator
..
Patch Set 9:
(5 comments)
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/d372cc4d_6a3b6404
PS8, Line 102: public VariablePropagationPolicy getVariablePropagationPolicy() {
> We can use 'FilteredVariablePropagationPolicy': […]
Done
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/fb6b8e14_7ab3c95e
PS8, Line 1098: "project-variables"
> We can replace this with PROJECT_VARIABLES_FIELD
Done
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/9ada4358_663f6ad0
PS8, Line 49: LogicalOperatorTag.UNNEST
> How about LogicalOperatorTag. […]
Done
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/aa031ca9_1713d548
PS8, Line 90: "unnest " + outCol + " <- " + unnestingFactory;
> Change it to: […]
Done
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/1a3ec071_ae5b09b4
PS8, Line 149: for (int f = 0; f < projectionList.length; f++) {
> We can simplify it: […]
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9
Gerrit-Change-Number: 19100
Gerrit-PatchSet: 9
Gerrit-Owner: preethampolupar...@gmail.com
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Attention: Ali Alsuliman
Gerrit-Comment-Date: Tue, 03 Dec 2024 08:15:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman
Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: Ali Alsuliman. preethampolupar...@gmail.com has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 9: (1 comment) File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/68434892_f5edc23a PS8, Line 75: projectionList.length > Is there a test case where projectionList is empty (because all variables are > projected away)? SqlppExecutionTest 59: temporal: current_date_time_01 has an empty projectionList: unnest $$r <- range(1, 1000) project: [] [cardinality: 0.0, op-cost: 0.0, total-cost: 0.0] -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 9 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Tue, 03 Dec 2024 08:15:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#9). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator - user model changes: no - storage format changes: no - interface changes: no details: - At the end of the query optimisation if project is parent of unnest in the plan tree, project variables are pushed onto unnest operator. UnnestRuntime is changed so that it can support unnest, positional, input variables in any order. Ext-ref: MB-57625 Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ch2/ch2_q8.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/with-composite-pk/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-2815-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-3006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/with-3-level-record-path/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q3.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/atomic-and-array-queries/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-4/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-21.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/multiple-indexes/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-3/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/with-3-level-record-path/query1.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/optimizer
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Ali Alsuliman :
Attention is currently required from: preethampolupar...@gmail.com.
Ali Alsuliman has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 )
Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator
..
Patch Set 8:
(6 comments)
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/2752f55e_317af48c
PS8, Line 102: public VariablePropagationPolicy getVariablePropagationPolicy() {
We can use 'FilteredVariablePropagationPolicy':
if (isProjectPushed()) {
return FilteredVariablePropagationPolicy(getProjectVariables());
}
return new VariablePropagationPolicy() {
...
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/03e974cd_67eeaee1
PS8, Line 1098: "project-variables"
We can replace this with PROJECT_VARIABLES_FIELD
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/1af9afa4_ceb20b0f
PS8, Line 49: LogicalOperatorTag.UNNEST
How about LogicalOperatorTag.LEFT_OUTER_UNNEST?
File
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/af70aa58_a8cb8508
PS8, Line 75: projectionList.length
Is there a test case where projectionList is empty (because all variables are
projected away)?
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/d0e63d85_cf263e0f
PS8, Line 90: "unnest " + outCol + " <- " + unnestingFactory;
Change it to:
"unnest " + outCol + (positionalCol >= 0 ? " at " + positionalCol : "") + " <-
" + unnestingFactory + " project: " + projectionList;
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100/comment/04cc8543_3abec04a
PS8, Line 149: for (int f = 0; f < projectionList.length; f++) {
We can simplify it:
int col = projectionList[f];
if (col == outCol) {
} else if (col == positionalCol) {
} else {
}
outColPos and positionalColIndex can be removed.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9
Gerrit-Change-Number: 19100
Gerrit-PatchSet: 8
Gerrit-Owner: preethampolupar...@gmail.com
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Attention: preethampolupar...@gmail.com
Gerrit-Comment-Date: Tue, 03 Dec 2024 00:35:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1984/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 8 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Mon, 02 Dec 2024 13:31:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#8). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator - user model changes: no - storage format changes: no - interface changes: no details: - At the end of the query optimisation if project is parent of unnest in the plan tree, project variables are pushed onto unnest operator. UnnestRuntime is changed so that it can support unnest, positional, input variables in any order. Ext-ref: MB-57625 Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ch2/ch2_q8.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/with-composite-pk/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-2815-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-3006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/with-3-level-record-path/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q3.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/atomic-and-array-queries/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-4/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-21.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/multiple-indexes/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-3/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/with-3-level-record-path/query1.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/arra
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1980/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 7 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Sun, 01 Dec 2024 21:53:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#7). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ch2/ch2_q8.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/with-composite-pk/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-2815-2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/query-ASTERIXDB-3006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/with-3-level-record-path/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/ch2/ch2_q3.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/atomic-and-array-queries/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/complex-structures/query3.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/atomic-and-array-queries/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-3/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-4/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-21.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/complex-structures/query5.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/multiple-indexes/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/closed/use-case-3/query3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-3/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/array-index/select-unnest-queries/open/with-3-level-record-path/query1.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/closed/use-case-4/query2.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_let_7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-index/select-unnest-queries/open/use-case-1/query1.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/array-ind
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1972/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 6 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Sat, 30 Nov 2024 13:42:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#6). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectIntoDataSourceScanRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/array-access-pushdown/array-access-pushdown.13.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.025.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/array-access-pushdown/array-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.014.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/array-access-pushdown/array-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/005/005.011.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/replicate/replicate.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.014.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/pushdown-plans/pushdown-plans.07.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.105.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.023.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.113.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.032.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/005/005.011.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.062.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.023.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/001/001.019.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/004/004.105.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/004/004.113.plan M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/005/005.008.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results_cbo/column/filter/004/004.102.plan M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.006.plan M asterixdb/asterix-a
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Attention is currently required from: preethampolupar...@gmail.com. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 5: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/XKnEiJCtGXnrMGuq5 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 5 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Thu, 28 Nov 2024 13:25:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1945/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 5 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Thu, 28 Nov 2024 11:07:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Attention is currently required from: preethampolupar...@gmail.com. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 5: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/y7nkbBC1akg1vBv37 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 5 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Thu, 28 Nov 2024 10:08:07 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#4). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectIntoDataSourceScanRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/array-access-pushdown/array-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/005/005.011.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/replicate/replicate.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.014.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.105.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.113.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.032.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.023.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.062.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/replicate/replicate.011.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.025.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/005/005.008.plan 28 files changed, 437 insertions(+), 442 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/19100/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 4 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1916/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 3 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 26 Nov 2024 12:46:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Attention is currently required from: preethampolupar...@gmail.com. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 3: Contrib-2 Analytics Compatibility Compilation Failed https://cbjenkins.page.link/1F8wXpQZytsgrJX18 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 3 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 26 Nov 2024 12:15:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From : Attention is currently required from: preethampolupar...@gmail.com. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 to look at the new patch set (#3). Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. [ASTERIXDB-3531][COMP] Push projections into unnest operator Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 --- M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectIntoDataSourceScanRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.019.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.021.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/array-access-pushdown/array-access-pushdown.008.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/005/005.011.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/replicate/replicate.010.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.102.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/other-pushdowns/other-pushdowns.014.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/utils/LogicalOperatorDotVisitor.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.042.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.105.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.113.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.032.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java M hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.023.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/004/004.006.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/subplan/subplan.062.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/pushdown/replicate/replicate.011.plan M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/001/001.025.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M asterixdb/asterix-app/src/test/resources/runtimets/results/column/filter/005/005.008.plan 28 files changed, 476 insertions(+), 442 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/00/19100/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 3 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1915/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 2 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 26 Nov 2024 11:18:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Attention is currently required from: preethampolupar...@gmail.com. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 2: Contrib-2 Analytics Compatibility Compilation Failed https://cbjenkins.page.link/GEmbv86yNEWFDemx5 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 2 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Tue, 26 Nov 2024 10:46:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Attention is currently required from: preethampolupar...@gmail.com. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/NZLhqi6GeL8mN7GU7 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 1 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Fri, 22 Nov 2024 16:57:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From Jenkins : Attention is currently required from: preethampolupar...@gmail.com. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/1892/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 1 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-Reviewer: Jenkins Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: preethampolupar...@gmail.com Gerrit-Comment-Date: Fri, 22 Nov 2024 13:20:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 ) Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/wKdn7Ewbw1inBW5t8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9 Gerrit-Change-Number: 19100 Gerrit-PatchSet: 1 Gerrit-Owner: preethampolupar...@gmail.com Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins Gerrit-Comment-Date: Fri, 22 Nov 2024 12:30:57 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3531][COMP] Push projections into unnest operator
>From :
preethampolupar...@gmail.com has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19100 )
Change subject: [ASTERIXDB-3531][COMP] Push projections into unnest operator
..
[ASTERIXDB-3531][COMP] Push projections into unnest operator
Change-Id: I83842976792f54017eff60fcc597bdd4ec6dc8c9
---
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushProjectIntoDataSourceScanRule.java
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java
M
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EmbedProjectRule.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java
8 files changed, 128 insertions(+), 59 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/00/19100/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java
index 64e41f5..8de2959 100644
---
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java
+++
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractScanOperator.java
@@ -25,7 +25,7 @@
import org.apache.hyracks.algebricks.core.algebra.base.LogicalVariable;
import
org.apache.hyracks.algebricks.core.algebra.properties.VariablePropagationPolicy;
-public abstract class AbstractScanOperator extends AbstractLogicalOperator {
+public abstract class AbstractScanOperator extends AbstractProjectingOperator {
protected List variables;
public AbstractScanOperator(List variables) {
@@ -47,6 +47,14 @@
@Override
public void recomputeSchema() {
schema = new ArrayList<>();
+
+if (isProjectPushed()) {
+for (LogicalVariable v : getProjectVariables()) {
+schema.add(v);
+}
+return;
+}
+
schema.addAll(inputs.get(0).getValue().getSchema());
schema.addAll(variables);
}
@@ -58,6 +66,14 @@
@Override
public void propagateVariables(IOperatorSchema target,
IOperatorSchema... sources)
throws AlgebricksException {
+
+if (isProjectPushed()) {
+for (LogicalVariable v : getProjectVariables()) {
+target.addVariable(v);
+}
+return;
+}
+
if (sources.length > 0) {
target.addAllVariables(sources[0]);
}
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java
index 5c485d5..6a1ccc8 100644
---
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java
+++
b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractUnnestNonMapOperator.java
@@ -90,6 +90,13 @@
@Override
public void propagateVariables(IOperatorSchema target,
IOperatorSchema... sources) {
+if (isProjectPushed()) {
+for (LogicalVariable v : getProjectVariables()) {
+target.addVariable(v);
+}
+return;
+}
+
if (sources.length > 0) {
target.addAllVariables(sources[0]);
}
diff --git
a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apach
