Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


[NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove special case of requesting startup tasks on
  NC startup complete.
- Handle case where CC might fail before sending startup
  tasks to NC.

Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2401
Sonar-Qube: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Michael Blow 
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
4 files changed, 82 insertions(+), 26 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
new file mode 100644
index 000..a1e11c2
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.app.nc.task;
+
+import org.apache.asterix.common.api.INCLifecycleTask;
+import org.apache.hyracks.api.client.NodeStatus;
+import org.apache.hyracks.api.control.CcId;
+import org.apache.hyracks.api.service.IControllerService;
+import org.apache.hyracks.control.nc.NodeControllerService;
+
+public class UpdateNodeStatusTask implements INCLifecycleTask {
+
+private static final long serialVersionUID = 1L;
+private final NodeStatus status;
+
+public UpdateNodeStatusTask(NodeStatus status) {
+this.status = status;
+}
+
+@Override
+public void perform(CcId ccId, IControllerService cs) {
+NodeControllerService ncs = (NodeControllerService) cs;
+ncs.setNodeStatus(status);
+}
+
+@Override
+public String toString() {
+return "{ \"class\" : \"" + getClass().getSimpleName() + "\" }";
+}
+}
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 25e768d..844851a 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -34,6 +34,7 @@
 import org.apache.asterix.app.nc.task.ReportLocalCountersTask;
 import org.apache.asterix.app.nc.task.StartLifecycleComponentsTask;
 import org.apache.asterix.app.nc.task.StartReplicationServiceTask;
+import org.apache.asterix.app.nc.task.UpdateNodeStatusTask;
 import org.apache.asterix.app.replication.message.MetadataNodeRequestMessage;
 import org.apache.asterix.app.replication.message.MetadataNodeResponseMessage;
 import org.apache.asterix.app.replication.message.NCLifecycleTaskReportMessage;
@@ -145,6 +146,7 @@
 return buildActiveNCRegTasks(isMetadataNode);
 }
 final List tasks = new ArrayList<>();
+tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
 if (state == SystemState.CORRUPTED) {
 //need to perform local recovery for node partitions
 LocalRecoveryTask rt = new 

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2401/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

Line 187: private NodeStatus status = NodeStatus.BOOTING;
blank line convention


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/SHPDyV : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2720/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2720/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2744/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5668/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/Huz1Kd : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3259/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3233/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3492/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5668/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2734/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/760/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2970/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/EChK87 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2724/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3284/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6703/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8210/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2401

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..

[NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove special case of requesting startup tasks on
  NC startup complete.
- Handle case where CC might fail before sending startup
  tasks to NC.

Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
4 files changed, 82 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/2401/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
new file mode 100644
index 000..a1e11c2
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/UpdateNodeStatusTask.java
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.app.nc.task;
+
+import org.apache.asterix.common.api.INCLifecycleTask;
+import org.apache.hyracks.api.client.NodeStatus;
+import org.apache.hyracks.api.control.CcId;
+import org.apache.hyracks.api.service.IControllerService;
+import org.apache.hyracks.control.nc.NodeControllerService;
+
+public class UpdateNodeStatusTask implements INCLifecycleTask {
+
+private static final long serialVersionUID = 1L;
+private final NodeStatus status;
+
+public UpdateNodeStatusTask(NodeStatus status) {
+this.status = status;
+}
+
+@Override
+public void perform(CcId ccId, IControllerService cs) {
+NodeControllerService ncs = (NodeControllerService) cs;
+ncs.setNodeStatus(status);
+}
+
+@Override
+public String toString() {
+return "{ \"class\" : \"" + getClass().getSimpleName() + "\" }";
+}
+}
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 25e768d..844851a 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -34,6 +34,7 @@
 import org.apache.asterix.app.nc.task.ReportLocalCountersTask;
 import org.apache.asterix.app.nc.task.StartLifecycleComponentsTask;
 import org.apache.asterix.app.nc.task.StartReplicationServiceTask;
+import org.apache.asterix.app.nc.task.UpdateNodeStatusTask;
 import org.apache.asterix.app.replication.message.MetadataNodeRequestMessage;
 import org.apache.asterix.app.replication.message.MetadataNodeResponseMessage;
 import org.apache.asterix.app.replication.message.NCLifecycleTaskReportMessage;
@@ -145,6 +146,7 @@
 return buildActiveNCRegTasks(isMetadataNode);
 }
 final List tasks = new ArrayList<>();
+tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
 if (state == SystemState.CORRUPTED) {
 //need to perform local recovery for node partitions
 LocalRecoveryTask rt = new 
LocalRecoveryTask(Arrays.asList(clusterManager.getNodePartitions(nodeId))
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
index b0382f7..3a8a92f 100644
--- 

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2711/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Unify Code Path of Requesting Startup Tasks
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2660/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb89d6f293b0e958c3f141afc6f1db372cee7c91
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No