Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Till Westmann has submitted this change and it was merged.
Change subject: [NO ISSUE][FUN] Add array_length()
..
[NO ISSUE][FUN] Add array_length()
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Add array_length() which is an alias for len()
- Add testcases
- Add comment explaining logical plan generation for
EVERY quantified expression
Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2446
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
5 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
index 2b7adc1..6ab76fa 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
@@ -1088,6 +1088,10 @@
fAgg =
BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.NON_EMPTY_STREAM,
new ArrayList<>());
} else { // EVERY
+// look for input items that do not satisfy the condition, if none
found then return true
+// when inverting the condition account for NULL/MISSING by
replacing them with FALSE
+// condition() -> not(if-missing-or-null(condition(), false))
+
List> ifMissingOrNullArgs = new
ArrayList<>(2);
ifMissingOrNullArgs.add(new MutableObject<>(eo2.first));
ifMissingOrNullArgs
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
new file mode 100644
index 000..66f3b93
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+[
+ is_missing(array_length(missing)),
+ is_null(array_length(null)),
+ array_length([]),
+ array_length([2]),
+ array_length([2,3]),
+ array_length([2,3,4])
+]
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
new file mode 100644
index 000..09fe966
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
@@ -0,0 +1 @@
+[ true, true, 0, 1, 2, 3 ]
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index dd1ae0c..67980d0 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -3430,6 +3430,11 @@
+
+array_length
+
+
+
exists
diff --git
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
b/asteri
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/k5c1iA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2824/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2824/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3648/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5827/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/MkqbfW : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/Q9r2MM : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5827/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3644/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/924/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2916/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3448/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3134/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3373/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2828/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2902/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6867/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3397/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2877/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8374/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5818/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2816/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2816/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3390/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/UvPmED : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3366/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3634/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5818/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/f1X1N8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2820/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2869/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6859/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3126/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8366/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2907/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2894/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/916/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Add array_length() .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3440/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Add array_length()
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2446
Change subject: [NO ISSUE][FUN] Add array_length()
..
[NO ISSUE][FUN] Add array_length()
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Add array_length() which is an alias for len()
- Add testcases
- Add comment explaining logical plan generation for
EVERY quantified expression
Change-Id: I5bd03717d3cc41567d6b060b25ca3051d9f43b3a
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
5 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/46/2446/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
index 2b7adc1..6ab76fa 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
@@ -1088,6 +1088,10 @@
fAgg =
BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.NON_EMPTY_STREAM,
new ArrayList<>());
} else { // EVERY
+// look for input items that do not satisfy the condition, if none
found then return true
+// when inverting the condition account for NULL/MISSING by
replacing them with FALSE
+// condition() -> not(if-missing-or-null(condition(), false))
+
List> ifMissingOrNullArgs = new
ArrayList<>(2);
ifMissingOrNullArgs.add(new MutableObject<>(eo2.first));
ifMissingOrNullArgs
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
new file mode 100644
index 000..66f3b93
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/list/array_length/array_length.1.query.sqlpp
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+[
+ is_missing(array_length(missing)),
+ is_null(array_length(null)),
+ array_length([]),
+ array_length([2]),
+ array_length([2,3]),
+ array_length([2,3,4])
+]
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
new file mode 100644
index 000..09fe966
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/results/list/array_length/array_length.1.adm
@@ -0,0 +1 @@
+[ true, true, 0, 1, 2, 3 ]
\ No newline at end of file
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 09fc832..ec359e2 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -3430,6 +3430,11 @@
+
+array_length
+
+
+
exists
diff --git
a/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
b/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
index 5556ea9..e5d1643 100644
---
a/asterixdb/asterix-lang-common/src/main/java/or
