Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Xikui Wang has submitted this change and it was merged.
Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring
..
[NO ISSUE][ING] Tweets ingestion related refactoring
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
As the incoming Tweets are merely JSON records, the Twitter adapter
should be able to use JSON parser. For that purpose, we changed the
record record to be consistent with JSONDataParser which uses char[]
instead of String. Also, "JSON" should also be a valid way to specify
using JSON parser.
Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3032
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Contrib: Jenkins
Reviewed-by: Wail Alkowaileet
---
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/RecordConverterFactoryProvider.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/StreamRecordReaderProviderTest.java
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java
13 files changed, 50 insertions(+), 32 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Wail Alkowaileet: Looks good to me, approved
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
index aff00fc..65ecd8d 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
@@ -128,4 +128,10 @@
builder.getChars(0, builder.length(), value, 0);
this.size = builder.length();
}
+
+public void set(String strValue) throws IOException {
+ensureCapacity(strValue.length());
+strValue.getChars(0, strValue.length(), value, 0);
+this.size = strValue.length();
+}
}
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
index b466614..81ad5ba 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java
@@ -57,7 +57,7 @@
public HttpServerRecordReader(int port, String entryPoint, int queueSize,
HttpServerConfig httpServerConfig)
throws Exception {
this.inputQ = new LinkedBlockingQueue<>(queueSize > 0 ? queueSize :
DEFAULT_QUEUE_SIZE);
-this.record = new CharArrayRecord(0);
+this.record = new CharArrayRecord();
webManager = new WebManager();
webServer = new HttpServer(webManager.getBosses(),
webManager.getWorkers(), port, httpServerConfig);
webServer.addServlet(new HttpFeedServlet(webServer.ctx(),
@@ -77,7 +77,7 @@
if (srecord == null) {
return null;
}
-record.set(srecord.toCharArray());
+record.set(srecord);
return record;
}
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Wail Alkowaileet has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Code-Review+2 I tested it locally as well. It failed because the size was not set. -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/5r16xZ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3806/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7584/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3806/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/186/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7584/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Analytics Compatibility Compilation Successful https://goo.gl/9GHcuH : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/185/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Xikui Wang has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: (5 comments) Addressed all comments. Not sure why the IT failed at the http_json test cases. Local tests show everything is fine. Let's see how this one goes... https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java: PS5, Line 135: } > add: Done https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java: PS5, Line 54: 0 > This is not needed anymore. You can make it to take the default buffer size agree https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java: PS5, Line 63: 0 > same agree! https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java: PS5, Line 73: CharArrayRecord > You can move this out of the loop. Done PS5, Line 99: CharArrayRecord > This one as well Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4724/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5328/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5098/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8706/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10239/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4758/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4760/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4979/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3032 to look at the new patch set (#6). Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. [NO ISSUE][ING] Tweets ingestion related refactoring - user model changes: no - storage format changes: no - interface changes: no Details: As the incoming Tweets are merely JSON records, the Twitter adapter should be able to use JSON parser. For that purpose, we changed the record record to be consistent with JSONDataParser which uses char[] instead of String. Also, "JSON" should also be a valid way to specify using JSON parser. Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/RecordConverterFactoryProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/StreamRecordReaderProviderTest.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java 13 files changed, 50 insertions(+), 32 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3032/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2768/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4669/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5144/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Wail Alkowaileet has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java: PS5, Line 80: record Also make this to take the initial buffer capacity. https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java: PS5, Line 54: 0 This is not needed anymore. You can make it to take the default buffer size. https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java: PS5, Line 63: 0 same https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java: PS5, Line 73: CharArrayRecord You can move this out of the loop. PS5, Line 99: CharArrayRecord This one as well -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Wail Alkowaileet has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3032/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java: PS5, Line 135: } add: this.size = strValue.length(); -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/EPeQk7 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7581/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/183/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10236/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5141/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Analytics Compatibility Compilation Successful https://goo.gl/X3fgqa : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/182/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7581/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4755/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4757/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4721/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4976/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3032 to look at the new patch set (#5). Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. [NO ISSUE][ING] Tweets ingestion related refactoring - user model changes: no - storage format changes: no - interface changes: no Details: As the incoming Tweets are merely JSON records, the Twitter adapter should be able to use JSON parser. For that purpose, we changed the record record to be consistent with JSONDataParser which uses char[] instead of String. Also, "JSON" should also be a valid way to specify using JSON parser. Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/RecordConverterFactoryProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/StreamRecordReaderProviderTest.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java 13 files changed, 48 insertions(+), 31 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3032/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5325/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8703/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5095/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2765/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4666/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/9a2oDt : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7580/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/182/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8702/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/ceP1Am : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7580/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/181/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5094/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4754/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4975/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10235/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4720/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5324/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3032 to look at the new patch set (#4). Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. [NO ISSUE][ING] Tweets ingestion related refactoring - user model changes: no - storage format changes: no - interface changes: no Details: As the incoming Tweets are merely JSON records, the Twitter adapter should be able to use JSON parser. For that purpose, we changed the record record to be consistent with JSONDataParser which uses char[] instead of String. Also, "JSON" should also be a valid way to specify using JSON parser. Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/provider/RecordConverterFactoryProvider.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/StreamRecordReaderProviderTest.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java 13 files changed, 48 insertions(+), 31 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3032/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4665/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4756/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5140/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2764/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/EBMQA2 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3798/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7566/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3798/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/170/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5080/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5126/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7566/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2750/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10221/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/169/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/LdvXEn : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5310/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8688/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4742/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4961/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3032 to look at the new patch set (#3). Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. [NO ISSUE][ING] Tweets ingestion related refactoring - user model changes: no - storage format changes: no - interface changes: no Details: As the incoming Tweets are merely JSON records, the Twitter adapter should be able to use JSON parser. For that purpose, we changed the record record to be consistent with JSONDataParser which uses char[] instead of String. Also, "JSON" should also be a valid way to specify using JSON parser. Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java 11 files changed, 50 insertions(+), 33 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3032/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4740/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4651/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4706/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wail Alkowaileet Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/N5FJYj : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7564/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3796/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3796/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/168/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5078/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/VBnU1M : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/167/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7564/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5308/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4738/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5124/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4649/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2748/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8686/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10219/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4704/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Jenkins has posted comments on this change. Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4740/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][ING] Tweets ingestion related refactoring
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3032 to look at the new patch set (#2). Change subject: [NO ISSUE][ING] Tweets ingestion related refactoring .. [NO ISSUE][ING] Tweets ingestion related refactoring - user model changes: no - storage format changes: no - interface changes: no Details: As the incoming Tweets are merely JSON records, the Twitter adapter should be able to use JSON parser. For that purpose, we changed the record record to be consistent with JSONDataParser which uses char[] instead of String. Also, "JSON" should also be a valid way to specify using JSON parser. Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/TweetParser.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/JSONDataParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/TweetParserFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/parser/test/TweetParserTest.java 9 files changed, 43 insertions(+), 29 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/32/3032/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6d656a4af974499ef0df2e389152ca205c2d078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
