Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][NET] Networking Improvements .. [NO ISSUE][NET] Networking Improvements - user model changes: no - storage format changes: no - interface changes: no Details: - Set keep alive and no TCP delay options on socket channels. - Cancel key and close IPC handle on failed read/writes to avoid getting the same failures with every NetworkThread loop. Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Reviewed-on: https://asterix-gerrit.ics.uci.edu/2418 Sonar-Qube: JenkinsTested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins Reviewed-by: Michael Blow --- M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml M hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java M hyracks-fullstack/hyracks/hyracks-net/pom.xml M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java 7 files changed, 139 insertions(+), 52 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Michael Blow: Looks good to me, approved diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java index d3ddc43..bfac451 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java @@ -32,7 +32,7 @@ import org.apache.asterix.common.storage.ReplicaIdentifier; import org.apache.asterix.replication.messaging.ReplicationProtocol; import org.apache.asterix.replication.sync.ReplicaSynchronizer; -import org.apache.hyracks.util.JSONUtil; +import org.apache.hyracks.util.NetworkUtil; import org.apache.hyracks.util.StorageUtil; import org.apache.hyracks.util.annotations.ThreadSafe; import org.apache.logging.log4j.LogManager; @@ -97,6 +97,7 @@ try { if (sc == null || !sc.isOpen() || !sc.isConnected()) { sc = SocketChannel.open(); +NetworkUtil.configure(sc); sc.configureBlocking(true); sc.connect(id.getLocation()); } diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java index a092322..8ccfced 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java @@ -30,6 +30,7 @@ import org.apache.asterix.common.replication.IPartitionReplica; import org.apache.asterix.common.replication.IReplicationDestination; import org.apache.asterix.replication.messaging.ReplicationProtocol; +import org.apache.hyracks.util.NetworkUtil; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -78,6 +79,7 @@ try { if (logRepChannel == null || !logRepChannel.isOpen() || !logRepChannel.isConnected()) { logRepChannel = SocketChannel.open(); +NetworkUtil.configure(logRepChannel); logRepChannel.configureBlocking(true); logRepChannel.connect(location); } diff --git a/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml b/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml index 7f492eb..7f59db1 100644 --- a/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml @@ -53,5 +53,10 @@ org.apache.logging.log4j log4j-api + + org.apache.hyracks + hyracks-util + ${project.version} + diff --git a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java b/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java index 86c8c75..3e6c64b 100644 --- a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java +++
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Zd6wtx : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2759/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5735/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2759/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/FJG2D1 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5735/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/bUaWo2 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java: PS2, Line 370: LOGGER.error(() -> new ParameterizedMessage("TCP read error from {}", handle.getRemoteAddress()), e); > how does this differ from: It's not PS2, Line 394: LOGGER.error(() -> new ParameterizedMessage("TCP write error to {}", handle.getRemoteAddress()), e); > see above q see above a https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java File hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java: PS2, Line 211: LOGGER.error(() -> new ParameterizedMessage("Error in TCPEndpoint {}", localAddress), e); > not asking again not answering again -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3318/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3555/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3041/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8281/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2818/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2735/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2808/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3355/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3294/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6774/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2782/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/831/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2418 to look at the new patch set (#3). Change subject: [NO ISSUE][NET] Networking Improvements .. [NO ISSUE][NET] Networking Improvements - user model changes: no - storage format changes: no - interface changes: no Details: - Set keep alive and no TCP delay options on socket channels. - Cancel key and close IPC handle on failed read/writes to avoid getting the same failures with every NetworkThread loop. Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a --- M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml M hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java M hyracks-fullstack/hyracks/hyracks-net/pom.xml M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java 7 files changed, 139 insertions(+), 52 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/2418/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java: PS2, Line 370: LOGGER.error(() -> new ParameterizedMessage("TCP read error from {}", handle.getRemoteAddress()), e); how does this differ from: LOGGER.error("TCP read error from {}", handle::getRemoteAddress, e); PS2, Line 394: LOGGER.error(() -> new ParameterizedMessage("TCP write error to {}", handle.getRemoteAddress()), e); see above q https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java File hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java: PS2, Line 211: LOGGER.error(() -> new ParameterizedMessage("Error in TCPEndpoint {}", localAddress), e); not asking again -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/2f3ELV : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/2Xx5N1 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Analytics Compatibility Tests Failed https://goo.gl/bywCQu : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5733/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2756/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/1sUwU1 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2756/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/8ZeuEE : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3316/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5733/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/bVFbnZ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3553/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3292/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2814/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2780/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3353/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3039/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2733/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/829/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6772/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8279/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2418 to look at the new patch set (#2). Change subject: [NO ISSUE][NET] Networking Improvements .. [NO ISSUE][NET] Networking Improvements - user model changes: no - storage format changes: no - interface changes: no Details: - Set keep alive and no TCP delay options on socket channels. - Cancel key and close IPC handle on failed read/writes to avoid getting the same failures with every NetworkThread loop. Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a --- M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml M hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java M hyracks-fullstack/hyracks/hyracks-net/pom.xml M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java 7 files changed, 141 insertions(+), 52 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/2418/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2806/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5732/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3315/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/QRbcVm : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5732/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8278/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2805/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/828/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3291/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3552/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6771/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2418 Change subject: [NO ISSUE][NET] Networking Improvements .. [NO ISSUE][NET] Networking Improvements - user model changes: no - storage format changes: no - interface changes: no Details: - Set keep alive and no TCP delay options on socket channels. - Cancel key and close IPC handle on failed read/writes to avoid getting the same failures with every NetworkThread loop. Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a --- M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml M hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java 6 files changed, 136 insertions(+), 52 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/2418/1 diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java index d3ddc43..bfac451 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java @@ -32,7 +32,7 @@ import org.apache.asterix.common.storage.ReplicaIdentifier; import org.apache.asterix.replication.messaging.ReplicationProtocol; import org.apache.asterix.replication.sync.ReplicaSynchronizer; -import org.apache.hyracks.util.JSONUtil; +import org.apache.hyracks.util.NetworkUtil; import org.apache.hyracks.util.StorageUtil; import org.apache.hyracks.util.annotations.ThreadSafe; import org.apache.logging.log4j.LogManager; @@ -97,6 +97,7 @@ try { if (sc == null || !sc.isOpen() || !sc.isConnected()) { sc = SocketChannel.open(); +NetworkUtil.configure(sc); sc.configureBlocking(true); sc.connect(id.getLocation()); } diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java index a092322..8ccfced 100644 --- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java +++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java @@ -30,6 +30,7 @@ import org.apache.asterix.common.replication.IPartitionReplica; import org.apache.asterix.common.replication.IReplicationDestination; import org.apache.asterix.replication.messaging.ReplicationProtocol; +import org.apache.hyracks.util.NetworkUtil; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -78,6 +79,7 @@ try { if (logRepChannel == null || !logRepChannel.isOpen() || !logRepChannel.isConnected()) { logRepChannel = SocketChannel.open(); +NetworkUtil.configure(logRepChannel); logRepChannel.configureBlocking(true); logRepChannel.connect(location); } diff --git a/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml b/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml index 7f492eb..7f59db1 100644 --- a/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-ipc/pom.xml @@ -53,5 +53,10 @@ org.apache.logging.log4j log4j-api + + org.apache.hyracks + hyracks-util + ${project.version} + diff --git a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java b/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java index 86c8c75..a34a7d0 100644 --- a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java +++ b/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java @@ -21,7 +21,6 @@ import java.io.IOException; import java.net.InetSocketAddress; import java.net.ServerSocket; -import java.net.StandardSocketOptions; import java.nio.ByteBuffer; import java.nio.channels.Channel; import java.nio.channels.ClosedChannelException; @@ -41,9 +40,11 @@ import java.util.concurrent.TimeUnit; import
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3038/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3352/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2732/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2779/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2813/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No