Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Ali Alsuliman has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Support log redaction 2
..
[NO ISSUE][OTH] Support log redaction 2
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Modify ILogRedactor to enable reversing the redaction
- Redact user data in exceptions thrown in the grammar file
Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3125
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Contrib: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
4 files changed, 32 insertions(+), 7 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
index 88b5da8..94d63a4 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
@@ -57,6 +57,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.exceptions.HyracksException;
import org.apache.hyracks.control.cc.ClusterControllerService;
+import org.apache.hyracks.util.LogRedactionUtil;
import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -181,6 +182,6 @@
@Override
public String toString() {
return String.format("%s(id=%s, from=%s): %s",
getClass().getSimpleName(), requestMessageId, requestNodeId,
-statementsText);
+LogRedactionUtil.userData(statementsText));
}
}
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 45ba7c3..19a4da2 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -184,6 +184,7 @@
import
org.apache.hyracks.algebricks.core.algebra.expressions.IndexedNLJoinExpressionAnnotation;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
import org.apache.hyracks.api.exceptions.SourceLocation;
+import org.apache.hyracks.util.LogRedactionUtil;
class SQLPPParser extends ScopeChecker implements IParser {
@@ -400,7 +401,7 @@
}
private SqlppParseException createUnexpectedTokenError() {
- return new SqlppParseException(getSourceLocation(token), "Unexpected
token: " + token.image);
+ return new SqlppParseException(getSourceLocation(token), "Unexpected
token: " + LogRedactionUtil.userData(token.image));
}
private boolean laToken(int idx, int kind, String image) {
@@ -2445,7 +2446,7 @@
try {
lit.setValue(new LongIntegerLiteral(Long.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
@@ -2453,7 +2454,7 @@
try {
lit.setValue(new FloatLiteral(Float.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
@@ -2461,7 +2462,7 @@
try {
lit.setValue(new DoubleLiteral(Double.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
diff --git
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Rhy6Ce : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3913/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7795/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3913/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/98/ (15/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2978/ (5/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4978/ (13/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5309/ (14/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/oNHJZK : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7795/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/373/ (1/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/377/ (7/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4968/ (9/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5352/ (2/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5538/ (12/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3125 to look at the new patch set (#2). Change subject: [NO ISSUE][OTH] Support log redaction 2 .. [NO ISSUE][OTH] Support log redaction 2 - user model changes: no - storage format changes: no - interface changes: no Details: - Modify ILogRedactor to enable reversing the redaction - Redact user data in exceptions thrown in the grammar file Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java M hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java 4 files changed, 32 insertions(+), 7 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/25/3125/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8917/ (3/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/134/ (4/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10450/ (10/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4934/ (8/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5191/ (6/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4880/ (11/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/nmtQKT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3912/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3912/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7794/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: -Contrib Analytics Compatibility Compilation Successful https://goo.gl/zaW5vn : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/97/ (15/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7794/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4967/ (11/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5308/ (14/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8916/ (3/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/XbuVyq : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4977/ (13/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/376/ (6/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/133/ (5/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5351/ (8/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5190/ (4/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/372/ (9/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4879/ (1/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2977/ (2/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10449/ (12/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Ali Alsuliman has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3125
Change subject: [NO ISSUE][OTH] Support log redaction 2
..
[NO ISSUE][OTH] Support log redaction 2
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Modify ILogRedactor to enable reversing the redaction
- Redact user data in exceptions thrown in the grammar file
Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5
---
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
M
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
3 files changed, 30 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/25/3125/1
diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 45ba7c3..19a4da2 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -184,6 +184,7 @@
import
org.apache.hyracks.algebricks.core.algebra.expressions.IndexedNLJoinExpressionAnnotation;
import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
import org.apache.hyracks.api.exceptions.SourceLocation;
+import org.apache.hyracks.util.LogRedactionUtil;
class SQLPPParser extends ScopeChecker implements IParser {
@@ -400,7 +401,7 @@
}
private SqlppParseException createUnexpectedTokenError() {
- return new SqlppParseException(getSourceLocation(token), "Unexpected
token: " + token.image);
+ return new SqlppParseException(getSourceLocation(token), "Unexpected
token: " + LogRedactionUtil.userData(token.image));
}
private boolean laToken(int idx, int kind, String image) {
@@ -2445,7 +2446,7 @@
try {
lit.setValue(new LongIntegerLiteral(Long.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
@@ -2453,7 +2454,7 @@
try {
lit.setValue(new FloatLiteral(Float.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
@@ -2461,7 +2462,7 @@
try {
lit.setValue(new DoubleLiteral(Double.valueOf(token.image)));
} catch (NumberFormatException e) {
-throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + token.image +'"');
+throw new SqlppParseException(getSourceLocation(token), "Could not
parse numeric literal \"" + LogRedactionUtil.userData(token.image) +'"');
}
}
|
diff --git
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
index 18e9a34..b133894 100644
---
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
+++
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java
@@ -22,8 +22,17 @@
/**
* Redacts user data argument.
+ *
* @param text user data to redact.
* @return redacted user data.
*/
String userData(String text);
+
+/**
+ * Unredacts user data found in the argument.
+ *
+ * @param text text that contains some redacted user data.
+ * @return the text with user data unredacted.
+ */
+String unredactUserData(String text);
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
index 29242be..89c957e 100644
---
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
+++
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java
@@ -21,8 +21,18 @@
public class LogRedactionUtil {
-private static final ILogRedactor defaultLogRedactor = text -> text;
-private static ILogRedactor redactor = defaultLogRedactor;
+private static final ILogRedactor DEFAULT_LOG_REDACTOR = new
ILogRedactor() {
+@Override
+
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4933/ (10/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction 2
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction 2 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5537/ (7/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3125 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If971d0a913e2b7efe521e2d54646568f789937b5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Ali Alsuliman has submitted this change and it was merged. Change subject: [NO ISSUE][OTH] Support log redaction .. [NO ISSUE][OTH] Support log redaction - user model changes: no - storage format changes: no - interface changes: no Details: Support log redaction. Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Reviewed-on: https://asterix-gerrit.ics.uci.edu/3105 Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Contrib: Jenkins Reviewed-by: Murtadha Hubail --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java M asterixdb/asterix-lang-sqlpp/pom.xml M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/ExpressionToVariableUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java M hyracks-fullstack/algebricks/algebricks-core/pom.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/FDsAndEquivClassesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java M hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java M hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameDeserializer.java M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/SerializingDataWriter.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java 30 files changed, 192 insertions(+), 79 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Murtadha Hubail: Looks good to me, approved diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java index 1eb3e75..4839ac3 100644 --- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java +++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java @@ -35,6 +35,7 @@ import org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractLogicalOperator; import org.apache.hyracks.algebricks.core.algebra.operators.logical.SelectOperator; import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule; +import org.apache.hyracks.util.LogRedactionUtil;
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/q1V8fq : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/hea7XB : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: -Contrib Analytics Compatibility Compilation Successful https://goo.gl/tzxEaH : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3910/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7792/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3910/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/95/ (15/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5306/ (14/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/370/ (10/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4975/ (13/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/ZYx2pP : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7792/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8914/ (2/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/374/ (7/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/131/ (6/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2975/ (3/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4931/ (5/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5535/ (8/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5349/ (11/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4877/ (12/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4965/ (1/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10447/ (9/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5188/ (4/15) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Dmitry Lychagin has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7785/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3907/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3907/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5342/ (3/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Ali Alsuliman has posted comments on this change.
Change subject: [NO ISSUE][OTH] Support log redaction
..
Patch Set 8:
(8 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:
Line 225: throw new
CompilationException(ErrorCode.COMPILATION_ERROR, a2.getSourceLocation(),
> The concern is that topOp.toString() can have user data? I'd just remove to
I just removed it. My point was redacting this topOp is useless even though it
might contain user data because toString() is not overridden in logical
operators and this would just produce the operator class/object name.
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:
Line 285: "Field access " +
assignOp.getExpressions().get(0).getValue() + " doesn't correspond to any
input");
> same comment. remove inputOp and just rely on the source location. or alter
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java:
Line 336: + ((AbstractFunctionCallExpression)
aggFuncExpr).getFunctionIdentifier().getName()
> let's replace with the function name
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java:
Line 110: }
> let's remove "in op" + op? source location and a function name should be su
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:
Line 168: if (physicalOperator == null) {
> theres no need to print the whole operator here. Source location and Logica
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java:
Line 316: throw
AlgebricksException.create(DESCRIPTOR_GENERATION_ERROR, op.getSourceLocation(),
op.getOperatorTag());
> let's print source location and LogicalOperatorTag instead.
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java:
Line 227: throw
AlgebricksException.create(ORDER_EXPR_NOT_NORMALIZED, e.getSourceLocation());
> source location should be sufficient instead of the whole expression. It's
Done
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java:
Line 120: + opBuild.getOperatorTag() + ": " + v + "\n");
> we're printing the whole operator here, so seem that we need to redact it.
I just replaced it with the operator tag since it's almost the same as the
toString() method.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3105
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5299/ (14/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3105 to look at the new patch set (#8). Change subject: [NO ISSUE][OTH] Support log redaction .. [NO ISSUE][OTH] Support log redaction - user model changes: no - storage format changes: no - interface changes: no Details: Support log redaction. Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CheckFilterExpressionTypeRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedLogManager.java M asterixdb/asterix-lang-sqlpp/pom.xml M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/ExpressionToVariableUtil.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java M hyracks-fullstack/algebricks/algebricks-core/pom.xml M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/FDsAndEquivClassesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractUnnestPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/AbstractRuleController.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java M hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java M hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameDeserializer.java M hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/SerializingDataWriter.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/ILogRedactor.java A hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/LogRedactionUtil.java 30 files changed, 192 insertions(+), 79 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/05/3105/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8907/ (8/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4967/ (13/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/TX78Rt : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7785/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5181/ (12/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/124/ (5/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5528/ (4/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4924/ (11/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/363/ (7/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2968/ (6/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4958/ (10/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/368/ (9/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10440/ (2/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4870/ (1/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Dmitry Lychagin has posted comments on this change.
Change subject: [NO ISSUE][OTH] Support log redaction
..
Patch Set 7:
(9 comments)
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:
Line 225: // check this
The concern is that topOp.toString() can have user data? I'd just remove topOp
then. Not clear what user would be able to do by looking at the internal
operator representation. The source location information should be enough to
give user some information about the problem.
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:
Line 285: // check this
same comment. remove inputOp and just rely on the source location. or
alternatively we could replace it with inputOp.getOperatorTag()
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java:
Line 336: "The aggregation function " + aggFuncExpr
let's replace with the function name
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java:
Line 110: "Found non-functional function " +
fce.getFunctionIdentifier() + " in op " + op);
let's remove "in op" + op? source location and a function name should be
sufficient for user to understand the problem
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:
Line 838: // no redaction for with map??
winVarMap.values() returns VariableExprs, so we'll print variable names, should
be ok as is.
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:
Line 168: // check this
theres no need to print the whole operator here. Source location and
LogicalOperatorTag should be sufficient
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java:
Line 316: throw new AlgebricksException("Could not generate
operator descriptor for operator " + op);
let's print source location and LogicalOperatorTag instead.
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java:
Line 227: throw new AlgebricksException("Order
expression " + LogRedactionUtil.userData(e.toString())
source location should be sufficient instead of the whole expression. It's a
bug in the compiler, so user cannot do much.
https://asterix-gerrit.ics.uci.edu/#/c/3105/7/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
File
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java:
Line 120: // check this
we're printing the whole operator here, so seem that we need to redact it. Also
in line 130
--
To view, visit https://asterix-gerrit.ics.uci.edu/3105
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha
Change in asterixdb[master]: [NO ISSUE][OTH] Support log redaction
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Support log redaction .. Patch Set 7: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/fG1eXb : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3105 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602c833ba2a055da8fbe8782ec62be683ff4581b Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
