Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-29 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has submitted this change and it was merged.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


[NO ISSUE][STO] Add consistency to flush lifecycle

- user model changes: no
- storage format changes: yes
  - renamed AbstractLSMIOOperationCallbackFactory
to LSMIOOperationCallbackFactory
  - useless classes have been removed.
- LSMBTreeIOOperationCallbackFactory
- LSMBTreeWithBuddyIOOperationCallbackFactory
- LSMInvertedIndexIOOperationCallbackFactory
- LSMRTreeIOOperationCallbackFactory
- interface changes: yes

Details:
- Previously, flushes have different lifecycle depending
  on the memory component state
  - not allocated
  - allocated
  - modified
- In certain cases, flush operations are skipped alltogether
- IO Operation callbacks became complicated and difficult
  to maintain since calls are done differently in different
  cases.
- In certain cases, afterFinalize is called on the IO
  Operation callbacks even if beforeOperation was never
  called.
- In this change, flushes go through the same lifecycle
  events regardless of the state of the memory component.
- In addition, primary and secondary memory components
  would reside in different virtual buffer caches due
  to skipped flushes, or due to having the secondary
  index created when the primary index's memory component
  is residing on the virtual buffer cache with index !=0.
- Moreover, when flushes are lagging and all memory
  components are being flushed, search operations assumes
  the oldest of the memory component is the newest and
  produces incorrect results.
- In addition, in case of a failed flush of a component,
  the IO scheduler would skip it and flush the next
  component. This would produce a bad state on disk.
- In this change, a failed flush can be retried. otherwise,
  all future flushes of the component fail due to the failure
  of the previously failed flush.
- Previously, when a component fails to modify an index due
  to flush failures, it assumes disk is full.
- With this change, the modification failure reports the
  original cause of the failed flush.

Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2584
Reviewed-by: Murtadha Hubail 
Tested-by: Murtadha Hubail 
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/HaltCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/IoCallbackFailureTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LSMFlushRecoveryTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTracker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TransactionAbortTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetInfoProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ILSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfoProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMIndexUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java
D 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-29 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/hxWtRE : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6329/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/zRAVT1 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3119/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Analytics Compatibility Compilation Successful
https://goo.gl/Cr57At : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6329/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3119/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20: Code-Review+2 Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread abdullah alamoudi (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2584

to look at the new patch set (#20).

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..

[NO ISSUE][STO] Add consistency to flush lifecycle

- user model changes: no
- storage format changes: yes
  - renamed AbstractLSMIOOperationCallbackFactory
to LSMIOOperationCallbackFactory
  - useless classes have been removed.
- LSMBTreeIOOperationCallbackFactory
- LSMBTreeWithBuddyIOOperationCallbackFactory
- LSMInvertedIndexIOOperationCallbackFactory
- LSMRTreeIOOperationCallbackFactory
- interface changes: yes

Details:
- Previously, flushes have different lifecycle depending
  on the memory component state
  - not allocated
  - allocated
  - modified
- In certain cases, flush operations are skipped alltogether
- IO Operation callbacks became complicated and difficult
  to maintain since calls are done differently in different
  cases.
- In certain cases, afterFinalize is called on the IO
  Operation callbacks even if beforeOperation was never
  called.
- In this change, flushes go through the same lifecycle
  events regardless of the state of the memory component.
- In addition, primary and secondary memory components
  would reside in different virtual buffer caches due
  to skipped flushes, or due to having the secondary
  index created when the primary index's memory component
  is residing on the virtual buffer cache with index !=0.
- Moreover, when flushes are lagging and all memory
  components are being flushed, search operations assumes
  the oldest of the memory component is the newest and
  produces incorrect results.
- In addition, in case of a failed flush of a component,
  the IO scheduler would skip it and flush the next
  component. This would produce a bad state on disk.
- In this change, a failed flush can be retried. otherwise,
  all future flushes of the component fail due to the failure
  of the previously failed flush.
- Previously, when a component fails to modify an index due
  to flush failures, it assumes disk is full.
- With this change, the modification failure reports the
  original cause of the failed flush.

Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/HaltCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/IoCallbackFailureTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LSMFlushRecoveryTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTracker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TransactionAbortTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetInfoProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ILSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfoProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMIndexUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
D 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4176/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3992/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3419/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3372/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3448/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3891/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1467/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7399/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3460/
 (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3911/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8923/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 20:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3675/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 20
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6327/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Please fix the formatting issue

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19: -Code-Review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/ALG8TK : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Analytics Compatibility Compilation Successful
https://goo.gl/LW8Bwz : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6327/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1465/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3417/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8921/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3370/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3673/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3446/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3909/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3458/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4174/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3990/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread abdullah alamoudi (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2584

to look at the new patch set (#19).

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..

[NO ISSUE][STO] Add consistency to flush lifecycle

- user model changes: no
- storage format changes: yes
  - renamed AbstractLSMIOOperationCallbackFactory
to LSMIOOperationCallbackFactory
  - useless classes have been removed.
- LSMBTreeIOOperationCallbackFactory
- LSMBTreeWithBuddyIOOperationCallbackFactory
- LSMInvertedIndexIOOperationCallbackFactory
- LSMRTreeIOOperationCallbackFactory
- interface changes: yes

Details:
- Previously, flushes have different lifecycle depending
  on the memory component state
  - not allocated
  - allocated
  - modified
- In certain cases, flush operations are skipped alltogether
- IO Operation callbacks became complicated and difficult
  to maintain since calls are done differently in different
  cases.
- In certain cases, afterFinalize is called on the IO
  Operation callbacks even if beforeOperation was never
  called.
- In this change, flushes go through the same lifecycle
  events regardless of the state of the memory component.
- In addition, primary and secondary memory components
  would reside in different virtual buffer caches due
  to skipped flushes, or due to having the secondary
  index created when the primary index's memory component
  is residing on the virtual buffer cache with index !=0.
- Moreover, when flushes are lagging and all memory
  components are being flushed, search operations assumes
  the oldest of the memory component is the newest and
  produces incorrect results.
- In addition, in case of a failed flush of a component,
  the IO scheduler would skip it and flush the next
  component. This would produce a bad state on disk.
- In this change, a failed flush can be retried. otherwise,
  all future flushes of the component fail due to the failure
  of the previously failed flush.
- Previously, when a component fails to modify an index due
  to flush failures, it assumes disk is full.
- With this change, the modification failure reports the
  original cause of the failed flush.

Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/HaltCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/IoCallbackFailureTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LSMFlushRecoveryTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTracker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TransactionAbortTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetInfoProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ILSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfoProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMIndexUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
D 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3889/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 19:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7397/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2584/18/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

Line 756: } catch (InterruptedException e) {
> re-interrupt thread
Done


Line 786: } catch (InterruptedException e) {
> re-interrupt thread
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2584/18/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java:

Line 756: } catch (InterruptedException e) {
re-interrupt thread


Line 786: } catch (InterruptedException e) {
re-interrupt thread


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6326/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/AMRfRG : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-28 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/wAC9LW : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Analytics Compatibility Compilation Successful
https://goo.gl/Um1tYS : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6326/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3989/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread abdullah alamoudi (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2584

to look at the new patch set (#18).

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..

[NO ISSUE][STO] Add consistency to flush lifecycle

- user model changes: no
- storage format changes: yes
  - renamed AbstractLSMIOOperationCallbackFactory
to LSMIOOperationCallbackFactory
  - useless classes have been removed.
- LSMBTreeIOOperationCallbackFactory
- LSMBTreeWithBuddyIOOperationCallbackFactory
- LSMInvertedIndexIOOperationCallbackFactory
- LSMRTreeIOOperationCallbackFactory
- interface changes: yes

Details:
- Previously, flushes have different lifecycle depending
  on the memory component state
  - not allocated
  - allocated
  - modified
- In certain cases, flush operations are skipped alltogether
- IO Operation callbacks became complicated and difficult
  to maintain since calls are done differently in different
  cases.
- In certain cases, afterFinalize is called on the IO
  Operation callbacks even if beforeOperation was never
  called.
- In this change, flushes go through the same lifecycle
  events regardless of the state of the memory component.
- In addition, primary and secondary memory components
  would reside in different virtual buffer caches due
  to skipped flushes, or due to having the secondary
  index created when the primary index's memory component
  is residing on the virtual buffer cache with index !=0.
- Moreover, when flushes are lagging and all memory
  components are being flushed, search operations assumes
  the oldest of the memory component is the newest and
  produces incorrect results.
- In addition, in case of a failed flush of a component,
  the IO scheduler would skip it and flush the next
  component. This would produce a bad state on disk.
- In this change, a failed flush can be retried. otherwise,
  all future flushes of the component fail due to the failure
  of the previously failed flush.
- Previously, when a component fails to modify an index due
  to flush failures, it assumes disk is full.
- With this change, the modification failure reports the
  original cause of the failed flush.

Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/HaltCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/IoCallbackFailureTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LSMFlushRecoveryTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTracker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TransactionAbortTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetInfoProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ILSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfoProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMIndexUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
D 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3445/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3369/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7396/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3888/
 (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3672/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8920/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3416/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1464/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3908/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4173/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 18:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3457/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Analytics Compatibility Compilation Successful
https://goo.gl/3rgdtW : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6325/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3671/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3415/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8919/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3444/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread abdullah alamoudi (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2584

to look at the new patch set (#17).

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..

[NO ISSUE][STO] Add consistency to flush lifecycle

- user model changes: no
- storage format changes: yes
  - renamed AbstractLSMIOOperationCallbackFactory
to LSMIOOperationCallbackFactory
  - useless classes have been removed.
- LSMBTreeIOOperationCallbackFactory
- LSMBTreeWithBuddyIOOperationCallbackFactory
- LSMInvertedIndexIOOperationCallbackFactory
- LSMRTreeIOOperationCallbackFactory
- interface changes: yes

Details:
- Previously, flushes have different lifecycle depending
  on the memory component state
  - not allocated
  - allocated
  - modified
- In certain cases, flush operations are skipped alltogether
- IO Operation callbacks became complicated and difficult
  to maintain since calls are done differently in different
  cases.
- In certain cases, afterFinalize is called on the IO
  Operation callbacks even if beforeOperation was never
  called.
- In this change, flushes go through the same lifecycle
  events regardless of the state of the memory component.
- In addition, primary and secondary memory components
  would reside in different virtual buffer caches due
  to skipped flushes, or due to having the secondary
  index created when the primary index's memory component
  is residing on the virtual buffer cache with index !=0.
- Moreover, when flushes are lagging and all memory
  components are being flushed, search operations assumes
  the oldest of the memory component is the newest and
  produces incorrect results.
- In addition, in case of a failed flush of a component,
  the IO scheduler would skip it and flush the next
  component. This would produce a bad state on disk.
- In this change, a failed flush can be retried. otherwise,
  all future flushes of the component fail due to the failure
  of the previously failed flush.
- Previously, when a component fails to modify an index due
  to flush failures, it assumes disk is full.
- With this change, the modification failure reports the
  original cause of the failed flush.

Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/HaltCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/IoCallbackFailureTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LSMFlushRecoveryTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/MultiPartitionLSMIndexTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/SearchCursorComponentSwitchTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java
R 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmIoOpCallbackFactory.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestPrimaryIndexOperationTracker.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TransactionAbortTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
D 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetInfoProvider.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ILSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfoProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMIndexUtil.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ExceptionUtils.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java
D 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7395/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3368/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4172/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3456/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3988/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1463/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3887/
 (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 17:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3907/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-27 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

(37 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java:

PS16, Line 185: AsynchronousScheduler
> define as inner static class
Done


PS16, Line 188: warn
> fatal or error
Done


PS16, Line 194: warn
> fatal or error
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java:

PS16, Line 284: final MetadataTransactionContext committedMdTxn = 
MetadataManager.INSTANCE.beginTransaction();
  : 
MetadataManager.INSTANCE.addNodegroup(committedMdTxn, new 
NodeGroup(committedNodeGroup, ngNodes));
  : 
MetadataManager.INSTANCE.commitTransaction(committedMdTxn);
> why is this needed?
Because otherwise, the primary index is not modified and so, the flush on line 
288 will be ignored.


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java:

PS16, Line 40: 
 : 
> Why FLUSH/MERGE is removed?
They are now handled when the IO operation is scheduled, completed.
we should probably do the same for replicate as well.


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java:

PS16, Line 54: public
> private
Done


PS16, Line 55: public
> private
Done


PS16, Line 65: ArrayDeque
> Use Deque interface?
Done


PS16, Line 106: // check status of the flush
> Remove
Done


PS16, Line 177: componentId
> component LSN
Done


PS16, Line 181: ILSMComponent
> ILSMDiskComponent
Done


PS16, Line 182: ILSMDiskComponent
> Remove
Done


PS16, Line 215: // check status before updating
> remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java:

PS16, Line 38: protected
> private
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java:

PS16, Line 140: @param operation
> Remove
Done


PS16, Line 143: String getOperationGroupId();
> What's the usage of this method? More comments about this "group"?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperationCallback.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperationCallback.java:

PS16, Line 87: getOperationGroupId
> is the group id always the index identifier? if so, I think we should remov
This was here to allow for overriding the order enforcement and allow for 
example primary and secondary to be processed together. However, since it is 
not used. I am removing it.


PS16, Line 87: operation
> java docs
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexOperationContext.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexOperationContext.java:

PS16, Line 112: void setMap(Map map);
> I think we can still do something better explicitly for flush info in Aster
Done


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractIoOperation.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractIoOperation.java:

PS16, Line 87: getStatus
> will state be accessed from anywhere that is not synchronized?
Should be accessed by the IO operation thread only while it is running. Should 
be accessed by outside callers once it 

Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-26 Thread Luo Chen (Code Review)
Luo Chen has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

(8 comments)

Some minor comments...

https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java:

PS16, Line 40: 
 : 
Why FLUSH/MERGE is removed?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java:

PS16, Line 65: ArrayDeque
Use Deque interface?


PS16, Line 177: componentId
component LSN


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java:

PS16, Line 143: String getOperationGroupId();
What's the usage of this method? More comments about this "group"?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexOperationContext.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexOperationContext.java:

PS16, Line 62: map
use a more meaning name, like parameterMap?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AsynchronousScheduler.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AsynchronousScheduler.java:

PS16, Line 68: PriorityQueue q = new 
PriorityQueue<>();
Why we need a priority queue here? It seems FIFO queue should be enough?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGenerator.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGenerator.java:

PS16, Line 32: private int currentComponentIndex;
Why do we need to keep track of this?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexDiskComponentBulkLoader.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexDiskComponentBulkLoader.java:

PS16, Line 38:  // Note that by using a flush target file name, we state that 
the
 : // new bulk loaded component is "newer" than any other 
merged component.
This comment can be removed?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-26 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

(29 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java:

PS16, Line 185: AsynchronousScheduler
define as inner static class


PS16, Line 188: warn
fatal or error


PS16, Line 194: warn
fatal or error


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java:

PS16, Line 284: final MetadataTransactionContext committedMdTxn = 
MetadataManager.INSTANCE.beginTransaction();
  : 
MetadataManager.INSTANCE.addNodegroup(committedMdTxn, new 
NodeGroup(committedNodeGroup, ngNodes));
  : 
MetadataManager.INSTANCE.commitTransaction(committedMdTxn);
why is this needed?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIOOperationCallback.java:

PS16, Line 54: public
private


PS16, Line 55: public
private


PS16, Line 106: // check status of the flush
Remove


PS16, Line 181: ILSMComponent
ILSMDiskComponent


PS16, Line 182: ILSMDiskComponent
Remove


PS16, Line 215: // check status before updating
remove


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMIndexIOOperationCallbackFactory.java:

PS16, Line 38: protected
private


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperation.java:

PS16, Line 140: @param operation
Remove


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperationCallback.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIOOperationCallback.java:

PS16, Line 87: operation
java docs


PS16, Line 87: getOperationGroupId
is the group id always the index identifier? if so, I think we should remove 
the "group" from here and replace it with something that indicates the index 
identifier.


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexOperationContext.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexOperationContext.java:

PS16, Line 112: void setMap(Map map);
I think we can still do something better explicitly for flush info in Asterix 
implementation of this interface, but this can be done in its own change.


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractIoOperation.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractIoOperation.java:

PS16, Line 87: getStatus
will state be accessed from anywhere that is not synchronized?


PS16, Line 124: return;
why not rethrow?


https://asterix-gerrit.ics.uci.edu/#/c/2584/16/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java:

PS16, Line 219: 
createAccessor(NoOpIndexAccessParameters.INSTANCE).scheduleFlush().sync();
what if this triggers a merge? shouldn't we wait for it as well before 
deactivating the index?


PS16, Line 347: ScheduleFlushCalled
fix


PS16, Line 363: Map map = ctx.getMap();
  : if (map != null && !map.isEmpty()) {
  : flushCtx.setMap(new HashMap<>(map));
  : }
refactor with the one below



Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-25 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-25 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6299/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6299/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3431/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3419/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7370/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3862/
 (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1438/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3390/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8894/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3343/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4146/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3882/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3646/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Add consistency to flush lifecycle

2018-04-24 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Add consistency to flush lifecycle
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3963/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2584
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29f7992ec6c0f71c5b63d45800b2fb590d651e4b
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


  1   2   3   4   >