Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5615/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2693/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2693/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Michael Blow (Code Review)
Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


[NO ISSUE][STO] Platform Independent File Path Split

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Avoid regex while splitting file paths to
  eliminate invalid regex on Windows platform.

Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2391
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins: Verified; No violations found
  Michael Blow: Looks good to me, approved

Objections:
  Anon. E. Moose #1000171: Violations found



diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
index 52cf4a0..81d311d 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
@@ -23,6 +23,7 @@
 import java.nio.file.Paths;
 
 import org.apache.asterix.common.utils.StorageConstants;
+import org.apache.commons.lang3.StringUtils;
 
 public class ResourceReference {
 
@@ -77,7 +78,7 @@
 
 protected static void parse(ResourceReference ref, String path) {
 // format: 
root/partition/dataverse/dataset/rebalanceCount/index/fileName
-final String[] tokens = path.split(File.separator);
+final String[] tokens = StringUtils.split(path, File.separatorChar);
 if (tokens.length < 6) {
 throw new IllegalStateException("Unrecognized path structure: " + 
path);
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/975xk3 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/HFGF8z : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5615/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3212/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3224/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3184/
 (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2651/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3439/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2599/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Michael Blow (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2391

to look at the new patch set (#2).

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..

[NO ISSUE][STO] Platform Independent File Path Split

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Avoid regex while splitting file paths to
  eliminate invalid regex on Windows platform.

Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/91/2391/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2646/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8149/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6643/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2671/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/700/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2910/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/ykjX2N : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3211/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/7o8mwy : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5614/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2645/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8148/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/699/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3438/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2909/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2650/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2598/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2391

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..

[NO ISSUE][STO] Platform Independent File Path Split

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Avoid regex while splitting file paths to
  eliminate invalid regex on Windows platform.

Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/91/2391/1

diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
index 52cf4a0..ea84285 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ResourceReference.java
@@ -23,6 +23,7 @@
 import java.nio.file.Paths;
 
 import org.apache.asterix.common.utils.StorageConstants;
+import org.apache.commons.lang3.StringUtils;
 
 public class ResourceReference {
 
@@ -77,7 +78,7 @@
 
 protected static void parse(ResourceReference ref, String path) {
 // format: 
root/partition/dataverse/dataset/rebalanceCount/index/fileName
-final String[] tokens = path.split(File.separator);
+final String[] tokens = StringUtils.split(path, File.separator);
 if (tokens.length < 6) {
 throw new IllegalStateException("Unrecognized path structure: " + 
path);
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3183/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6642/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Platform Independent File Path Split

2018-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Platform Independent File Path Split
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2670/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2391
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d6bae7e35b26c6fd5685757a7c13ea86811f14
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No