Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-14 Thread Michael Blow (Code Review)
Michael Blow has submitted this change and it was merged.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


[NO ISSUE][TEST] Refactor licensing test support

Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2479
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Murtadha Hubail 
---
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
M hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/LicensingTestBase.java
4 files changed, 105 insertions(+), 40 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Murtadha Hubail: Looks good to me, approved



diff --git a/asterixdb/asterix-server/pom.xml b/asterixdb/asterix-server/pom.xml
index 7e86edc..fd6dd79 100644
--- a/asterixdb/asterix-server/pom.xml
+++ b/asterixdb/asterix-server/pom.xml
@@ -620,5 +620,10 @@
   asterix-fuzzyjoin
   ${project.version}
 
+
+  org.apache.hyracks
+  hyracks-test-support
+  test
+
   
 
diff --git 
a/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
 
b/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
index 4ac3abb..60406b8 100644
--- 
a/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
+++ 
b/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
@@ -18,77 +18,56 @@
  */
 package org.apache.asterix.test.server;
 
-import java.io.File;
 import java.io.IOException;
-import java.nio.charset.StandardCharsets;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
 
-import org.apache.commons.io.FileUtils;
+import org.apache.hyracks.test.support.LicensingTestBase;
 import org.apache.hyracks.util.file.FileUtil;
-import org.junit.Assert;
 import org.junit.Before;
 import org.junit.FixMethodOrder;
 import org.junit.Test;
 import org.junit.runners.MethodSorters;
 
 @FixMethodOrder(MethodSorters.JVM)
-public class LicensingIT {
-
-protected String installerDir;
+public class LicensingIT extends LicensingTestBase {
 
 @Before
 public void setup() {
-final String pattern = getInstallerDirPattern();
-final String targetDir = getTargetDir();
-final String[] list = new File(targetDir).list((dir, name) -> 
name.matches(pattern));
-Assert.assertNotNull("installerDir", list);
-Assert.assertFalse("Ambiguous install dir (" + pattern + "): " + 
Arrays.toString(list), list.length > 1);
-Assert.assertEquals("Can't find install dir (" + pattern + ")", 1, 
list.length);
-installerDir = FileUtil.joinPath(targetDir, list[0]);
+initInstallerDir();
 }
 
+@Override
 protected String getTargetDir() {
 return FileUtil.joinPath("target");
 }
 
+@Override
 protected String getInstallerDirPattern() {
 return "asterix-server.*-binary-assembly";
 }
 
+@Override
 protected String pathToLicensingFiles() {
 return "";
 }
 
-@Test
-public void testLicenseNoticeFilesPresent() throws IOException {
-for (String name : getRequiredArtifactNames()) {
-final String fileName = FileUtil.joinPath(installerDir, 
pathToLicensingFiles(), name);
-Assert.assertTrue(fileName + " missing", new 
File(fileName).exists());
-}
-}
-
+@Override
 protected String[] getRequiredArtifactNames() {
 return 
org.apache.commons.lang3.ArrayUtils.add(getLicenseArtifactNames(), "NOTICE");
 }
 
-@Test
-public void ensureNoMissingLicenses() throws IOException {
-for (String licenseArtifactName : getLicenseArtifactNames()) {
-final File licenseFile =
-new File(FileUtil.joinPath(installerDir, 
pathToLicensingFiles(), licenseArtifactName));
-List badLines = new ArrayList<>();
-for (String line : FileUtils.readLines(licenseFile, 
StandardCharsets.UTF_8)) {
-if (line.matches("^\\s*MISSING:.*")) {
-badLines.add(line.trim());
-}
-}
-Assert.assertEquals("Missing licenses in " + licenseFile + ": " + 
badLines, 0, badLines.size());
-}
-}
-
+@Override
 protected String[] getLicenseArtifactNames() {
 return new String[] { "LICENSE" };
 }
+
+@Test
+public void testLicenseNoticeFilesPresent() {
+verifyAllRequiredArtifactsPresent();
+}
+
+@Test
+

Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-14 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5932/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2884/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/viLfZm : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2884/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5932/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3508/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3484/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3756/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/BJGkSP : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3035/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Michael Blow (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2479

to look at the new patch set (#3).

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..

[NO ISSUE][TEST] Refactor licensing test support

Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
---
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
M hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/LicensingTestBase.java
4 files changed, 105 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/79/2479/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6986/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1043/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3567/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8493/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3023/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2996/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2948/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3253/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/83zwHX : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5930/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/ye6FBP : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Michael Blow (Code Review)
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2479

to look at the new patch set (#2).

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..

[NO ISSUE][TEST] Refactor licensing test support

Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
---
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
M hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/LicensingTestBase.java
4 files changed, 105 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/79/2479/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3033/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3251/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3021/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2994/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8491/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2946/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3565/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1041/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3482/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3754/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3506/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6984/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5928/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2880/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2880/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/sNpmvR : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5928/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/AXUj5q : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3751/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3018/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3479/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3562/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3030/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2991/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3248/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3503/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2479

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..

[NO ISSUE][TEST] Refactor licensing test support

Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
---
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
M hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/LicensingTestBase.java
4 files changed, 103 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/79/2479/1

diff --git a/asterixdb/asterix-server/pom.xml b/asterixdb/asterix-server/pom.xml
index 8a28a49..4c93a42 100644
--- a/asterixdb/asterix-server/pom.xml
+++ b/asterixdb/asterix-server/pom.xml
@@ -614,5 +614,10 @@
   org.apache.logging.log4j
   log4j-api
 
+
+  org.apache.hyracks
+  hyracks-test-support
+  test
+
   
 
diff --git 
a/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
 
b/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
index 4ac3abb..60406b8 100644
--- 
a/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
+++ 
b/asterixdb/asterix-server/src/test/java/org/apache/asterix/test/server/LicensingIT.java
@@ -18,77 +18,56 @@
  */
 package org.apache.asterix.test.server;
 
-import java.io.File;
 import java.io.IOException;
-import java.nio.charset.StandardCharsets;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
 
-import org.apache.commons.io.FileUtils;
+import org.apache.hyracks.test.support.LicensingTestBase;
 import org.apache.hyracks.util.file.FileUtil;
-import org.junit.Assert;
 import org.junit.Before;
 import org.junit.FixMethodOrder;
 import org.junit.Test;
 import org.junit.runners.MethodSorters;
 
 @FixMethodOrder(MethodSorters.JVM)
-public class LicensingIT {
-
-protected String installerDir;
+public class LicensingIT extends LicensingTestBase {
 
 @Before
 public void setup() {
-final String pattern = getInstallerDirPattern();
-final String targetDir = getTargetDir();
-final String[] list = new File(targetDir).list((dir, name) -> 
name.matches(pattern));
-Assert.assertNotNull("installerDir", list);
-Assert.assertFalse("Ambiguous install dir (" + pattern + "): " + 
Arrays.toString(list), list.length > 1);
-Assert.assertEquals("Can't find install dir (" + pattern + ")", 1, 
list.length);
-installerDir = FileUtil.joinPath(targetDir, list[0]);
+initInstallerDir();
 }
 
+@Override
 protected String getTargetDir() {
 return FileUtil.joinPath("target");
 }
 
+@Override
 protected String getInstallerDirPattern() {
 return "asterix-server.*-binary-assembly";
 }
 
+@Override
 protected String pathToLicensingFiles() {
 return "";
 }
 
-@Test
-public void testLicenseNoticeFilesPresent() throws IOException {
-for (String name : getRequiredArtifactNames()) {
-final String fileName = FileUtil.joinPath(installerDir, 
pathToLicensingFiles(), name);
-Assert.assertTrue(fileName + " missing", new 
File(fileName).exists());
-}
-}
-
+@Override
 protected String[] getRequiredArtifactNames() {
 return 
org.apache.commons.lang3.ArrayUtils.add(getLicenseArtifactNames(), "NOTICE");
 }
 
-@Test
-public void ensureNoMissingLicenses() throws IOException {
-for (String licenseArtifactName : getLicenseArtifactNames()) {
-final File licenseFile =
-new File(FileUtil.joinPath(installerDir, 
pathToLicensingFiles(), licenseArtifactName));
-List badLines = new ArrayList<>();
-for (String line : FileUtils.readLines(licenseFile, 
StandardCharsets.UTF_8)) {
-if (line.matches("^\\s*MISSING:.*")) {
-badLines.add(line.trim());
-}
-}
-Assert.assertEquals("Missing licenses in " + licenseFile + ": " + 
badLines, 0, badLines.size());
-}
-}
-
+@Override
 protected String[] getLicenseArtifactNames() {
 return new String[] { "LICENSE" };
 }
+
+@Test
+public void testLicenseNoticeFilesPresent() {
+verifyAllRequiredArtifactsPresent();
+}
+
+@Test
+public void ensureNoMissingLicenses() throws IOException {
+verifyMissingLicenses();
+}
+
 }
diff --git a/hyracks-fullstack/hyracks/hyracks-test-support/pom.xml 
b/hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
index 67ebc9b..7fa9a12 100644
--- a/hyracks-fullstack/hyracks/hyracks-test-support/pom.xml
+++ 

Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1038/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2943/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8488/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][TEST] Refactor licensing test support

2018-03-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TEST] Refactor licensing test support
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6981/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2479
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11385a73302b22f9aaaf91c426df8320f52ebb72
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No