Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one)
..
[NO ISSUE][TXN] Fix txnid leak (off by one)
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Fix leak of one id at start of each allocated block
- Increase block size from 100 -> 512
Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2465
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java
index d44bb13..6b3b6a0 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java
@@ -89,7 +89,7 @@
}
private long nextId() throws BlockExhaustedException {
-long nextId = id.incrementAndGet();
+long nextId = id.getAndIncrement();
if (nextId >= endExclusive && (endExclusive >= start || nextId <
start)) {
throw BLOCK_EXHAUSTED_EXCEPTION;
}
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java
index b8578ec..4e1c3b1 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java
@@ -33,7 +33,7 @@
public class TxnIdBlockRequest implements ICcAddressedMessage {
private static final Logger LOGGER = LogManager.getLogger();
-private static final int BLOCK_SIZE = 100;
+private static final int BLOCK_SIZE = 512;
private static final long serialVersionUID = 1L;
private static BlockingQueue blockQueue = new
LinkedBlockingQueue<>();
--
To view, visit https://asterix-gerrit.ics.uci.edu/2465
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5898/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2861/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2861/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5898/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3470/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3446/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3718/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/f4SXpd : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/ifuQsT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2994/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2909/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2957/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2983/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8454/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1004/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3214/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6947/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3528/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2465 to look at the new patch set (#4). Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. [NO ISSUE][TXN] Fix txnid leak (off by one) - user model changes: no - storage format changes: no - interface changes: no Details: - Fix leak of one id at start of each allocated block - Increase block size from 100 -> 512 Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 --- M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/65/2465/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/kemJdh : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5894/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3466/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3442/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/hJG5ke : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2990/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3714/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2979/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2953/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3210/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2905/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8450/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1000/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6943/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3524/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix txnid leak (off by one)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2465 to look at the new patch set (#3). Change subject: [NO ISSUE][TXN] Fix txnid leak (off by one) .. [NO ISSUE][TXN] Fix txnid leak (off by one) - user model changes: no - storage format changes: no - interface changes: no Details: - Fix leak of one id at start of each allocated block - Increase block size from 100 -> 512 Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 --- M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/CachingTxnIdFactory.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequest.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/65/2465/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2465 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia97d8472f30ef0f68c51830b4cbb4660184d7393 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
