Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE] Close resources during bytecode generation
..
[NO ISSUE] Close resources during bytecode generation
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Close resources when generating bytecode for built-in
functions
Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2388
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
1 file changed, 79 insertions(+), 69 deletions(-)
Approvals:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
Objections:
Anon. E. Moose #1000171: Violations found
diff --git
a/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
b/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
index 6d3feb7..c396358 100644
---
a/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
+++
b/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
@@ -60,7 +60,7 @@
* @throws IOException
*/
public void runAction(String targetClassName, byte[]
classDefinitionBytes) throws IOException;
-};
+}
/**
* Generates the byte code for a scalar function descriptor.
@@ -101,29 +101,32 @@
CodeGenHelper.toJdkStandardName(targetFuncDescriptorClassName)));
// Gathers evaluator factory classes that are created in the function
descriptor.
-ClassReader reader = new
ClassReader(getResourceStream(internalFuncDescriptorClassName, classLoader));
-GatherEvaluatorFactoryCreationVisitor evalFactoryCreationVisitor =
-new
GatherEvaluatorFactoryCreationVisitor(CodeGenHelper.toInternalClassName(packagePrefix));
-reader.accept(evalFactoryCreationVisitor, 0);
-Set evaluatorFactoryClassNames =
evalFactoryCreationVisitor.getCreatedEvaluatorFactoryClassNames();
+try (InputStream internalFuncDescriptorStream =
+getResourceStream(internalFuncDescriptorClassName,
classLoader)) {
+ClassReader reader = new ClassReader(internalFuncDescriptorStream);
+GatherEvaluatorFactoryCreationVisitor evalFactoryCreationVisitor =
+new
GatherEvaluatorFactoryCreationVisitor(CodeGenHelper.toInternalClassName(packagePrefix));
+reader.accept(evalFactoryCreationVisitor, 0);
+Set evaluatorFactoryClassNames =
evalFactoryCreationVisitor.getCreatedEvaluatorFactoryClassNames();
-// Generates inner classes other than evaluator factories.
-generateNonEvalInnerClasses(reader, evaluatorFactoryClassNames,
nameMappings, suffixForGeneratedClass,
-classLoader, action);
+// Generates inner classes other than evaluator factories.
+generateNonEvalInnerClasses(reader, evaluatorFactoryClassNames,
nameMappings, suffixForGeneratedClass,
+classLoader, action);
-// Generates evaluator factories that are created in the function
descriptor.
-int evalFactoryCounter = 0;
-for (String evaluateFactoryClassName : evaluatorFactoryClassNames) {
-generateEvaluatorFactoryClassBinary(packagePrefix,
evaluateFactoryClassName, suffixForGeneratedClass,
-evalFactoryCounter++, nameMappings, classLoader, action);
+// Generates evaluator factories that are created in the function
descriptor.
+int evalFactoryCounter = 0;
+for (String evaluateFactoryClassName : evaluatorFactoryClassNames)
{
+generateEvaluatorFactoryClassBinary(packagePrefix,
evaluateFactoryClassName, suffixForGeneratedClass,
+evalFactoryCounter++, nameMappings, classLoader,
action);
+}
+
+// Transforms the function descriptor class and outputs the
generated class binary.
+ClassWriter writer = new ClassWriter(reader, 0);
+RenameClassVisitor renamingVisitor = new
RenameClassVisitor(writer, nameMappings);
+reader.accept(renamingVisitor, 0);
+action.runAction(targetFuncDescriptorClassName,
writer.toByteArray());
+return nameMappings;
}
-
-// Transforms the function descriptor class a
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Michael Blow has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Analytics Compatibility Tests Failed https://goo.gl/wV9ciM : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Analytics Compatibility Tests Failed https://goo.gl/LtHWLK : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2687/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2687/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2638/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5606/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Analytics Compatibility Tests Failed https://goo.gl/nJdA4U : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/Qyq4t1 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3203/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3175/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3430/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5606/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/enJ36R : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2901/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2590/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/691/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2636/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8140/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2388
Change subject: [NO ISSUE] Close resources during bytecode generation
..
[NO ISSUE] Close resources during bytecode generation
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Close resources when generating bytecode for built-in
functions
Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615
---
M
asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
1 file changed, 79 insertions(+), 69 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/88/2388/1
diff --git
a/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
b/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
index 6d3feb7..c396358 100644
---
a/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
+++
b/asterixdb/asterix-maven-plugins/asterix-evaluator-generator-maven-plugin/src/main/java/org/apache/asterix/runtime/evaluators/staticcodegen/CodeGenUtil.java
@@ -60,7 +60,7 @@
* @throws IOException
*/
public void runAction(String targetClassName, byte[]
classDefinitionBytes) throws IOException;
-};
+}
/**
* Generates the byte code for a scalar function descriptor.
@@ -101,29 +101,32 @@
CodeGenHelper.toJdkStandardName(targetFuncDescriptorClassName)));
// Gathers evaluator factory classes that are created in the function
descriptor.
-ClassReader reader = new
ClassReader(getResourceStream(internalFuncDescriptorClassName, classLoader));
-GatherEvaluatorFactoryCreationVisitor evalFactoryCreationVisitor =
-new
GatherEvaluatorFactoryCreationVisitor(CodeGenHelper.toInternalClassName(packagePrefix));
-reader.accept(evalFactoryCreationVisitor, 0);
-Set evaluatorFactoryClassNames =
evalFactoryCreationVisitor.getCreatedEvaluatorFactoryClassNames();
+try (InputStream internalFuncDescriptorStream =
+getResourceStream(internalFuncDescriptorClassName,
classLoader)) {
+ClassReader reader = new ClassReader(internalFuncDescriptorStream);
+GatherEvaluatorFactoryCreationVisitor evalFactoryCreationVisitor =
+new
GatherEvaluatorFactoryCreationVisitor(CodeGenHelper.toInternalClassName(packagePrefix));
+reader.accept(evalFactoryCreationVisitor, 0);
+Set evaluatorFactoryClassNames =
evalFactoryCreationVisitor.getCreatedEvaluatorFactoryClassNames();
-// Generates inner classes other than evaluator factories.
-generateNonEvalInnerClasses(reader, evaluatorFactoryClassNames,
nameMappings, suffixForGeneratedClass,
-classLoader, action);
+// Generates inner classes other than evaluator factories.
+generateNonEvalInnerClasses(reader, evaluatorFactoryClassNames,
nameMappings, suffixForGeneratedClass,
+classLoader, action);
-// Generates evaluator factories that are created in the function
descriptor.
-int evalFactoryCounter = 0;
-for (String evaluateFactoryClassName : evaluatorFactoryClassNames) {
-generateEvaluatorFactoryClassBinary(packagePrefix,
evaluateFactoryClassName, suffixForGeneratedClass,
-evalFactoryCounter++, nameMappings, classLoader, action);
+// Generates evaluator factories that are created in the function
descriptor.
+int evalFactoryCounter = 0;
+for (String evaluateFactoryClassName : evaluatorFactoryClassNames)
{
+generateEvaluatorFactoryClassBinary(packagePrefix,
evaluateFactoryClassName, suffixForGeneratedClass,
+evalFactoryCounter++, nameMappings, classLoader,
action);
+}
+
+// Transforms the function descriptor class and outputs the
generated class binary.
+ClassWriter writer = new ClassWriter(reader, 0);
+RenameClassVisitor renamingVisitor = new
RenameClassVisitor(writer, nameMappings);
+reader.accept(renamingVisitor, 0);
+action.runAction(targetFuncDescriptorClassName,
writer.toByteArray());
+return nameMappings;
}
-
-// Transforms the function descriptor class and outputs the generated
class binary.
-ClassWriter writer = new ClassWriter(reader, 0);
-RenameClassVisitor renamingVisitor = new RenameClassVisitor(writer,
nameMappings);
-reader.acc
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6634/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2642/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3215/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Close resources during bytecode generation
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Close resources during bytecode generation .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2662/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2388 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f86b54244caee7c1864a2981fade199d1eb6615 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
