Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Luo Chen has submitted this change and it was merged.
Change subject: [NO ISSUE] Use Async Write Mode in ResultState
..
[NO ISSUE] Use Async Write Mode in ResultState
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Use Async write mode in ResultState to improve it's throughput.
- For concurrent reader, use the same file handle (since it's a
RandomAccessFile) for both read/write. Reference counting is used to
ensure the file is properly opened/closed.
Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2560
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
1 file changed, 73 insertions(+), 57 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; ; Verified
Objections:
Jenkins: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
index b832b20..6b35912 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
@@ -61,9 +61,9 @@
private FileReference fileRef;
-private IFileHandle writeFileHandle;
+private IFileHandle fileHandle;
-private IFileHandle readFileHandle;
+private volatile int referenceCount = 0;
private long size;
@@ -86,12 +86,13 @@
localPageList = new ArrayList<>();
fileRef = null;
-writeFileHandle = null;
+fileHandle = null;
}
public synchronized void open() {
size = 0;
persistentSize = 0;
+referenceCount = 0;
}
public synchronized void close() {
@@ -112,25 +113,29 @@
}
private void closeWriteFileHandle() {
-if (writeFileHandle != null) {
+if (fileHandle != null) {
+doCloseFileHandle();
+}
+}
+
+private void doCloseFileHandle() {
+if (--referenceCount == 0) {
+// close the file if there is no more reference
try {
-ioManager.close(writeFileHandle);
+ioManager.close(fileHandle);
} catch (IOException e) {
// Since file handle could not be closed, just ignore.
}
-writeFileHandle = null;
+fileHandle = null;
}
}
public synchronized void write(ByteBuffer buffer) throws
HyracksDataException {
if (fileRef == null) {
-String fName = FILE_PREFIX +
String.valueOf(resultSetPartitionId.getPartition());
-fileRef = fileFactory.createUnmanagedWorkspaceFile(fName);
-writeFileHandle = ioManager.open(fileRef,
IIOManager.FileReadWriteMode.READ_WRITE,
-IIOManager.FileSyncMode.METADATA_ASYNC_DATA_SYNC);
+initWriteFileHandle();
}
-size += ioManager.syncWrite(writeFileHandle, size, buffer);
+size += ioManager.syncWrite(fileHandle, size, buffer);
notifyAll();
}
@@ -165,9 +170,8 @@
}
public synchronized void readClose() throws HyracksDataException {
-if (readFileHandle != null) {
-ioManager.close(readFileHandle);
-readFileHandle = null;
+if (fileHandle != null) {
+doCloseFileHandle();
}
}
@@ -185,51 +189,49 @@
return readSize;
}
-if (readFileHandle == null) {
+if (fileHandle == null) {
initReadFileHandle();
}
-readSize = ioManager.syncRead(readFileHandle, offset, buffer);
+readSize = ioManager.syncRead(fileHandle, offset, buffer);
return readSize;
}
-public long read(DatasetMemoryManager datasetMemoryManager, long offset,
ByteBuffer buffer)
+public synchronized long read(DatasetMemoryManager datasetMemoryManager,
long offset, ByteBuffer buffer)
throws HyracksDataException {
long readSize = 0;
-synchronized (this) {
-while (offset >= size && !eos.get() && !failed.get()) {
-try {
-wait();
-} catch (InterruptedException e) {
-throw HyracksDataException.create(e);
-}
+while (offset >= size && !eos.get() && !failed.get()) {
+try {
+wait();
+} catch (Inter
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/xdkkbq : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/rBL8yz : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6159/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3023/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3023/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Analytics Compatibility Compilation Successful https://goo.gl/LPt95x : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6159/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Luo Chen has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2560/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java: PS4, Line 67: > initial comment (didn't download the patch and it's hard to track usages he Volatile should be enough...Done. -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3495/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3192/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3280/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3733/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1287/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8743/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3266/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3711/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3239/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7227/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3811/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3992/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2560 to look at the new patch set (#5). Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. [NO ISSUE] Use Async Write Mode in ResultState - user model changes: no - storage format changes: no - interface changes: no Details: - Use Async write mode in ResultState to improve it's throughput. - For concurrent reader, use the same file handle (since it's a RandomAccessFile) for both read/write. Reference counting is used to ensure the file is properly opened/closed. Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java 1 file changed, 73 insertions(+), 57 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/2560/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Michael Blow has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2560/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java: PS4, Line 67: AtomicInteger initial comment (didn't download the patch and it's hard to track usages here, but...) isn't this only modified from synchronized methods? if so, wouldn't volatile int suffice? -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3014/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3014/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6146/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/gLYRU4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3979/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/Xf2H8x : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6146/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3698/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1274/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8730/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3253/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3267/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2560 to look at the new patch set (#4). Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. [NO ISSUE] Use Async Write Mode in ResultState - user model changes: no - storage format changes: no - interface changes: no Details: - Use Async write mode in ResultState to improve it's throughput. - For concurrent reader, use the same file handle (since it's a RandomAccessFile) for both read/write. Reference counting is used to ensure the file is properly opened/closed. Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java 1 file changed, 74 insertions(+), 57 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/2560/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3978/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3798/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3179/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7214/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3482/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3226/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3720/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6143/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/zcPMpt : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/kC9aGv : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/UKbEXz : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3010/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3010/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/PFhLSP : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6143/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7211/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1271/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3717/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3975/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3795/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2560 to look at the new patch set (#3). Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. [NO ISSUE] Use Async Write Mode in ResultState - user model changes: no - storage format changes: no - interface changes: no Details: - Use Async write mode in ResultState to improve it's throughput. - For concurrent reader, use the same file handle (since it's a RandomAccessFile) for both read/write. Reference counting is used to ensure the file is properly opened/closed. Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java 1 file changed, 75 insertions(+), 57 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/2560/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3250/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3695/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3176/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3479/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3223/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3264/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8727/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/PhKV9k : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6142/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3175/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8726/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3716/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3794/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7210/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3249/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3694/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3478/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3263/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1270/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3222/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3974/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2560 to look at the new patch set (#2). Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. [NO ISSUE] Use Async Write Mode in ResultState - user model changes: no - storage format changes: no - interface changes: no Details: - Use Async write mode in ResultState to improve it's throughput. - For concurrent reader, use the same file handle (since it's a RandomAccessFile) for both read/write. Reference counting is used to ensure the file is properly opened/closed. Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java 1 file changed, 46 insertions(+), 30 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/60/2560/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/BfYigy : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6141/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3477/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1269/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3248/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3693/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3262/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3793/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3715/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3221/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Luo Chen has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2560
Change subject: [NO ISSUE] Use Async Write Mode in ResultState
..
[NO ISSUE] Use Async Write Mode in ResultState
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Use Async write mode in ResultState to improve it's throughput.
- For concurrent reader, use the same file handle (since it's a
RandomAccessFile) for both read/write. Reference counting is used to
ensure the file is properly opened/closed.
Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
1 file changed, 44 insertions(+), 29 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/60/2560/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
index b832b20..eaef3cc 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/ResultState.java
@@ -25,6 +25,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
import org.apache.hyracks.api.dataflow.state.IStateObject;
import org.apache.hyracks.api.exceptions.HyracksDataException;
@@ -61,9 +62,9 @@
private FileReference fileRef;
-private IFileHandle writeFileHandle;
+private IFileHandle fileHandle;
-private IFileHandle readFileHandle;
+private final AtomicInteger referenceCount = new AtomicInteger(0);
private long size;
@@ -86,12 +87,13 @@
localPageList = new ArrayList<>();
fileRef = null;
-writeFileHandle = null;
+fileHandle = null;
}
public synchronized void open() {
size = 0;
persistentSize = 0;
+referenceCount.set(0);
}
public synchronized void close() {
@@ -112,25 +114,29 @@
}
private void closeWriteFileHandle() {
-if (writeFileHandle != null) {
+if (fileHandle != null) {
+doCloseFileHandle();
+}
+}
+
+private void doCloseFileHandle() {
+if (referenceCount.decrementAndGet() == 0) {
+// close the file if there is no more reference
try {
-ioManager.close(writeFileHandle);
+ioManager.close(fileHandle);
} catch (IOException e) {
// Since file handle could not be closed, just ignore.
}
-writeFileHandle = null;
+fileHandle = null;
}
}
public synchronized void write(ByteBuffer buffer) throws
HyracksDataException {
if (fileRef == null) {
-String fName = FILE_PREFIX +
String.valueOf(resultSetPartitionId.getPartition());
-fileRef = fileFactory.createUnmanagedWorkspaceFile(fName);
-writeFileHandle = ioManager.open(fileRef,
IIOManager.FileReadWriteMode.READ_WRITE,
-IIOManager.FileSyncMode.METADATA_ASYNC_DATA_SYNC);
+initWriteFileHandle();
}
-size += ioManager.syncWrite(writeFileHandle, size, buffer);
+size += ioManager.syncWrite(fileHandle, size, buffer);
notifyAll();
}
@@ -165,9 +171,8 @@
}
public synchronized void readClose() throws HyracksDataException {
-if (readFileHandle != null) {
-ioManager.close(readFileHandle);
-readFileHandle = null;
+if (fileHandle != null) {
+doCloseFileHandle();
}
}
@@ -185,10 +190,10 @@
return readSize;
}
-if (readFileHandle == null) {
+if (fileHandle == null) {
initReadFileHandle();
}
-readSize = ioManager.syncRead(readFileHandle, offset, buffer);
+readSize = ioManager.syncRead(fileHandle, offset, buffer);
return readSize;
}
@@ -210,10 +215,10 @@
}
if (offset < persistentSize) {
-if (readFileHandle == null) {
+if (fileHandle == null) {
initReadFileHandle();
}
-readSize = ioManager.syncRead(readFileHandle, offset, buffer);
+readSize = ioManager.syncRead(fileHandle, offset, buffer);
if (readSize < 0) {
throw new HyracksDataException("Premature end of file");
}
@@ -245,21 +250,17 @@
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3973/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8725/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7209/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Use Async Write Mode in ResultState
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Use Async Write Mode in ResultState .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3174/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2560 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053f8e258759881583deb509425b585bc3c4bf2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
