Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-14 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1: Code-Review+2

All right.
We probably should remove that after 1570 is fixed.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-14 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1:

I have never reproduced this locally- the information is helpful for reports by 
others in the future.

The atomic increment should not be expensive given it is only once per pin.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-14 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1:

Why this change should be merged as it's only for debugging purpose?

Is there a debug flag that we can check instead of mutating a atomic value 
every time?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-14 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/918/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1570 Debugging
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/918/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1570 Debugging

2016-10-13 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1282

Change subject: ASTERIXDB-1570 Debugging
..

ASTERIXDB-1570 Debugging

Report how many pins took place on extended pin cycles, in case the
failures are due to unfair queueing

Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
---
M 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/82/1282/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index 28ba981..3be1c46 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -35,6 +35,7 @@
 import java.util.concurrent.Executor;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.logging.Level;
@@ -82,6 +83,7 @@
 //!DEBUG
 private IIOReplicationManager ioReplicationManager;
 private final List cachedPages = new ArrayList<>();
+private final AtomicLong masterPinCount = new AtomicLong();
 
 private boolean closed;
 
@@ -1245,6 +1247,7 @@
 
 private ICachedPage getPageLoop(long dpid, int multiplier, boolean 
confiscate)
 throws HyracksDataException {
+final long startingPinCount = masterPinCount.get();
 int cycleCount = 0;
 try {
 while (true) {
@@ -1252,6 +1255,7 @@
 int startCleanedCount = cleanerThread.cleanedCount;
 ICachedPage page = confiscate ? confiscateInner(dpid, 
multiplier) : findPageInner(dpid);
 if (page != null) {
+masterPinCount.incrementAndGet();
 return page;
 }
 // no page available to confiscate. try kicking the cleaner 
thread.
@@ -1286,13 +1290,15 @@
 if (cycleCount > MAX_PIN_ATTEMPT_CYCLES) {
 cycleCount = 0; // suppress warning below
 throw new HyracksDataException("Unable to find free page 
in buffer cache after "
-+ MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache 
undersized?)");
++ MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache 
undersized?); "
++ (masterPinCount.get() - startingPinCount) + " 
successful pins since start of cycle");
 }
 }
 } finally {
 if (cycleCount > PIN_ATTEMPT_CYCLES_WARNING_THRESHOLD && 
LOGGER.isLoggable(Level.WARNING)) {
 LOGGER.warning("Took " + cycleCount + " cycles to find free 
page in buffer cache.  (buffer cache " +
-"undersized?)");
+"undersized?); " + (masterPinCount.get() - 
startingPinCount) +
+" successful pins since start of cycle");
 }
 }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1282
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16a3316d9f6f1d436873c051bd0f260126483ceb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow