Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


ASTERIXDB-1711: rename asterix_transaction_log

- s/asterix_transaction_log/transaction_log/
- update storage version
- remove some dead code

Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1368
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
M asterixdb/asterix-yarn/src/main/resources/configs/local.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
3 files changed, 8 insertions(+), 21 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
index 083ccf6..c64bd4a 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
@@ -27,32 +27,26 @@
 private static final long serialVersionUID = 2084227360840799662L;
 
 public static final String lineSeparator = 
System.getProperty("line.separator");
-public static final int LOG_MAGIC_NUMBER = 123456789;
-public static final String LOG_DIR_SUFFIX = ".txnLogDir";
-private static final String DEFAULT_LOG_FILE_PREFIX = 
"asterix_transaction_log";
+private static final String DEFAULT_LOG_FILE_PREFIX = "transaction_log";
 
 // follow the naming convention _ where number 
starts from 0
 private final String logFilePrefix;
 private final String logDir;
-public String logDirKey;
 
 // number of log pages in the log buffer
 private final int logPageSize;
 // number of log pages in the log buffer.
 private final int numLogPages;
-// logBufferSize = logPageSize * numLogPages;
-private final int logBufferSize;
 // maximum size of each log file
 private final long logPartitionSize;
 
 public LogManagerProperties(AsterixTransactionProperties txnProperties, 
String nodeId) {
-this.logDirKey = new String(nodeId + LOG_DIR_SUFFIX);
 this.logPageSize = txnProperties.getLogBufferPageSize();
 this.numLogPages = txnProperties.getLogBufferNumPages();
 long logPartitionSize = txnProperties.getLogPartitionSize();
 this.logDir = txnProperties.getLogDirectory(nodeId);
 this.logFilePrefix = DEFAULT_LOG_FILE_PREFIX;
-this.logBufferSize = logPageSize * numLogPages;
+int logBufferSize = logPageSize * numLogPages;
 //make sure that the log partition size is the multiple of log buffer 
size.
 this.logPartitionSize = (logPartitionSize / logBufferSize) * 
logBufferSize;
 }
@@ -77,14 +71,7 @@
 return numLogPages;
 }
 
-public int getLogBufferSize() {
-return logBufferSize;
-}
-
-public String getLogDirKey() {
-return logDirKey;
-}
-
+@Override
 public String toString() {
 StringBuilder builder = new StringBuilder();
 builder.append("log_dir_ : " + logDir + lineSeparator);
diff --git a/asterixdb/asterix-yarn/src/main/resources/configs/local.xml 
b/asterixdb/asterix-yarn/src/main/resources/configs/local.xml
index 76979b8..c026aef 100644
--- a/asterixdb/asterix-yarn/src/main/resources/configs/local.xml
+++ b/asterixdb/asterix-yarn/src/main/resources/configs/local.xml
@@ -21,13 +21,13 @@
   
   local
 
-  /tmp/
-  /tmp/
+  /tmp/asterix-yarn/
+  /tmp/asterix-yarn/
 
   
-  /tmp
+  /tmp/asterix-yarn
 
   
   storage
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
index 21e918d..653f6ae 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
@@ -23,9 +23,9 @@
 
 public interface ITreeIndexMetaDataFrame {
 
-//Storage version #. Change this if you alter any tree frame formats to 
stop
+// Storage version #. Change this if you alter any 

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1303/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1303/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/30/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3525/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Till Westmann (Code Review)]

Hello abdullah alamoudi, Ian Maxon, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1368

to look at the new patch set (#5).

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..

ASTERIXDB-1711: rename asterix_transaction_log

- s/asterix_transaction_log/transaction_log/
- update storage version
- remove some dead code

Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
M asterixdb/asterix-yarn/src/main/resources/configs/local.xml
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
3 files changed, 8 insertions(+), 21 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/1368/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 4: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1299/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/28/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3523/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Till Westmann (Code Review)]

Hello abdullah alamoudi, Ian Maxon, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1368

to look at the new patch set (#4).

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..

ASTERIXDB-1711: rename asterix_transaction_log

- s/asterix_transaction_log/transaction_log/
- update storage version
- remove some dead code

Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogManagerProperties.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
2 files changed, 5 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/68/1368/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

I'm currently working on a change to add the storage version in the checkpoint 
file and making a storage version check as part of initializing the 
TransactionSubsystem. This will prevent any storage data from begin touched in 
case of version mismatch when an instance is restarted.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Yeah, Till and I discussed about this a little yesterday off the review, that 
was my thought as well, that even though the log would be viewed as basically 
not there (e.g. someone had deleted them), and it'd try to recover, eventually 
the wrong version would come up.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

The list of existing transaction log files are read before any storage version 
checking is done (i.e. if you try to upgrade an existing instance with this, 
then the existing log file(s) won't be found and a new log file with id 0 will 
be created). Right after that however, a version mismatch will be detected when 
the existing resources are read to send the maximum resource id to CC.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

I think/hope, that the storage version would be checked before we read the 
transaction log. However, that might not be true for the root_metadata ... do 
you know of the top of your head?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3: Code-Review+2

It seems fine to me assuming the IT failure is just a flaky test. I think 
changing the storage version probably isnt enough to assure weird stuff wont 
happen if you try to upgrade with this, but as long as we're all aware of it, 
it isn't a big deal I don't think.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1259/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1259/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1368/3/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java:

Line 27: // possible corruption from old versions reading new formats.
> Why not public static final anymore?
Because a constant on an interface is by default public static final.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1254/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1254/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1253/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1253/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3458/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1250/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 2: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1242/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1242/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3445/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1224/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1711: rename asterix_transaction_log

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1711: rename asterix_transaction_log
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1368
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieed464a1993a6bbff798e18e4c94245755a447eb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No