Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-26 Thread Xikui Wang (Code Review) 
Xikui Wang has submitted this change and it was merged.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Fix NULL/MISSING field value handing in Java UDF

Add NULL/MISSING value support in Java UDF. This fixed the NPE when there
is a NULL/MISSING field in a record.

Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1695
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
3 files changed, 66 insertions(+), 1 deletion(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
index e2ed092..fb9fd79 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
@@ -19,6 +19,7 @@
 package org.apache.asterix.external.library;
 
 import org.apache.asterix.external.api.IJObject;
+import org.apache.asterix.external.library.java.JObjects;
 import org.apache.asterix.external.library.java.JObjects.JBoolean;
 import org.apache.asterix.external.library.java.JObjects.JCircle;
 import org.apache.asterix.external.library.java.JObjects.JDate;
@@ -45,6 +46,7 @@
 import org.apache.asterix.om.types.AUnorderedListType;
 import org.apache.asterix.om.types.IAType;
 import org.apache.asterix.om.util.container.IObjectFactory;
+
 
 public class JTypeObjectFactory implements IObjectFactory {
 
@@ -108,6 +110,12 @@
 case INT64:
 retValue = new JLong(0);
 break;
+case NULL:
+retValue = JObjects.JNull.INSTANCE;
+break;
+case MISSING:
+retValue = JObjects.JMissing.INSTANCE;
+break;
 case ORDEREDLIST:
 AOrderedListType ot = (AOrderedListType) type;
 IAType orderedItemType = ot.getItemType();
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
index f8755b4..a35bc69 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
@@ -140,6 +140,12 @@
 case DURATION:
 accessor = new JDurationAccessor();
 break;
+case NULL:
+accessor = new JNullAccessor();
+break;
+case MISSING:
+accessor = new JMissingAccessor();
+break;
 default:
 break;
 }
@@ -189,6 +195,26 @@
 }
 }
 
+public static class JNullAccessor implements IJObjectAccessor {
+
+@Override
+public IJObject access(IVisitablePointable pointable, 
IObjectPool objPool)
+throws HyracksDataException {
+IJObject jObject = objPool.allocate(BuiltinType.ANULL);
+return jObject;
+}
+}
+
+public static class JMissingAccessor implements  IJObjectAccessor {
+
+@Override
+public IJObject access(IVisitablePointable pointable, 
IObjectPool objPool)
+throws HyracksDataException {
+IJObject jObject = objPool.allocate(BuiltinType.AMISSING);
+return jObject;
+}
+}
+
 public static class JInt64Accessor implements IJObjectAccessor {
 
 @Override
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
index 78b14e7..859a327 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
+++

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Yingyi Bu (Code Review) 
Yingyi Bu has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2606/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1058/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1058/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/236/ 
(6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2601/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3621/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/157/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5098/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/414/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2601/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/230/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Xikui Wang (Code Review) 
Hello Ian Maxon, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1695

to look at the new patch set (#4).

Change subject: Fix NULL/MISSING field value handing in Java UDF
..

Fix NULL/MISSING field value handing in Java UDF

Add NULL/MISSING value support in Java UDF. This fixed the NPE when there
is a NULL/MISSING field in a record.

Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
3 files changed, 66 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/1695/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/232/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/156/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-25 Thread Yingyi Bu (Code Review) 
Yingyi Bu has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1695/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java:

PS3, Line 160: 
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2596/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/146/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2596/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/227/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/225/
 (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5093/ (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Fix NULL/MISSING field value handing in Java UDF
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3616/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix NULL/MISSING field value handing in Java UDF

2017-04-24 Thread Xikui Wang (Code Review) 
Hello Ian Maxon, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1695

to look at the new patch set (#3).

Change subject: Fix NULL/MISSING field value handing in Java UDF
..

Fix NULL/MISSING field value handing in Java UDF

Add NULL/MISSING value support in Java UDF. This fixed the NPE when there
is a NULL/MISSING field in a record.

Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjects.java
3 files changed, 65 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/1695/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1695
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi