subject:"Change in asterixdb\[master\]\: Supports Left Outer Join and Left Outer Unnest in SQL\+\+."

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has submitted this change and it was merged.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/899
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 13:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1582/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#13).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Yingyi Bu has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

(16 comments)

https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java:

Line 99: IOptimizationContext context) throws AlgebricksException {
> Remove template params in this method?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:

Line 246:  * @param toPush
> update comment?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

Line 425: new 
MutableObject(makeUnnestExpression(eo.first)), pVar,
> remove the template parameter?
Done


Line 481: throw new IllegalStateException(ERR_MSG);
> Should this just be an UnsupportedOperationException? Do we have a "usual" 
Done


Line 487: throw new IllegalStateException(ERR_MSG);
> Should this just be an UnsupportedOperationException?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java:

Line 329: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(recordType);
> rename this variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:

Line 358: "Field: " + 
recType.getFieldNames()[optionalFieldId] + " can not be null");
> s/null/optional/?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 112: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(this.recordType);
> rename variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java:

Line 191: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(inputRecType);
> rename variable?
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 111: missingTypeTag.set(bos.getByteArray(), start, end - 
start);
> What's the difference between missingReference and missingTypeTag? 
Done


Line 142: } catch (AsterixException e) {
> This seems to be the only place where we use TypeException. Could we remove
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java:

Line 159: 
> s/getExpendedOffset/getExpandedOffset/
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java:

Line 81: 
.deserialize(nextFieldValue.getByteArray()[nextFieldValue.getStartOffset()]);
> Would it make sense to re-use this typeTag for the next iteration (and get 
Done


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 337: } else {
> Should we just remove this else and fall through to the default case (addin
Done

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Till Westmann (Code Review)

Till Westmann has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

(16 comments)

Looks great, just a few minor comments.

https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java:

Line 99: IOptimizationContext context) throws AlgebricksException {
Remove template params in this method?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:

Line 246:  * @param toPush
update comment?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

Line 425: new 
MutableObject(makeUnnestExpression(eo.first)), pVar,
remove the template parameter?


Line 481: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException? Do we have a "usual" way 
to choose these?


Line 487: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java:

Line 329: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(recordType);
rename this variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:

Line 358: "Field: " + 
recType.getFieldNames()[optionalFieldId] + " can not be null");
s/null/optional/?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 112: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(this.recordType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java:

Line 191: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(inputRecType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 111: missingTypeTag.set(bos.getByteArray(), start, end - 
start);
What's the difference between missingReference and missingTypeTag? 

Also, shouldn't we always write using writeByte (which is unsynchronized)?


Line 142: } catch (AsterixException e) {
This seems to be the only place where we use TypeException. Could we remove it?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java:

Line 159: 
s/getExpendedOffset/getExpandedOffset/


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java:

Line 81: 
.deserialize(nextFieldValue.getByteArray()[nextFieldValue.getStartOffset()]);
Would it make sense to re-use this typeTag for the next iteration (and get the 
first type tag before the loop?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 337: } else {
Should we just remove this else and fall through to the default case (adding a

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1576/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1575/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#11).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#10).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#9).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#8).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1569/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1568/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-03 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#7).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue562.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1565/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#6).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveLeftOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.3.query.aql
D

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1563/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#4).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/float_null/float_null.1.ddl.aql
R

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1562/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1559/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#3).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- support roundtrips of MISSING valued closed fields for load and insert;
- suppress fields with MISSING values in result printer;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/float_null/float_null.1.ddl.aql
R

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1556/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/899
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

2016-06-02 Thread Yingyi Bu (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/899

to look at the new patch set (#2).

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..

Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;
- suppress fields with MISSING values in result printer;
- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveOuterUnnestForLeftOuterJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-1/dataset_with_meta-1.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-2/dataset_with_meta-2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/transaction/verify_failure_previous_success/verify_failure_previous_success.1.adm
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-core.sqlpp
C asterixdb/asterix-app/src/test/resources/optimizerts/queries/loj-sugar.sqlpp
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-core.plan
A asterixdb/asterix-app/src/test/resources/optimizerts/results/loj-sugar.plan
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/binary_null/binary_null.3.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.ddl.aql
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.1.query.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/double_null/double_null.2.update.aql
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/comparison/float_null/float_null.1.ddl.aql
R

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

31 matches

Site Navigation

Mail list logo

Footer information