Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6231/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3061/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3061/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/6FHRNj : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/u6qkz9 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/o4bhMJ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6231/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8819/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4070/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3344/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3356/
 (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1363/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3315/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3808/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3787/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Ian Maxon (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2590

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..

[ASTERIXDB-2363][EXT] Fix quoted delimiter handling

The handling of quotes is still not correct as we
do not handle quotes being escaped themselves by
quotes (e.g.  should produce "") but it is
a start.

Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
---
A asterixdb/asterix-app/data/csv/csv_escaped_delimiter.csv
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/load/csv_escaped_delimiter/csv_escaped_delimiter.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java
7 files changed, 111 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/90/2590/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3887/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3571/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7301/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3268/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/hArFFN : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6230/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1362/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8818/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3786/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3886/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3570/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3314/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3355/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3267/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3807/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7300/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4069/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3343/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2590
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-0.9.4-pre-rc
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling

2018-04-12 Thread Ian Maxon (Code Review)
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2590

Change subject: [ASTERIXDB-2363][EXT] Fix quoted delimiter handling
..

[ASTERIXDB-2363][EXT] Fix quoted delimiter handling

Change-Id: I1fd4435702041a2c857cdf2c3fe95f999aa6720a
---
A asterixdb/asterix-app/data/csv/csv_escaped_delimiter.csv
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/load/csv_escaped_delimiter/csv_escaped_delimiter.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java
7 files changed, 110 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/90/2590/1

diff --git a/asterixdb/asterix-app/data/csv/csv_escaped_delimiter.csv 
b/asterixdb/asterix-app/data/csv/csv_escaped_delimiter.csv
new file mode 100644
index 000..3341f6f
--- /dev/null
+++ b/asterixdb/asterix-app/data/csv/csv_escaped_delimiter.csv
@@ -0,0 +1 @@
+1,",",",  1a","",""
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.1.ddl.sqlpp
new file mode 100644
index 000..2fc9b63
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.1.ddl.sqlpp
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/**
+ *
+ * CSV file loading test
+ * Expected result: success
+ *
+ */
+
+drop  dataverse temp if exists;
+create  dataverse temp;
+
+use temp;
+
+
+create type temp.test as
+ closed {
+  id : bigint,
+  string : string,
+  string2: string,
+  string3: string
+};
+
+create  dataset testds(test) primary key id;
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.2.update.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.2.update.sqlpp
new file mode 100644
index 000..2a2093b
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.2.update.sqlpp
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/**
+ *
+ * CSV file loading test
+ * Expected result: success
+ *
+ */
+
+use temp;
+
+
+load  dataset testds using localfs (
+(`path`=`asterix_nc1://data/csv/csv_escaped_delimiter.csv`),
+(`format`=`delimited-text`),(`delimiter`=`,`));
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/load/csv_escaped_delimiter/csv_escaped_delimiter.3.query.sqlpp