Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets

2023-12-05 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Wail Alkowaileet.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests-redux/1690/
 : 1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Wed, 06 Dec 2023 04:48:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets

2023-12-05 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Wail Alkowaileet.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests-redux/1690/


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Wed, 06 Dec 2023 03:54:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets

2023-12-05 Thread AsterixDB Code Review
Attention is currently required from: Wail Alkowaileet.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets
..


Patch Set 2: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/1UKZ8XNnLfVt4f5S9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Wed, 06 Dec 2023 03:47:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets

2023-12-05 Thread AsterixDB Code Review
>From Wail Alkowaileet :

Attention is currently required from: Wail Alkowaileet.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998

to look at the new patch set (#2).

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products of external datasets
..

[ASTERIXDB-3328][COMP] Preserve x-products of external datasets

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Cross-products of external datasets are eliminated
(incorrectly) by the compiler

Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/external-cross-product.sqlpp
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/external-cross-product.plan
3 files changed, 104 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/17998/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 2
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-MessageType: newpatchset


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets

2023-12-05 Thread AsterixDB Code Review
Attention is currently required from: Wail Alkowaileet.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/C4qomsrkHsqmNmSR9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Wail Alkowaileet 
Gerrit-Comment-Date: Tue, 05 Dec 2023 23:28:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets

2023-12-05 Thread AsterixDB Code Review
>From Jenkins :

Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests-redux/1688/
 : 1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Tue, 05 Dec 2023 23:13:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[trinity]: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets

2023-12-05 Thread AsterixDB Code Review
>From Jenkins :

Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998 )

Change subject: [ASTERIXDB-3328][COMP] Preserve x-products in external datasets
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests-redux/1688/


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17998
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I75fa9893a58daddb84c82bcb4b02e3cebc03e67b
Gerrit-Change-Number: 17998
Gerrit-PatchSet: 1
Gerrit-Owner: Wail Alkowaileet 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Tue, 05 Dec 2023 22:14:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment