[GitHub] ccodin commented on issue #77: Add the typescript definitions into nano repo

2018-03-02 Thread GitBox
ccodin commented on issue #77: Add the typescript definitions into nano repo URL: https://github.com/apache/couchdb-nano/issues/77#issuecomment-369961727 Hi, I'm not a major contributor (1 commit haha...) but i think it could be very useful. Indeed some of the definitions

[GitHub] wohali opened a new pull request #1194: Eliminate "default" Erlang platform from Jenkins CI

2018-03-02 Thread GitBox
wohali opened a new pull request #1194: Eliminate "default" Erlang platform from Jenkins CI URL: https://github.com/apache/couchdb/pull/1194 Currently, we run Jenkins CI builds on 11 platforms: Erlang 18.3 + [centos6|centos7|debian8|debian9|ubuntu1404|ubuntu1604] "Default"

[Jenkins] SUCCESS: CouchDB » jenkins-faster #1

2018-03-02 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/jenkins-faster/1/

[GitHub] davisp commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade

2018-03-02 Thread GitBox
davisp commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade URL: https://github.com/apache/couchdb/pull/1186#issuecomment-370007393 However that seems like it'd get awfully complicated quite quickly. Am trying to avoid having a large impact on clusters that have lots of

[GitHub] davisp commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade

2018-03-02 Thread GitBox
davisp commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade URL: https://github.com/apache/couchdb/pull/1186#issuecomment-370007031 Yeah, but this is also gonna play badly with internal replication which will also try pushing and pulling those things across. Also trying to

[GitHub] flimzy commented on a change in pull request #252: Suggested edit to make clear what a quorum actually represents.

2018-03-02 Thread GitBox
flimzy commented on a change in pull request #252: Suggested edit to make clear what a quorum actually represents. URL: https://github.com/apache/couchdb-documentation/pull/252#discussion_r171891485 ## File path: src/cluster/theory.rst ## @@ -34,10 +34,17 @@ thereby

[GitHub] wohali commented on issue #1194: Eliminate "default" Erlang platform from Jenkins CI

2018-03-02 Thread GitBox
wohali commented on issue #1194: Eliminate "default" Erlang platform from Jenkins CI URL: https://github.com/apache/couchdb/pull/1194#issuecomment-369983259 For reference, Jenkins is running this branch's PR here:

[GitHub] AlexanderKaraberov opened a new pull request #1195: Add support for bulk get with Accept Content Type: "multipart/mixed", "multipart/related"

2018-03-02 Thread GitBox
AlexanderKaraberov opened a new pull request #1195: Add support for bulk get with Accept Content Type: "multipart/mixed", "multipart/related" URL: https://github.com/apache/couchdb/pull/1195 ## Overview CouchDB currently has support for `_bulk_get` requests which are intended to

[GitHub] wohali opened a new issue #1197: Travis failure: users_db.js

2018-03-02 Thread GitBox
wohali opened a new issue #1197: Travis failure: users_db.js URL: https://github.com/apache/couchdb/issues/1197 Another random failure on Travis: ``` test/javascript/tests/users_db.js Error: The database could not be created, the file already

[GitHub] wohali opened a new issue #1196: Travis failure: design_docs.js

2018-03-02 Thread GitBox
wohali opened a new issue #1196: Travis failure: design_docs.js URL: https://github.com/apache/couchdb/issues/1196 I'm back, filing test failure tickets that I see from Travis/Jenkins in anticipation of a 2.2.0 release soon. /cc @jiangphcn From

[Jenkins] SUCCESS: CouchDB » master #198

2018-03-02 Thread Apache Jenkins Server
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/198/

[GitHub] wohali closed pull request #1194: Eliminate "default" Erlang platform from Jenkins CI

2018-03-02 Thread GitBox
wohali closed pull request #1194: Eliminate "default" Erlang platform from Jenkins CI URL: https://github.com/apache/couchdb/pull/1194 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] chewbranca commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986)

2018-03-02 Thread GitBox
chewbranca commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199#discussion_r171996206 ## File path: src/couch/src/couch_httpd_misc_handlers.erl ## @@ -61,22 +61,8 @@

[GitHub] wohali commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986)

2018-03-02 Thread GitBox
wohali commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199#discussion_r171994570 ## File path: src/couch/src/couch_httpd_misc_handlers.erl ## @@ -61,22 +61,8 @@

[GitHub] wohali opened a new pull request #1199: Prevent access to Fauxton on node-local port (5986)

2018-03-02 Thread GitBox
wohali opened a new pull request #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199 Will help stop people shooting themselves in the foot and/or using node-local CouchDB as their "main" CouchDB port. I'll file a separate

[GitHub] wohali opened a new issue #1198: Fauxton should not be available on port 5986

2018-03-02 Thread GitBox
wohali opened a new issue #1198: Fauxton should not be available on port 5986 URL: https://github.com/apache/couchdb/issues/1198 People mistakenly stumble across Fauxton on port 5986 and think that this is "where CouchDB is." I've seen it multiple times on IRC, and professionally, where

[GitHub] chewbranca commented on issue #1199: Prevent access to Fauxton on node-local port (5986)

2018-03-02 Thread GitBox
chewbranca commented on issue #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199#issuecomment-370097873 +0.5 from me (after the WS nit). The approach seems fine, but I don't have strong enough opinions on removal of Fauxton from

[GitHub] wohali commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986)

2018-03-02 Thread GitBox
wohali commented on a change in pull request #1199: Prevent access to Fauxton on node-local port (5986) URL: https://github.com/apache/couchdb/pull/1199#discussion_r171994570 ## File path: src/couch/src/couch_httpd_misc_handlers.erl ## @@ -61,22 +61,8 @@

[GitHub] vitaly-goot commented on issue #1010: Compaction of a heavily updated view - file descriptor leak (known as ".deleted" issue)

2018-03-02 Thread GitBox
vitaly-goot commented on issue #1010: Compaction of a heavily updated view - file descriptor leak (known as ".deleted" issue) URL: https://github.com/apache/couchdb/issues/1010#issuecomment-370106652 Having a similar issue on CouchDB-1.6.x Here are some additional debugging info, if

[GitHub] wohali commented on issue #1010: Compaction of a heavily updated view - file descriptor leak (known as ".deleted" issue)

2018-03-02 Thread GitBox
wohali commented on issue #1010: Compaction of a heavily updated view - file descriptor leak (known as ".deleted" issue) URL: https://github.com/apache/couchdb/issues/1010#issuecomment-370115818 Is anyone seeing this in 2.x? 1.x is on sustaining support at this point - we will only

[GitHub] rnewson commented on issue #1192: Fix dialyzer warning on `couch_key_tree:merge/2`

2018-03-02 Thread GitBox
rnewson commented on issue #1192: Fix dialyzer warning on `couch_key_tree:merge/2` URL: https://github.com/apache/couchdb/pull/1192#issuecomment-369940332 +1 This is an automated message from the Apache Git Service. To

[GitHub] rnewson commented on issue #1176: Implement pluggable authentication and session support for replicator

2018-03-02 Thread GitBox
rnewson commented on issue #1176: Implement pluggable authentication and session support for replicator URL: https://github.com/apache/couchdb/pull/1176#issuecomment-369880364 ok, figured out my mistake. It does acquire cookies. I'll finish the code review itself today.

[GitHub] jiangphcn commented on a change in pull request #1186: [WIP] Clustered purge mixed cluster upgrade

2018-03-02 Thread GitBox
jiangphcn commented on a change in pull request #1186: [WIP] Clustered purge mixed cluster upgrade URL: https://github.com/apache/couchdb/pull/1186#discussion_r171856181 ## File path: src/couch/src/couch_bt_engine.erl ## @@ -759,6 +777,45 @@

[GitHub] jiangphcn commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade

2018-03-02 Thread GitBox
jiangphcn commented on issue #1186: [WIP] Clustered purge mixed cluster upgrade URL: https://github.com/apache/couchdb/pull/1186#issuecomment-369931784 Thanks @davisp for pointing out about possibility of index being rebuilt. It looks to me that it is good idea of not upgrading the purge

[GitHub] janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error

2018-03-02 Thread GitBox
janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error URL: https://github.com/apache/couchdb/issues/745#issuecomment-369913191 Shorter repro that runs quickly, tests the 1 attachment > `max_http_request_size` as well as the 2 attachments

[GitHub] janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error

2018-03-02 Thread GitBox
janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error URL: https://github.com/apache/couchdb/issues/745#issuecomment-369905803 Great repro Joan. I played with it and came up with this: The python script uses the standalone

[GitHub] janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error

2018-03-02 Thread GitBox
janl commented on issue #745: Replication with attachments never completes, {mp_parser_died,noproc} error URL: https://github.com/apache/couchdb/issues/745#issuecomment-369913191 Shorter repro that runs quickly, tests the 1 attachment > `max_http_request_size` as well as the 2 attachments

[GitHub] iilyak opened a new pull request #1193: Use `chttpd:send_error/2` in mango_httpd

2018-03-02 Thread GitBox
iilyak opened a new pull request #1193: Use `chttpd:send_error/2` in mango_httpd URL: https://github.com/apache/couchdb/pull/1193 ## Overview We used to call non exported function chttpd:send_error/6. Switch to public `chttpd:send_error/2` for sending error. ## Testing

[GitHub] eiri commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd

2018-03-02 Thread GitBox
eiri commented on issue #1193: Use `chttpd:send_error/2` in mango_httpd URL: https://github.com/apache/couchdb/pull/1193#issuecomment-369954361 Using `chttpd:send_error/4` seems to be closer to the original intent? It's public func as well.