wohali closed pull request #1726: Support elixir 1.7
URL: https://github.com/apache/couchdb/pull/1726
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/22
thanks @wohali for your tips. Just merged :-)
---
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-config/pull/22
---
wohali closed pull request #1731: [win32] Fix dev/run and Makefile for test
suite
URL: https://github.com/apache/couchdb/pull/1731
This is an automated message from the Apache Git Service.
To respond to the message, please
wohali closed issue #1633: Fix dev/run under Windows
URL: https://github.com/apache/couchdb/issues/1633
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
Github user jiangphcn commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/21#discussion_r232871856
--- Diff: src/config.erl ---
@@ -253,34 +253,45 @@ handle_call({set, Sec, Key, Val, Persist, Reason},
_From, Config) ->
true =
Github user jiangphcn commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/21#discussion_r232872036
--- Diff: src/config.erl ---
@@ -253,34 +253,45 @@ handle_call({set, Sec, Key, Val, Persist, Reason},
_From, Config) ->
true =
Github user jiangphcn commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/21#discussion_r232872320
--- Diff: test/config_tests.erl ---
@@ -299,6 +299,45 @@ config_notifier_behaviour_test_() ->
}.
Github user jiangphcn commented on a diff in the pull request:
https://github.com/apache/couchdb-config/pull/21#discussion_r232872123
--- Diff: src/config.erl ---
@@ -253,34 +253,45 @@ handle_call({set, Sec, Key, Val, Persist, Reason},
_From, Config) ->
true =
Github user wohali commented on the issue:
https://github.com/apache/couchdb-config/pull/22
@jiangphcn you know how to merge this yourself, right? You have a committer
bit, you can do this yourself.
```
cd ~/workdir
git clone
wohali opened a new pull request #1731: [win32] Fix dev/run and Makefile for
test suite
URL: https://github.com/apache/couchdb/pull/1731
## Overview
* Fixes #1633 by:
* updating the `boot_node.erl` script with a PPid test that actually works
(`dev/run` never worked on
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/396/
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/21
I will merge this PR if there is no additional comments. @wohali
---
tonysun83 commented on a change in pull request #1718: Perform explicit
$exists:false on Index validation
URL: https://github.com/apache/couchdb/pull/1718#discussion_r232851798
##
File path: src/mango/src/mango_selector.erl
##
@@ -608,35 +607,42 @@
tonysun83 commented on issue #1718: Perform explicit $exists:false on Index
validation
URL: https://github.com/apache/couchdb/pull/1718#issuecomment-438077577
+1 after some of the formatting issues.
This is an automated
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/397/
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/21
CI is happy now :-)
---
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/21
@wohali yes, just doing this with @wenli200133 and rebased the change on #22
---
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/21
+1 looks good from my side. CI should be fine when
https://github.com/apache/couchdb-config/pull/22 is merged.
@wohali, hey Joan, would you please help take a look?
---
Github user wohali commented on the issue:
https://github.com/apache/couchdb-config/pull/21
@jiangphcn you'll need to push a trivial commit to this branch to force
travis to re-run the test.
---
tonysun83 commented on a change in pull request #1718: Perform explicit
$exists:false on Index validation
URL: https://github.com/apache/couchdb/pull/1718#discussion_r232852111
##
File path: src/mango/src/mango_selector.erl
##
@@ -667,6 +673,53 @@
wohali opened a new issue #1730: Elixir test suite fails to run on Windows
URL: https://github.com/apache/couchdb/issues/1730
Currently:
```cmd
C:\relax\couchdb\test\elixir>mix test
===> Compiling jiffy
'.' is not recognized as an internal or external command,
operable
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232581368
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232620377
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -997,6
wohali opened a new issue #1732: 2 minor Mango test failures on Windows only
URL: https://github.com/apache/couchdb/issues/1732
@tonysun83 @garrensmith any ideas on this one?
I've finally got the Mango test suite running on Windows. Here is the
current output:
```
wohali commented on issue #1732: 2 minor Mango test failures on Windows only
URL: https://github.com/apache/couchdb/issues/1732#issuecomment-438157349
@willholley Garren mentioned you might have an idea here as well?
This is
wohali opened a new pull request #1733: Improve Mango test suite harness, add
Windows compat
URL: https://github.com/apache/couchdb/pull/1733
## Overview
Mango's test harness was a non-portable shell script. This uses the inbuilt
`dev/run` ability to run another script once the
Github user jiangphcn commented on the issue:
https://github.com/apache/couchdb-config/pull/21
@wohali thanks for your help on process. Just merged
---
[
https://issues.apache.org/jira/browse/COUCHDB-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684798#comment-16684798
]
ASF subversion and git services commented on COUCHDB-1380:
--
Commit
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-config/pull/21
---
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232620377
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -997,6
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232638898
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232632644
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232660021
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -997,6
user357x commented on issue #19: Snap package error for CouchDB 2.1.1
URL: https://github.com/apache/couchdb-pkg/issues/19#issuecomment-437866374
couchdb - don't relax!
This is an automated message from the Apache Git
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232638898
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232632644
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232581368
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232632644
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232638898
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
Github user wohali commented on the issue:
https://github.com/apache/couchdb-config/pull/21
You're the one who gave it a +1 @jiangphcn ;) I'm not reviewing the code
here, just helping you with the process!
---
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
nickva commented on a change in pull request #1195: Add support for bulk get
with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232722844
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18 +482,62 @@
mariocasciaro opened a new issue #1729: Different nodes in the cluster have
different number of shard files with q=1 and n=3
URL: https://github.com/apache/couchdb/issues/1729
I'm not sure if this is an actual issue or not.
I have a cluster with q=1 and n=3. If my understanding of how a
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
user357x removed a comment on issue #19: Snap package error for CouchDB 2.1.1
URL: https://github.com/apache/couchdb-pkg/issues/19#issuecomment-437866374
couchdb - don't relax!
This is an automated message from the Apache Git
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232638898
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232632644
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
eiri commented on issue #1704: Test suite `delayed_commits.js` unreliable.
URL: https://github.com/apache/couchdb/issues/1704#issuecomment-437930612
So, this turned out not to be about `delayed_commits` tests, but a some kind
of a race in a server restart code introduced in #1543. I
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
AlexanderKaraberov commented on a change in pull request #1195: Add support for
bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232695625
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/395/
jaydoane commented on a change in pull request #1682: Feature flags
URL: https://github.com/apache/couchdb/pull/1682#discussion_r232079044
##
File path: src/couch/src/couch_flags.erl
##
@@ -0,0 +1,108 @@
+% Licensed under the Apache License, Version 2.0 (the "License");
jaydoane commented on a change in pull request #1682: Feature flags
URL: https://github.com/apache/couchdb/pull/1682#discussion_r232079858
##
File path: src/couch/src/couch_flags.erl
##
@@ -0,0 +1,108 @@
+% Licensed under the Apache License, Version 2.0 (the "License");
ufobat commented on issue #346: _replicate vs _replication API endpoints
URL:
https://github.com/apache/couchdb-documentation/issues/346#issuecomment-438004826
I am not sure if and where i should mention the `_design/_replicator`
document. any idea?
wohali commented on issue #1633: Fix Erlang test suite under Windows
URL: https://github.com/apache/couchdb/issues/1633#issuecomment-437962188
The good news is: the Erlang test suite now passes under Windows with no
problems.
The bad news is: `make javascript` is now broken because
nickva commented on issue #1195: Add support for bulk get with
Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437964133
@AlexanderKaraberov
+1
Thank you for your contribution and for your patience when reviewing
janl commented on issue #1470: Fix calculation of external size for attachments
URL: https://github.com/apache/couchdb/pull/1470#issuecomment-437942605
@davisp *ping* :)
This is an automated message from the Apache Git
nickva commented on a change in pull request #1195: Add support for bulk get
with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232722844
##
File path: src/chttpd/src/chttpd_db.erl
##
@@ -481,18 +482,62 @@
nickva closed pull request #1727: Remove eliminated config options from elixir
tests
URL: https://github.com/apache/couchdb/pull/1727
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
ufobat opened a new pull request #349: More information about replication.
Fixes #346
URL: https://github.com/apache/couchdb-documentation/pull/349
## Overview
I hope to clear some things that confused me while learning about
replication. I did not cover documents like
63 matches
Mail list logo
