[GitHub] [couchdb] YetAnotherEye commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie

2020-03-24 Thread GitBox
YetAnotherEye commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie URL: https://github.com/apache/couchdb/pull/2452#issuecomment-603116629 Hi there, would you consider to also add secure = true to the cookies? I'm still getting `A cookie associated wit

[GitHub] [couchdb] rnewson commented on a change in pull request #2694: Add support for roles to be obtained from JWTs.

2020-03-24 Thread GitBox
rnewson commented on a change in pull request #2694: Add support for roles to be obtained from JWTs. URL: https://github.com/apache/couchdb/pull/2694#discussion_r397028323 ## File path: test/elixir/test/jwtauth_test.exs ## @@ -103,13 +103,14 @@ defmodule JwtAuthTest do

[GitHub] [couchdb] rnewson commented on issue #2694: Add support for roles to be obtained from JWTs.

2020-03-24 Thread GitBox
rnewson commented on issue #2694: Add support for roles to be obtained from JWTs. URL: https://github.com/apache/couchdb/pull/2694#issuecomment-603141670 @atrauzzi one tiny change to make and then please rebase and squash this so I can merge. And thanks! --

[GitHub] [couchdb] YetAnotherEye edited a comment on issue #2452: Update Mochiweb and add SameSite support to auth cookie

2020-03-24 Thread GitBox
YetAnotherEye edited a comment on issue #2452: Update Mochiweb and add SameSite support to auth cookie URL: https://github.com/apache/couchdb/pull/2452#issuecomment-603116629 Hi there, would you consider to also add secure = true to the cookies? I'm still getting `A cookie associa

[GitHub] [couchdb] jiangphcn commented on issue #2666: soft-deletion for database

2020-03-24 Thread GitBox
jiangphcn commented on issue #2666: soft-deletion for database URL: https://github.com/apache/couchdb/pull/2666#issuecomment-603193963 thanks Paul @davisp for your review and comments. Could you please check 3d53721 I tried to use to address your comments? -

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397097530 ## File path: src/couch_views/src/couch_views.erl ## @@ -53,11 +54,15 @@ query(Db, DDoc, ViewName, Callback, Acc0,

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397103894 ## File path: src/mango/test/README.md ## @@ -22,8 +22,13 @@ Test configuration The following environment variab

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397104095 ## File path: src/mango/test/19-find-conflicts.py ## @@ -25,9 +26,25 @@ def setUp(self): self.db.save_docs

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397177970 ## File path: src/couch_views/test/couch_views_updater_test.erl ## @@ -0,0 +1,195 @@ +% Licensed under the Apache L

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397177990 ## File path: src/mango/src/mango_idx.erl ## @@ -484,12 +375,12 @@ get_legacy_selector(Def) -> index(SelectorName,

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178137 ## File path: src/mango/src/mango_idx_special.erl ## @@ -27,7 +27,9 @@ -include_lib("couch/include/couch_db.hr

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178057 ## File path: src/mango/src/mango_fabric2_plugin.erl ## @@ -0,0 +1,23 @@ +% Licensed under the Apache License, Vers

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178618 ## File path: src/couch_views/src/couch_views_updater.erl ## @@ -0,0 +1,83 @@ +% Licensed under the Apache License,

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178576 ## File path: src/couch_views/src/couch_views_updater.erl ## @@ -0,0 +1,83 @@ +% Licensed under the Apache License,

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178865 ## File path: src/couch_views/src/couch_views_indexer.erl ## @@ -236,21 +254,30 @@ process_changes(Change, Acc) ->

[GitHub] [couchdb] garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB

2020-03-24 Thread GitBox
garrensmith commented on a change in pull request #2585: Mango Indexes on FoundationDB URL: https://github.com/apache/couchdb/pull/2585#discussion_r397178932 ## File path: src/couch_views/src/couch_views_indexer.erl ## @@ -210,6 +206,26 @@ update(#{} = Db, Mrst0, State0) -

[GitHub] [couchdb] natcohen opened a new issue #2713: Nightly/weekly build for small fixes

2020-03-24 Thread GitBox
natcohen opened a new issue #2713: Nightly/weekly build for small fixes URL: https://github.com/apache/couchdb/issues/2713 I have a bug that blocks me from using CouchDB 3.0.0. This bug was fixed but I can't have the fixed version... is there a way to get a nightly/weekly build? --

[GitHub] [couchdb] dottorblaster commented on issue #2713: Nightly/weekly build for small fixes

2020-03-24 Thread GitBox
dottorblaster commented on issue #2713: Nightly/weekly build for small fixes URL: https://github.com/apache/couchdb/issues/2713#issuecomment-603299388 Hi! I don't know the actual schedule but we're backporting our fixes to a `3.0.x` branch that we will use for CouchDB 3.0.1 too. So, I don't

[GitHub] [couchdb] natcohen commented on issue #2713: Nightly/weekly build for small fixes

2020-03-24 Thread GitBox
natcohen commented on issue #2713: Nightly/weekly build for small fixes URL: https://github.com/apache/couchdb/issues/2713#issuecomment-603307561 Sounds good! This is an automated message from the Apache Git Service. To respon

[GitHub] [couchdb] natcohen closed issue #2713: Nightly/weekly build for small fixes

2020-03-24 Thread GitBox
natcohen closed issue #2713: Nightly/weekly build for small fixes URL: https://github.com/apache/couchdb/issues/2713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [couchdb] janl commented on issue #2705: CouchDB v. 3.0.0 cannot create admin on macOS Catalina 10.15.3

2020-03-24 Thread GitBox
janl commented on issue #2705: CouchDB v. 3.0.0 cannot create admin on macOS Catalina 10.15.3 URL: https://github.com/apache/couchdb/issues/2705#issuecomment-603351826 Thanks for reporting back! This is an automated message f

[GitHub] [couchdb-fauxton] garrensmith commented on issue #1253: The banners are too damn slow ! :)

2020-03-24 Thread GitBox
garrensmith commented on issue #1253: The banners are too damn slow ! :) URL: https://github.com/apache/couchdb-fauxton/issues/1253#issuecomment-603384699 All the notification code is here https://github.com/apache/couchdb-fauxton/tree/master/app/addons/fauxton/notifications Take a

[GitHub] [couchdb] rnewson merged pull request #2694: Add support for roles to be obtained from JWTs.

2020-03-24 Thread GitBox
rnewson merged pull request #2694: Add support for roles to be obtained from JWTs. URL: https://github.com/apache/couchdb/pull/2694 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [couchdb] CharaLagou closed issue #2705: CouchDB v. 3.0.0 cannot create admin on macOS Catalina 10.15.3

2020-03-24 Thread GitBox
CharaLagou closed issue #2705: CouchDB v. 3.0.0 cannot create admin on macOS Catalina 10.15.3 URL: https://github.com/apache/couchdb/issues/2705 This is an automated message from the Apache Git Service. To respond to the mes

[Jenkins] SUCCESS: CouchDB » Full Platform Builds » master #124

2020-03-24 Thread Apache Jenkins Server
Yay, we passed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/124/display/redirect

[GitHub] [couchdb] davisp merged pull request #2711: Implement fabric2_db:get_design_docs/1

2020-03-24 Thread GitBox
davisp merged pull request #2711: Implement fabric2_db:get_design_docs/1 URL: https://github.com/apache/couchdb/pull/2711 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [couchdb] wohali commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie

2020-03-24 Thread GitBox
wohali commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie URL: https://github.com/apache/couchdb/pull/2452#issuecomment-603426438 @YetAnotherEye Does setting SameSite to `lax` or `strict` not work for you? @willholley per https://web.dev/samesite-cooki

[GitHub] [couchdb] atrauzzi opened a new pull request #2714: Make the JWT roles claim more CouchDB specific

2020-03-24 Thread GitBox
atrauzzi opened a new pull request #2714: Make the JWT roles claim more CouchDB specific URL: https://github.com/apache/couchdb/pull/2714 Following some discussion about naming for the claim, it's been determined that it would be better to make it clear that this value is CouchDB specific.

[GitHub] [couchdb] rnewson merged pull request #2714: Make the JWT roles claim more CouchDB specific

2020-03-24 Thread GitBox
rnewson merged pull request #2714: Make the JWT roles claim more CouchDB specific URL: https://github.com/apache/couchdb/pull/2714 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [couchdb] nickva opened a new pull request #2715: Improve fabric2_events

2020-03-24 Thread GitBox
nickva opened a new pull request #2715: Improve fabric2_events URL: https://github.com/apache/couchdb/pull/2715 * Avoid a cause clause error in `after 0` when the database is deleted * Handle db re-creation by checking the instance UUID during `fabric2_db:open/2` Since we ad

[GitHub] [couchdb] jjrodrig commented on a change in pull request #2703: Port view_pagination integration test to elixir test suite

2020-03-24 Thread GitBox
jjrodrig commented on a change in pull request #2703: Port view_pagination integration test to elixir test suite URL: https://github.com/apache/couchdb/pull/2703#discussion_r397518759 ## File path: test/elixir/test/view_pagination_test.exs ## @@ -0,0 +1,189 @@ +defmodule V

[GitHub] [couchdb-fauxton] elChapoSing commented on issue #1253: The banners are too damn slow ! :)

2020-03-24 Thread GitBox
elChapoSing commented on issue #1253: The banners are too damn slow ! :) URL: https://github.com/apache/couchdb-fauxton/issues/1253#issuecomment-603587329 OK so if I'm not mistaken line 30 in Notification.js is where that value is stored. ``` static defaultProps = { type:

[GitHub] [couchdb-fauxton] elChapoSing opened a new pull request #1254: reduce showing time of the banners.

2020-03-24 Thread GitBox
elChapoSing opened a new pull request #1254: reduce showing time of the banners. URL: https://github.com/apache/couchdb-fauxton/pull/1254 ## GitHub issue number fixes #1253 ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [

[GitHub] [couchdb] YetAnotherEye commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie

2020-03-24 Thread GitBox
YetAnotherEye commented on issue #2452: Update Mochiweb and add SameSite support to auth cookie URL: https://github.com/apache/couchdb/pull/2452#issuecomment-603663113 @wohali Hi, no, it doesn't. I seem to be one of the lucky persons that got the incremental update early (Version 80.0.398

[GitHub] [couchdb] iilyak commented on issue #2662: Use `couch_rate` application for `couch_view`

2020-03-24 Thread GitBox
iilyak commented on issue #2662: Use `couch_rate` application for `couch_view` URL: https://github.com/apache/couchdb/pull/2662#issuecomment-603670793 @garrensmith The formatting issue should be fixed This is an automated mess

[GitHub] [couchdb] YetAnotherEye edited a comment on issue #2452: Update Mochiweb and add SameSite support to auth cookie

2020-03-24 Thread GitBox
YetAnotherEye edited a comment on issue #2452: Update Mochiweb and add SameSite support to auth cookie URL: https://github.com/apache/couchdb/pull/2452#issuecomment-603663113 @wohali Hi, no, it doesn't. I seem to be one of the lucky persons that got the incremental update early (Version 8