[GitHub] couchdb-couch pull request: Make sure authentication_db for cluste...

2015-06-26 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/62 Make sure authentication_db for clustered is considered as users db You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch

[GitHub] couchdb-couch pull request: Make sure authentication_db for cluste...

2015-06-26 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/62#issuecomment-115856279 The explanation is in a bug description https://issues.apache.org/jira/browse/COUCHDB-2731 --- If your project is set up for it, you can reply to this email

[GitHub] couchdb-couch pull request: Make sure authentication_db for cluste...

2015-06-26 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/62#issuecomment-115861833 Let's say we have following in default.ini ``` [chttpd_auth] authentication_db = myusers ``` This would mean that it will not match on [any

[GitHub] couchdb-couch pull request: 2635 systems dbs

2015-06-15 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-fabric pull request: Use couch_db:normalize_dbname

2015-06-15 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-fabric/pull/21 Use couch_db:normalize_dbname COUCHDB-2715 We would need this PR for COUCHDB-2635 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb-couch-mrview pull request: Add call to couch_index_plugin:...

2015-07-31 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/23 Add call to couch_index_plugin:index_update/4 This is one of the series of PRs to make couchdb plugable. I'll provide complete list of dependent PRs in https://github.com/apache/couchdb

[GitHub] couchdb-chttpd pull request: Epi hooks

2015-07-31 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/53 Epi hooks This is one of the series of PRs to make couchdb plugable. I'll provide complete list of dependent PRs in https://github.com/apache/couchdb-couch repository. You can merge

[GitHub] couchdb-couch pull request: Epi hooks

2015-08-05 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/81#discussion_r36309591 --- Diff: include/couch_db.hrl --- @@ -91,10 +91,27 @@ design_url_handlers, auth, default_fun, -url_handlers

[GitHub] couchdb-couch pull request: Epi hooks

2015-08-05 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/81#discussion_r36313029 --- Diff: src/couch_httpd_auth.erl --- @@ -346,10 +346,10 @@ handle_session_req(#httpd{method='GET', user_ctx=UserCtx}=Req, _AuthModule

[GitHub] couchdb-chttpd pull request: Epi hooks

2015-08-05 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/53#discussion_r36356756 --- Diff: src/chttpd_auth.erl --- @@ -12,15 +12,70 @@ -module(chttpd_auth). +-export([authenticate/2]). +-export([authorize/2

[GitHub] couchdb-chttpd pull request: Epi hooks

2015-08-11 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/53#discussion_r36744201 --- Diff: src/chttpd.erl --- @@ -195,30 +191,46 @@ handle_request_int(MochiReq) - Other - Other end, -HttpReq

[GitHub] couchdb-fabric pull request: Use `couch_db:validate_dbname/1`

2015-08-11 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-fabric/pull/24#issuecomment-130030969 @rnewson: The PR has been squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch pull request: Epi hooks

2015-08-10 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/81#issuecomment-129563435 @davisp: I fixed most of you comments. The one which is left is about the typo in a commit message. I'll fix it on squash. --- If your project is set up

[GitHub] couchdb-couch pull request: Implement rename_on_delete

2015-08-12 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/85 Implement rename_on_delete Sometimes it is usefull to keep deleted db files around. For backup reasons for example. This commit implements the feature. The feature is enabled

[GitHub] couchdb-couch pull request: Avoid arithmetic in `to_hex` function

2015-07-27 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/79 Avoid arithmetic in `to_hex` function You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch reimplement-to_hex

[GitHub] couchdb-couch-replicator pull request: Implement `couch_define_db`...

2015-07-27 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/9#issuecomment-125282263 Closing as nobody seems to be interested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-couch-replicator pull request: Implement `couch_define_db`...

2015-07-27 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch-mrview pull request: 2635 systems dbs

2015-07-27 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/16#issuecomment-125283190 PR has been rotten. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-mem3 pull request: Implement `couch_define_db` behaviour

2015-07-27 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-mem3/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-couch pull request: Avoid arithmetic in `to_hex` function

2015-07-27 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/79#issuecomment-125296370 new | old -|- 1096247 | 1489097 Note: The number is a 99.9% for 1 runs with 1000 bytes of data

[GitHub] couchdb-chttpd pull request: Use `chttpd:qs*` instead of `couch_ht...

2015-07-23 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/48 Use `chttpd:qs*` instead of `couch_httpd:qs*` You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-chttpd chttpd-qs

[GitHub] couchdb-couch-stats pull request: Use `chttpd:qs` instead of `couc...

2015-07-23 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-stats/pull/6 Use `chttpd:qs` instead of `couch_httpd:qs` You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-stats chttpd-qs

[GitHub] couchdb-chttpd pull request: Update mochiweb to fix the problem wh...

2015-07-22 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/46 Update mochiweb to fix the problem when second request is ignored This reverts commit 56cf6412ad3572b5d07a281c5a25ec511af0530c. Newer version of mochiweb closes connection on failed

[GitHub] couchdb-chttpd pull request: Update mochiweb to fix the problem wh...

2015-07-22 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/46#issuecomment-123727970 @iilyak how much newer? Keep in mind, that ours is quite different from upstream one. @kxepal: I was about to issue PR for mochiweb and figure it out

[GitHub] couchdb-chttpd pull request: Unify headers to be a list to avoid c...

2015-07-17 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-chttpd pull request: Dynamic http endpoint handlers

2015-07-17 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/43#discussion_r34901399 --- Diff: src/chttpd_handlers.erl --- @@ -0,0 +1,60 @@ +% Licensed under the Apache License, Version 2.0 (the License); you may not +% use

[GitHub] couchdb pull request: Make sure we start `setup` application

2015-07-17 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/326 Make sure we start `setup` application Needed for https://github.com/apache/couchdb-chttpd/pull/43 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] couchdb-mem3 pull request: Use dynamic http handlers

2015-07-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-mem3/pull/10#issuecomment-122347766 PR is squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-chttpd pull request: Dynamic http endpoint handlers

2015-07-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/43#issuecomment-122338579 @kxepal: I was wrong. The problem you saw is because I'm stupid. I forgot to add `src/chttpd_httpd_handlers.erl` file. --- If your project is set up for it, you

[GitHub] couchdb-chttpd pull request: Dynamic http endpoint handlers

2015-07-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/43#issuecomment-122343826 I'll squash the PR for merge then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-couch pull request: Add dynamic http endpoints

2015-07-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/73#issuecomment-122347168 @kxepal: I thought they are integration tests but maybe they aren't. Let me know if you want me to move them into `chttpd`. --- If your project is set up

[GitHub] couchdb-chttpd pull request: Dynamic http endpoint handlers

2015-07-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/43#issuecomment-122348919 @kxepal: I'll move `_oauth` into couchdb-couch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-mem3 pull request: Use dynamic http handlers

2015-07-15 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-mem3/pull/10 Use dynamic http handlers We use dynamic http handlers for: - `_membership` - `_shards` You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] couchdb-chttpd pull request: Dynamic http endpoint handlers

2015-07-15 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/43#issuecomment-121667400 This work consists of the following: - https://github.com/apache/couchdb-couch-epi/pull/4 - [current PR](https://github.com/apache/couchdb-chttpd

[GitHub] couchdb-mem3 pull request: Add test suite for http endpoints

2015-08-25 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-mem3/pull/12 Add test suite for http endpoints COUCHDB-2789 This PR depends on https://github.com/apache/couchdb-chttpd/pull/65 You can merge this pull request into a Git repository by running

[GitHub] couchdb-couch pull request: Refactor test suite for httpd endpoint...

2015-08-24 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/92 Refactor test suite for httpd endpoints This PR depends on https://github.com/apache/couchdb-chttpd/pull/65 COUCHDB-2789 You can merge this pull request into a Git repository

[GitHub] couchdb-chttpd pull request: Refactor test suite for httpd endpoin...

2015-08-24 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/65 Refactor test suite for httpd endpoints Split out common parts into util module so we can reuse test suite. The util module could be used for testing: - endpoints defined in other

[GitHub] couchdb-couch pull request: Refactor test suite for httpd endpoint...

2015-08-25 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/92#issuecomment-134669330 List of PRs which replace the tests removed here: https://github.com/apache/couchdb-chttpd/pull/65 https://github.com/apache/couchdb-setup/pull/6

[GitHub] couchdb-chttpd pull request: Fix 'override' and 'override default'...

2015-08-25 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/64#discussion_r37882630 --- Diff: src/chttpd_handlers.erl --- @@ -55,11 +55,39 @@ select([], Default) - select([{default, OverrideDefault}], _Default

[GitHub] couchdb-couch pull request: Run tests with only the couch_db_plugi...

2015-11-05 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/125#discussion_r44017552 --- Diff: test/couch_db_plugin_tests.erl --- @@ -48,24 +48,18 @@ notify(_, _, _) -> ok. start_epi() -> application:load(cou

[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...

2015-11-06 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/126#issuecomment-154569604 @jaydoane: The cyclic dependency could be triggered with following: 1. make a syntactic error in `couch-log/priv/stats_descriptions.cfg` 2

[GitHub] couchdb-couch pull request: Run tests with only the couch_db_plugi...

2015-11-05 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/125#issuecomment-154079245 Maybe we should stop and unload couch_epi in teardown instead. Since we load and start it in setup. In this case there will be no need to remember current list

[GitHub] couchdb-couch pull request: Run tests with only the couch_db_plugi...

2015-11-06 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/125#issuecomment-154422349 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...

2015-11-06 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/126#issuecomment-154482467 @kxepal: We have a very bad cyclic dependency between [couch_log](https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log.erl#L47) and [couch_stats

[GitHub] couchdb-couch pull request: Export delete file

2015-10-06 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/115 Export delete file In order to support `rename_on_delete` semantics for views. We want to reuse `couch_server:delete_file` in couch_mrview_cleanup. You can merge this pull request

[GitHub] couchdb-couch-mrview pull request: Use couch_server:delete_file on...

2015-10-06 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/33 Use couch_server:delete_file on view cleanup This PR depends on: - https://github.com/apache/couchdb-couch/pull/115 You can merge this pull request into a Git repository by running

[GitHub] couchdb-couch pull request: Export delete file

2015-10-07 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/115#discussion_r41401845 --- Diff: src/couch_server.erl --- @@ -549,9 +554,13 @@ delete_db_file(RootDir, FullFilePath, Options) -> end. rename_on_del

[GitHub] couchdb-couch pull request: Export delete file

2015-10-07 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/115#issuecomment-146250492 I'll revert the UUID change and squash for final review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-couch-mrview pull request: Use couch_server:delete_file on...

2015-10-07 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/33#issuecomment-146254318 squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-couch-epi pull request: Ensure calling order of plugins du...

2015-10-06 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-epi/pull/14 Ensure calling order of plugins during dispatch If there are multiple plugins providing same service they will be called in the order they listed in application:get_env(couch_epi

[GitHub] couchdb-chttpd pull request: Use couch_epi:decide/5 for authentica...

2015-10-09 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/81 Use couch_epi:decide/5 for authenticate/authorize This PR depends https://github.com/apache/couchdb-couch-epi/pull/15 The change would allow to chain multiple plugins. You can merge

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-18 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/95 Handle errors from before_request/after_request This refactoring fixes the handling of errors from before_request. Unify how we deal with errors among before_request and handle_request

[GitHub] couchdb-couch pull request: Refactor test suite for httpd endpoint...

2015-08-27 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/92#issuecomment-135468450 All dependent PRs are updated to support introspection. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-chttpd pull request: Refactor test suite for httpd endpoin...

2015-08-24 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/65#issuecomment-134462216 This PR depends on https://github.com/apache/couchdb-couch-epi/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-chttpd pull request: Refactor test suite for httpd endpoin...

2015-08-25 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/65#discussion_r37904056 --- Diff: test/chttpd_httpd_handlers_tests.erl --- @@ -0,0 +1,54 @@ +% Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-chttpd pull request: Refactor test suite for httpd endpoin...

2015-08-25 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/65#discussion_r37904391 --- Diff: test/chttpd_httpd_handlers_tests.erl --- @@ -0,0 +1,54 @@ +% Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-chttpd pull request: Refactor test suite for httpd endpoin...

2015-08-26 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/65#issuecomment-135040339 I did rework the structure of the PR a little bit. Now it has mandatory `endpoint/1` function in every `app_httpd_handlers.erl` to facilitate introspection

[GitHub] couchdb-chttpd pull request: Fix 'override' and 'override default'...

2015-08-26 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/64#issuecomment-135004856 PR is squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-couch-index pull request: 2796 improve performance of prov...

2015-09-02 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-index/pull/8 2796 improve performance of providers function This PR depends on apache/couchdb-couch-epi#8 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] couchdb-couch pull request: 2796 improve performance of providers ...

2015-09-02 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/94 2796 improve performance of providers function This PR depends on https://github.com/apache/couchdb-couch-epi/pull/8 You can merge this pull request into a Git repository by running

[GitHub] couchdb-chttpd pull request: Escape database name on posts to _rep...

2015-09-08 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-couch pull request: Allow filtering of active tasks by pro...

2015-09-11 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/99#discussion_r39289982 --- Diff: src/couch_task_status.erl --- @@ -122,6 +127,14 @@ handle_call({add_task, TaskProps}, {From, _}, Server

[GitHub] couchdb-couch pull request: Allow filtering of active tasks by pro...

2015-09-11 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/99#discussion_r39290733 --- Diff: src/couch_task_status.erl --- @@ -122,6 +127,14 @@ handle_call({add_task, TaskProps}, {From, _}, Server

[GitHub] couchdb-mem3 pull request: Update to new couch_epi API

2015-09-28 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-mem3/pull/14 Update to new couch_epi API Depends on https://github.com/apache/couchdb-couch-epi/pull/12 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb pull request: Simplify couch epi

2015-09-28 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/349 Simplify couch epi This work would fix start-up order. In the previous implementation we had a time when calls hit stock implementation instead of plugged functionality. In current implementation

[GitHub] couchdb-couch pull request: Update to new couch_epi API

2015-09-28 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/104 Update to new couch_epi API Depends on https://github.com/apache/couchdb-couch-epi/pull/12 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb pull request: Update Dockerfile

2015-09-29 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/340#issuecomment-144113688 I see following use cases for docker images: 1. Use docker to build couchdb on systems without building tools. 2. Use docker to run single node couchdb

[GitHub] couchdb pull request: Simplify couch epi

2015-09-29 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/349#discussion_r40692428 --- Diff: Makefile --- @@ -154,7 +154,7 @@ docker-start: docker-stop: @docker stop `cat .docker-id` -eunit: export BUILDDIR = $(shell

[GitHub] couchdb pull request: Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS mac...

2015-09-29 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/348#discussion_r40696130 --- Diff: rebar.config.script --- @@ -15,6 +15,18 @@ ConfigureEnv = filename:join(filename:dirname(SCRIPT), "config.erl"), os:putenv("

[GitHub] couchdb-chttpd pull request: Update to new couch_epi API

2015-09-28 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/77 Update to new couch_epi API Depends on https://github.com/apache/couchdb-couch-epi/pull/12 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/349#discussion_r40822112 --- Diff: rel/apps/couch_epi.config --- @@ -0,0 +1,9 @@ +{plugins, [ +couch_db_epi, +chttpd_epi, +couch_index_epi

[GitHub] couchdb pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/349#issuecomment-144481752 @kxepal: Finally changes to `files/sys.config` are gone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb pull request: Update Dockerfile

2015-09-28 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/340#issuecomment-143758321 I think it should use bind instead of COPY. In this case it would always use the most recent version of the source. Also in this case you wouldn't need to rebuild

[GitHub] couchdb-chttpd pull request: Remove chttpd_handlers:provider

2015-10-01 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/78 Remove chttpd_handlers:provider `provider` function is no longer needed since providers defined by couch_epi_plugin behaviour. You can merge this pull request into a Git repository

[GitHub] couchdb-couch-epi pull request: Fix dialyzer warnings

2015-10-02 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-epi/pull/13 Fix dialyzer warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-epi dialyzer-warnings Alternatively you

[GitHub] couchdb-couch pull request: Fix dialyzer crash

2015-10-02 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/114 Fix dialyzer crash You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch fix-dialyzer-crash Alternatively you can

[GitHub] couchdb-couch-epi pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/12#discussion_r40804099 --- Diff: src/couch_epi_sup.erl --- @@ -32,13 +47,216 @@ start_link() -> supervisor:start_link({local, ?MODULE}, ?MOD

[GitHub] couchdb-couch-epi pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/12#discussion_r40799660 --- Diff: src/couch_epi_sup.erl --- @@ -32,13 +47,216 @@ start_link() -> supervisor:start_link({local, ?MODULE}, ?MOD

[GitHub] couchdb-couch-epi pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/12#discussion_r40800493 --- Diff: test/couch_epi_tests.erl --- @@ -152,26 +228,26 @@ teardown(#ctx{kv = KV}) -> application:stop(couch_epi),

[GitHub] couchdb-couch-epi pull request: Simplify couch epi

2015-09-29 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/12#discussion_r40699443 --- Diff: src/couch_epi_data.erl --- @@ -12,131 +12,103 @@ -module(couch_epi_data). --behaviour(gen_server). +-include

[GitHub] couchdb-couch-index pull request: Update to new couch_epi API

2015-09-29 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-index/pull/10#discussion_r40723175 --- Diff: src/couch_index_server.erl --- @@ -38,7 +38,6 @@ -record(st, {root_dir}). start_link

[GitHub] couchdb pull request: Simplify couch epi

2015-09-29 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/349#issuecomment-144182095 I think I addressed all comments for all dependent PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb pull request: Simplify couch epi

2015-09-30 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/349#discussion_r40820314 --- Diff: rel/apps/couch_epi.config --- @@ -0,0 +1,9 @@ +{plugins, [ +couch_db_epi, +chttpd_epi, +couch_index_epi

[GitHub] couchdb-couch pull request:

2015-09-28 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/commit/8bbfba7003d4ad3e8d62f1f13147b22e9138c954#commitcomment-13468338 @kxepal: Would you mind updating the test suite https://github.com/apache/couchdb-couch/blob/master/test

[GitHub] couchdb pull request: Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS mac...

2015-09-25 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb/pull/347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb pull request: Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS mac...

2015-09-25 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/348 Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS macro We define HAS_CALLBACKS feature macro in order to make `dialyzer` happy. OTP releases prior to 15 require defining `behaviour_info` instead

[GitHub] couchdb pull request: Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS mac...

2015-09-25 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/347 Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS macro We define HAS_CALLBACKS feature macro in order to make `dialyzer` happy. OTP releases prior to 15 require defining `behaviour_info` instead

[GitHub] couchdb pull request: Define OTP_VSN/OTP_RELEASE/HAS_CALLBACKS mac...

2015-09-25 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/348#issuecomment-143268812 rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-index pull request: Adding couch_index_plugin:before...

2015-12-17 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-index/pull/11 Adding couch_index_plugin:before_open/2 EPI hook You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch-index

[GitHub] couchdb-couch-index pull request: Adding couch_index_plugin:before...

2015-12-17 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-index/pull/11#issuecomment-165548147 @rnewson: Short description is added to commit message. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-couch-epi pull request: Use app env to specify list of plu...

2016-01-06 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/10#issuecomment-169416492 Closing it since functionality is implemented using different means. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-couch-epi pull request: Use app env to specify list of plu...

2016-01-06 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch-epi/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-couch-index pull request: Adding couch_index_plugin:before...

2016-01-08 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-index/pull/11#issuecomment-170086496 @rnewson Could you merge it I don't have power. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb pull request: Update Dockerfile

2015-12-23 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/340#discussion_r48359055 --- Diff: dev/docker-cli --- @@ -0,0 +1,44 @@ +#!/bin/bash +# Licensed under the Apache License, Version 2.0 (the "License"); you may not

[GitHub] couchdb pull request: Update Dockerfile

2015-12-18 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb/pull/340#discussion_r48071451 --- Diff: Dockerfile --- @@ -1,52 +1,52 @@ -FROM debian:wheezy -MAINTAINER Robert Newson <rnew...@apache.org> -ENV DEBIAN_FRONTEND noninter

[GitHub] couchdb pull request: Update Dockerfile

2015-12-18 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/340#issuecomment-165899072 Please consider adding `.dockerignore` to ignore `dev/data` and other bulky things we don't need. Otherwise copying context on `docker build` would take longer

[GitHub] couchdb pull request: Update Dockerfile

2015-12-18 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb/pull/340#issuecomment-165900234 You can use .gitignore as a starting point for .dockerignore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-couch-epi pull request: Fix a warning for a variable shado...

2016-01-12 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/17#issuecomment-170925098 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fabric issue #54: Fix compilation warnings

2016-06-02 Thread iilyak
Github user iilyak commented on the issue: https://github.com/apache/couchdb-fabric/pull/54 We pass Args as a whole to `handle_message/3` in `#collector.query_args` field. We also pass Args to `fabric_rpc:reduce_view/3` earlier. So the `direction` parameter get passed down the chain

[GitHub] couchdb pull request: Bump deps

2016-05-25 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb/pull/420 Bump deps Update dependencies to fix CI failures for `couchdb-couch` (and possibly others) repository. You can merge this pull request into a Git repository by running: $ git pull https

  1   2   3   4   5   >