[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread theburge
Github user theburge commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71321315 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}. +%% fi

[GitHub] couchdb-couch pull request #185: 3061 adaptive header search

2016-07-19 Thread theburge
Github user theburge commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/185#discussion_r71323695 --- Diff: src/couch_file.erl --- @@ -524,6 +525,99 @@ handle_info({'EXIT', _, Reason}, Fd) -> {stop, Reason, Fd}. +%% fi

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-07-20 Thread theburge
Github user theburge commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @jaydoane: One additional thought I had was that it's taking good care of the page cache with `posix_fadvise`, but perhaps not quite such good care of the BEAM's memory usage. Have you

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-09-16 Thread theburge
Github user theburge commented on the issue: https://github.com/apache/couchdb-couch/pull/185 @jaydoane Thanks for running and documenting those experiments, I think those results look very promising. Reducing time taken and user-space memory usage can only be good. :) FWIW

[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-09-22 Thread theburge
Github user theburge commented on the issue: https://github.com/apache/couchdb-couch/pull/185 Thanks for doing the additional investigation @jaydoane. I'm glad the performance remains consistently improved. From memory, I've observed deeply buried headers frequently in MT