[GitHub] couchdb-fauxton pull request: enable include_docs per default

2015-08-20 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132913244 how about off by default but remembering the setting between visits to the page (could be per-database / view)? The large documents problem happens

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-09-14 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140141043 to elaborate, PouchDB is adding query parameters (revs=true, attachments=true) to the request body instead of the query string. --- If your project is set up

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-09-14 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140140779 ah - ignore the above. PouchDB is wrong here (if we're basing this on rcouch). The CouchDB implementation works as expected through the clustered interface

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-09-11 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-139565250 in my tests, bulk_get doesn't return the list of revisions correctly: $ curl http://localhost:15984/willtest -XPUT {"ok&

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-09-14 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140180282 I have a PouchDB PR with all tests now passing against this implementation. I imagine there are some optimisations that could be done in terms of minimising

[GitHub] couchdb-chttpd pull request: use shard suffix when generating _cha...

2016-05-16 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/120#issuecomment-219404101 I'd like to add tests for this but not quite sure where the appropriate place is. Also, this pattern is repeated at https://github.com/apache

[GitHub] couchdb-chttpd pull request #135: Handle empty "Access-Control-Request-Heade...

2016-08-01 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/135 Handle empty "Access-Control-Request-Headers" header When "Access-Control-Request-Headers" is empty, return an empty "Access-Control-Allow-Headers" in

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 @rnewson sure - I couldn't see an example other than `sequence number` in the CouchDB docs. Cloudant uses `sequence identifiers` in the documentation so I went with that as a first

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 thanks all for the feedback. I've pushed a new update which addresses the comments and adds a new section on the `_selector` filter. --- If your project is set up for it, you can

[GitHub] couchdb-documentation pull request #55: API documentation for _find and _ind...

2016-09-01 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/55 API documentation for _find and _index endpoints API reference documentation for the new _find and _index endpoints. Credit to this primarily goes to @KimStebel who wrote

[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...

2016-09-02 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 recommitted with lint fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation pull request #59: document sending multiple queries to...

2016-09-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/59 document sending multiple queries to views Fixes COUCHDB-3122 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley

[GitHub] couchdb-documentation pull request #60: document sorted parameter for view q...

2016-09-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/60 document sorted parameter for view queries Refs COUCHDB-3060 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb

[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...

2016-09-02 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 the linter errors related to the files in this PR should be fixed. There were other, existing linter errors that weren't addressed here. --- If your project is set up for it, you

[GitHub] couchdb-documentation pull request #61: remove references to temp views

2016-09-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/61 remove references to temp views possibly this is too brutal but, since they are not supported in 2.0, here's a first pass at updating the docs. You can merge this pull request

[GitHub] couchdb-fabric pull request #67: clarify error when all_or_nothing attempted

2016-09-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/67 clarify error when all_or_nothing attempted change the error message so that it doesn't imply that all_or_nothing is a feature that will be implemented in the future. You can merge

[GitHub] couchdb-documentation pull request #63: Remove row-spanning in _find documen...

2016-09-09 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/63 Remove row-spanning in _find documentation Man pages do not support table row spanning, so don't do it. You can merge this pull request into a Git repository by running: $ git

[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...

2016-09-22 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-chttpd/pull/135 I've seen a few users run into this problem. Any chance of getting it merged now we past 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-documentation pull request #62: remove references to all_or_nothing

2016-09-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/62 remove references to all_or_nothing all_or_nothing is not supported in CouchDB 2.0, so remove it from the API docs. I was hesitant to remove the "Conflicts in ba

[GitHub] couchdb-documentation issue #81: Document stable and update query parameters

2016-10-11 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 @rnewson thanks for the swift review! Both comments addressed in the latest version. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-documentation pull request #81: Document stable and update query par...

2016-10-11 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/81 Document stable and update query parameters CouchDB-3063 adds 2 new query parameters when querying views. This commit adds API documentation for these and a note in the performance

[GitHub] couchdb-documentation pull request #81: Document stable and update query par...

2016-11-30 Thread willholley
Github user willholley closed the pull request at: https://github.com/apache/couchdb-documentation/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options

2017-01-03 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 thanks for the swift review @kxepal. I've made a few changes based on your comments - the naming matches the existing conventions in the module (perhaps not ideal, but consistent

[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options

2017-01-03 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/81 Include conflicts parameter in doc_options When a keys array is passed to _all_docs, fabric translates this to individual open_doc calls. The conflicts=true query parameter