[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-14 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r379625278 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -835,25 +852,49 @@ get_last_change(#{} = Db) -> end.

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-14 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r379626313 ## File path: src/fabric/test/fabric2_changes_fold_tests.erl ## @@ -21,28 +21,56 @@ -define(DOC_COUNT, 25).

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377874095 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -815,25 +846,52 @@ get_last_change(#{} = Db) -> end.

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377872657 ## File path: src/fabric/include/fabric2.hrl ## @@ -57,7 +57,10 @@ -define(PDICT_TX_ID_KEY, '$fabric_tx_id').

[GitHub] [couchdb] davisp commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
davisp commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377875422 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -1361,21 +1426,66 @@ get_fold_opts(RangePrefix, Options) ->