[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-14 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r379628925 ## File path: src/fabric/test/fabric2_changes_fold_tests.erl ## @@ -21,28 +21,56 @@ -define(DOC_COUNT, 25). +-d

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377920781 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -1361,21 +1426,66 @@ get_fold_opts(RangePrefix, Options) ->

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377881851 ## File path: src/fabric/src/fabric2_db.erl ## @@ -1001,6 +1002,11 @@ maybe_set_user_ctx(Db, Options) -> end.

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377880280 ## File path: src/fabric/src/fabric2_fdb.erl ## @@ -815,25 +846,52 @@ get_last_change(#{} = Db) -> end. -fo

[GitHub] [couchdb] nickva commented on a change in pull request #2540: Use multi-transactional iterators

2020-02-11 Thread GitBox
nickva commented on a change in pull request #2540: Use multi-transactional iterators URL: https://github.com/apache/couchdb/pull/2540#discussion_r377880172 ## File path: src/fabric/include/fabric2.hrl ## @@ -57,7 +57,10 @@ -define(PDICT_TX_ID_KEY, '$fabric_tx_id'). -def