[GitHub] flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r175267317 ## File path: src/cluster/setup.rst ## @@ -163,9 +163,17 @@ then to add nodes by IP address. To get more nodes, go through the same install procedure on other machines. Be sure to specify the total number of nodes you expect to add to the cluster before adding nodes. -Before you can add nodes to form a cluster, you have to have them -listen on a public IP address and set up an admin user. Do this, once -per node: +Before you can add nodes to form a cluster, you must have them listening on an +IP address accessible from the other nodes in the cluster. +Do this once per node: + +In file etc/vm.args to -name couchdb@ for each node. +For clustered setup, each node in the system must have a unique name. Review comment: This paragraph looks like a partial copy of the following one. Copy and paste error? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r174072674 ## File path: src/cluster/setup.rst ## @@ -164,9 +164,15 @@ procedure on other machines. Be sure to specify the total number of nodes you expect to add to the cluster before adding nodes. Before you can add nodes to form a cluster, you have to have them -listen on a public IP address and set up an admin user. Do this, once +listen on a node address if all nodes can communicate over those IP's, +also set up an admin user which should be same on all nodes. Do this, once per node: Review comment: This is some very awkward wording, IMO. I suggest rewriting the paragraph as: > Before you can add nodes to form a cluster, you must have them listening on an IP address accessible from the other nodes in the cluster. Do this once per node: > In file ``etc/vm.args`` change the the line ``-name couchdb@127.0.0.1`` to ``-name couchdb@`` for each node. For clustered setup, each node in the system must have a unique name. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r173713206 ## File path: src/cluster/setup.rst ## @@ -167,6 +167,9 @@ Before you can add nodes to form a cluster, you have to have them listen on a public IP address and set up an admin user. Do this, once per node: +``-name couchdb@127.0.0.1`` in file etc/vm.args on Review comment: Now this is an incomplete sentence :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
flimzy commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r173620348 ## File path: src/cluster/setup.rst ## @@ -167,6 +167,9 @@ Before you can add nodes to form a cluster, you have to have them listen on a public IP address and set up an admin user. Do this, once per node: +Change line ``-name couchdb@127.0.0.1`` in file etc/vm.args on +each node for clustered setup, each node in system must have a unique name. Review comment: This is a run-on sentence. I suggest changing to: > ... for clustered setup. Each node in the system must have a unique name. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services