[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

2018-03-06 Thread GitBox 
rnewson commented on issue #1164: Fix: Proper error handling for file:open() 
call in couch_file.erl
URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370813319
 
 
   if @davisp is happy, I'm happy.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

2018-03-06 Thread GitBox 
rnewson commented on issue #1164: Fix: Proper error handling for file:open() 
call in couch_file.erl
URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370775651
 
 
   @davisp if you would like to comment on the init portions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rnewson commented on issue #1164: Fix: Proper error handling for file:open() call in couch_file.erl

2018-03-06 Thread GitBox 
rnewson commented on issue #1164: Fix: Proper error handling for file:open() 
call in couch_file.erl
URL: https://github.com/apache/couchdb/pull/1164#issuecomment-370775511
 
 
   -1.
   
   We assert that we get the `ok` we expect. If we don't, we want the process 
to crash, which it does.
   
   Adding error handling code for errors we don't intend to handle (in the sync 
case, you immediately throw it anyway) is an anti-pattern in erlang, though 
common (or mandatory) in other languages.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services