[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-07-18 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-405989634 The new issue is at https://github.com/apache/couchdb/issues/1455 This is an

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-07-18 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-405986847 @pierrekilly @janl unfortunately bcrypt is terminally broken on Windows, as it is missing the BSD libc extensions (queue.h) and a useful pthreads

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-02-27 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369009872 Great work here. I'm unable to comment on the code quality, but if @janl and @rnewson are happy, you've pleased the right people. As

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-02-13 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365303878 And because this is your first contribution - THANK YOU for contributing to CouchDB! We're always happy to have new collaborators on our project.

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-02-13 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365297966 Hi @pierrekilly , Oops, I wasn't clear in my comments, sorry about that. You *should* use the same value for iterations for `bcrypt`

[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

2018-02-12 Thread GitBox
wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365130428 For Apache CouchDB to accept this code, we will need to import the erlangpack/bcrypt repo and perform due diligence on the