[GitHub] wuqke edited a comment on issue #2219: Dubbo Server 老是会调用DubboShutdownHook 自动关闭

2018-08-10 Thread GitBox
wuqke edited a comment on issue #2219: Dubbo Server 老是会调用DubboShutdownHook 自动关闭 URL: https://github.com/apache/incubator-dubbo/issues/2219#issuecomment-412095884 @kimmking no,it crashed on MacOS either. The logs shows below: The version of my macOS is Sierra10.12 (16A323).

[GitHub] wuqke commented on issue #2219: Dubbo Server 老是会调用DubboShutdownHook 自动关闭

2018-08-10 Thread GitBox
wuqke commented on issue #2219: Dubbo Server 老是会调用DubboShutdownHook 自动关闭 URL: https://github.com/apache/incubator-dubbo/issues/2219#issuecomment-412095884 @kimmking yes,it crashed on MacOS either. The logs shows below: The version of my macOS is Sierra10.12 (16A323). ```

[GitHub] carryxyh commented on issue #1917: Condition is not properly used ?

2018-08-10 Thread GitBox
carryxyh commented on issue #1917: Condition is not properly used ? URL: https://github.com/apache/incubator-dubbo/issues/1917#issuecomment-412099586 Feel free to submit a PR to optimize this section. I also think that you can optimize the indentation of the code... The current

[GitHub] carryxyh commented on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
carryxyh commented on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412249031 No, just fix and repush it. :) This is an automated message from the

[GitHub] lllichen commented on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen commented on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412236931 should i close this pull request? This is an automated message from the

[GitHub] lllichen opened a new pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen opened a new pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221 ## What is the purpose of the change optimize code for more understandable ## Brief changelog add inner class for url parse ##

[GitHub] lllichen closed pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen closed pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] lllichen closed pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen closed pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] klboke commented on issue #1012: Wanted: who's using dubbo

2018-08-10 Thread GitBox
klboke commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-412248718 组织:凯京集团 地点:中国上海 官网:http://www.keking.cn/ 联系方式:632104...@qq.com 场景:RPC通讯,服务治理,分布式去中心化系统

[GitHub] lllichen commented on a change in pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen commented on a change in pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#discussion_r209409417 ## File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java ## @@ -169,87 +169,127 @@

[GitHub] lllichen commented on a change in pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen commented on a change in pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#discussion_r209409417 ## File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java ## @@ -169,87 +169,127 @@

[GitHub] CLAassistant edited a comment on issue #457: 修改:telent 支持泛型参数json调用

2018-08-10 Thread GitBox
CLAassistant edited a comment on issue #457: 修改:telent 支持泛型参数json调用 URL: https://github.com/apache/incubator-dubbo/pull/457#issuecomment-308420422 [![CLA assistant check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=457) All committers

[GitHub] lllichen commented on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen commented on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412001239 @diecui1202 what's wrong with My code This is an automated message from

[GitHub] lllichen edited a comment on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen edited a comment on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412001239 @diecui1202 what's wrong with my code This is an automated

[GitHub] lllichen edited a comment on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen edited a comment on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412001239 @diecui1202 what's wrong with mine code This is an automated

[GitHub] beiwei30 opened a new issue #2226: remove hessian-lite license info from LICENSE in the next release.

2018-08-10 Thread GitBox
beiwei30 opened a new issue #2226: remove hessian-lite license info from LICENSE in the next release. URL: https://github.com/apache/incubator-dubbo/issues/2226 Since we remove the hessian-lite, I suggest we remove the license info in LICENSE. I checked ASF release policy[1], it

[GitHub] chickenlj closed issue #66: Blog translation

2018-08-10 Thread GitBox
chickenlj closed issue #66: Blog translation URL: https://github.com/apache/incubator-dubbo-website/issues/66 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] chickenlj commented on issue #66: Blog translation

2018-08-10 Thread GitBox
chickenlj commented on issue #66: Blog translation URL: https://github.com/apache/incubator-dubbo-website/issues/66#issuecomment-412004000 Thanks for all the hard works from the community, all done. This is an automated

[GitHub] beiwei30 commented on issue #2116: Two dubbo calls, kryo serialization failed(大神们帮忙看下吧,着急使用)

2018-08-10 Thread GitBox
beiwei30 commented on issue #2116: Two dubbo calls, kryo serialization failed(大神们帮忙看下吧,着急使用) URL: https://github.com/apache/incubator-dubbo/issues/2116#issuecomment-412010041 I could reproduce the issue. If the optimizer is not globally known and kept consistent to all participated

[GitHub] ralf0131 opened a new issue #2227: Unstable unit test

2018-08-10 Thread GitBox
ralf0131 opened a new issue #2227: Unstable unit test URL: https://github.com/apache/incubator-dubbo/issues/2227 Sometime the following unit test will fail: ``` AbstractInterfaceConfigTest.checkApplication1:90 expected:<10[0]> but was:<10[]> ```

[GitHub] lllichen edited a comment on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen edited a comment on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412001239 @diecui1202 what's wrong with my code , can you help me? This is

[GitHub] lllichen edited a comment on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
lllichen edited a comment on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412001239 @diecui1202 what's wrong with my code ? This is an automated

[GitHub] diecui1202 commented on issue #2222: 禁止某个Filter的执行

2018-08-10 Thread GitBox
diecui1202 commented on issue #: 禁止某个Filter的执行 URL: https://github.com/apache/incubator-dubbo/issues/#issuecomment-412008023 I think custom filter has no difference with the filter provided by dubbo framework. This

[GitHub] diecui1202 closed pull request #87: add blogs

2018-08-10 Thread GitBox
diecui1202 closed pull request #87: add blogs URL: https://github.com/apache/incubator-dubbo-website/pull/87 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] luyunfeng removed a comment on issue #2222: 禁止某个Filter的执行

2018-08-10 Thread GitBox
luyunfeng removed a comment on issue #: 禁止某个Filter的执行 URL: https://github.com/apache/incubator-dubbo/issues/#issuecomment-412009725 在 AbstractInterfaceConfig 中 直接限制住了 ,所以非dubbo framework下的会出现```No such extension```异常 ```java public void setFilter(String filter) {

[GitHub] diecui1202 opened a new pull request #87: add blogs

2018-08-10 Thread GitBox
diecui1202 opened a new pull request #87: add blogs URL: https://github.com/apache/incubator-dubbo-website/pull/87 ## What is the purpose of the change add 3 blogs ## Brief changelog new file: blog/zh-cn/dubbo-generic-invoke.md new file:

[GitHub] kimmking commented on issue #2224: Any better solutions for http request

2018-08-10 Thread GitBox
kimmking commented on issue #2224: Any better solutions for http request URL: https://github.com/apache/incubator-dubbo/issues/2224#issuecomment-412005739 dubbox with its samples This is an automated message from the Apache

[GitHub] luyunfeng commented on issue #2222: 禁止某个Filter的执行

2018-08-10 Thread GitBox
luyunfeng commented on issue #: 禁止某个Filter的执行 URL: https://github.com/apache/incubator-dubbo/issues/#issuecomment-412007285 但是这个是只能禁止dubbo原生的filter,不能禁止用户自定义的 This is an automated message from the Apache Git Service.

[GitHub] chickenlj opened a new issue #86: Blog translation, 2nd round.

2018-08-10 Thread GitBox
chickenlj opened a new issue #86: Blog translation, 2nd round. URL: https://github.com/apache/incubator-dubbo-website/issues/86 We have received lots of help from the community on blog translation previously, see #66 . Thank you all for the hard work. Here are more blogs that you

[GitHub] luyunfeng commented on issue #2222: 禁止某个Filter的执行

2018-08-10 Thread GitBox
luyunfeng commented on issue #: 禁止某个Filter的执行 URL: https://github.com/apache/incubator-dubbo/issues/#issuecomment-412009725 在 AbstractInterfaceConfig 中 直接限制住了 ,所以非dubbo framework下的会出现```No such extension```异常 ```java public void setFilter(String filter) {

[GitHub] luyunfeng closed issue #2222: 禁止某个Filter的执行

2018-08-10 Thread GitBox
luyunfeng closed issue #: 禁止某个Filter的执行 URL: https://github.com/apache/incubator-dubbo/issues/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] keepongjl opened a new issue #83: the configuration file dubbo.properties do not work

2018-08-10 Thread GitBox
keepongjl opened a new issue #83: the configuration file dubbo.properties do not work URL: https://github.com/apache/incubator-dubbo-ops/issues/83 I hava config the **dubbo.properties** dubbo.registry.address=zookeeper://192.168.84.134:7763 bug it is not work the dubbo-monitor

[GitHub] chickenlj commented on issue #2218: When using telnet "invoke" method, if there is a [null] param, the response always be [null]

2018-08-10 Thread GitBox
chickenlj commented on issue #2218: When using telnet "invoke" method, if there is a [null] param, the response always be [null] URL: https://github.com/apache/incubator-dubbo/issues/2218#issuecomment-412025187 http://dubbo.apache.org/#!/docs/user/references/telnet.md?lang=zh-cn

[GitHub] chickenlj commented on issue #1728: System property dubbo.service.delay invalid

2018-08-10 Thread GitBox
chickenlj commented on issue #1728: System property dubbo.service.delay invalid URL: https://github.com/apache/incubator-dubbo/issues/1728#issuecomment-412024814 http://dubbo.apache.org/#!/docs/user/demos/delay-publish.md?lang=zh-cn

[GitHub] keepongjl commented on issue #83: the configuration file dubbo.properties do not work

2018-08-10 Thread GitBox
keepongjl commented on issue #83: the configuration file dubbo.properties do not work URL: https://github.com/apache/incubator-dubbo-ops/issues/83#issuecomment-412031136 I edit the project dubbo-monitor-simple dubbo.properties and then mvn package it work ..

[GitHub] codecov-io edited a comment on issue #2209: [Dubbo-2131] Check if we can switch serialization/deser between IO and Dubbo Threads.

2018-08-10 Thread GitBox
codecov-io edited a comment on issue #2209: [Dubbo-2131] Check if we can switch serialization/deser between IO and Dubbo Threads. URL: https://github.com/apache/incubator-dubbo/pull/2209#issuecomment-410927751 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2209?src=pr=h1)

[GitHub] chickenlj commented on issue #2213: [Dubbo-2187] Use CompletetableFuture to rewrite the embedded ListenableFuture

2018-08-10 Thread GitBox
chickenlj commented on issue #2213: [Dubbo-2187] Use CompletetableFuture to rewrite the embedded ListenableFuture URL: https://github.com/apache/incubator-dubbo/pull/2213#issuecomment-411994022 @dengwanghua Here' s the stack trace. Bad imports.

[GitHub] nzomkxia opened a new pull request #40: fix invalid link

2018-08-10 Thread GitBox
nzomkxia opened a new pull request #40: fix invalid link URL: https://github.com/apache/incubator-dubbo-docs/pull/40 fix invalid link in dubbo website This is an automated message from the Apache Git Service. To respond to

[GitHub] chickenlj commented on issue #2213: [Dubbo-2187] Use CompletetableFuture to rewrite the embedded ListenableFuture

2018-08-10 Thread GitBox
chickenlj commented on issue #2213: [Dubbo-2187] Use CompletetableFuture to rewrite the embedded ListenableFuture URL: https://github.com/apache/incubator-dubbo/pull/2213#issuecomment-411994287 ```java public void addListener(final IZkStateListener listener) {

[GitHub] beiwei30 closed pull request #40: fix invalid link

2018-08-10 Thread GitBox
beiwei30 closed pull request #40: fix invalid link URL: https://github.com/apache/incubator-dubbo-docs/pull/40 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] lovepoem commented on issue #2216: 客户端调服务端,服务端代码有输出,客户端接收却为""

2018-08-10 Thread GitBox
lovepoem commented on issue #2216: 客户端调服务端,服务端代码有输出,客户端接收却为"" URL: https://github.com/apache/incubator-dubbo/issues/2216#issuecomment-412000444 @zjzhujie125 What's the dubbo version of your project? This is an automated

[GitHub] haiyang1985 commented on issue #2224: Any better solutions for http request

2018-08-10 Thread GitBox
haiyang1985 commented on issue #2224: Any better solutions for http request URL: https://github.com/apache/incubator-dubbo/issues/2224#issuecomment-411984170 Thanks! Is there any existing products for rest protocol + filter solution?

[GitHub] diecui1202 commented on issue #380: async 的优先级bug

2018-08-10 Thread GitBox
diecui1202 commented on issue #380: async 的优先级bug URL: https://github.com/apache/incubator-dubbo/issues/380#issuecomment-411984107 @summer9989 Could u pls provide a demo to reproduce this scenario ? This is an automated

[GitHub] chickenlj commented on a change in pull request #2209: [Dubbo-2131] Check if we can switch serialization/deser between IO and Dubbo Threads.

2018-08-10 Thread GitBox
chickenlj commented on a change in pull request #2209: [Dubbo-2131] Check if we can switch serialization/deser between IO and Dubbo Threads. URL: https://github.com/apache/incubator-dubbo/pull/2209#discussion_r209154870 ## File path:

[GitHub] JKTerrific commented on issue #1012: Wanted: who's using dubbo

2018-08-10 Thread GitBox
JKTerrific commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-411994894 组织:壹点灵心理咨询 地点:中国杭州 官网:https://ydl.com 联系方式:huan...@yidianling.com 场景:微服务拆分

[GitHub] chickenlj commented on issue #2216: 客户端调服务端,服务端代码有输出,客户端接收却为""

2018-08-10 Thread GitBox
chickenlj commented on issue #2216: 客户端调服务端,服务端代码有输出,客户端接收却为"" URL: https://github.com/apache/incubator-dubbo/issues/2216#issuecomment-411997457 Hi @zjzhujie125 , have you checked the serialization part? This is an automated

[GitHub] imayou commented on issue #1012: Wanted: who's using dubbo

2018-08-10 Thread GitBox
imayou commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-411995648 组织:软通动力 地点:中国北京 官网:http://www.isoftstone.com 联系方式:cont...@isoftstone.com 场景:微服务,基础服务,业务系统

[GitHub] carryxyh commented on a change in pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
carryxyh commented on a change in pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#discussion_r209270596 ## File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java ## @@ -169,87 +169,127 @@

[GitHub] carryxyh commented on a change in pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
carryxyh commented on a change in pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#discussion_r209271069 ## File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java ## @@ -169,87 +169,127 @@

[GitHub] carryxyh commented on a change in pull request #2221: optimize code for more understandable

2018-08-10 Thread GitBox
carryxyh commented on a change in pull request #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#discussion_r209270197 ## File path: dubbo-common/src/main/java/org/apache/dubbo/common/URL.java ## @@ -169,87 +169,127 @@

[GitHub] carryxyh commented on issue #2221: optimize code for more understandable

2018-08-10 Thread GitBox
carryxyh commented on issue #2221: optimize code for more understandable URL: https://github.com/apache/incubator-dubbo/pull/2221#issuecomment-412093827 Maybe u should look here first after sending a pull request: