I reproduce the same problem locally. when using dubbo like this,it will load
two ContextLoaderListeners,the first in the
`org.springframework.web.context.AbstractContextLoaderInitializer#registerContextLoaderListener`
by Spring,the second in the dubbo-config-spring/web-fragment.xml(This file
This pull request looks good to me. Nice work!
The time complexity is O(n), where n is the number of invokers, which is a
significant improvement to the previous one, which is O(n*w), where n is the
number of invokers, and w is the max weight of the invokers.
I'd prefer to have more unit tests
The name `invokerToWeightList` can be improved. I think `weightedInvokerList`
or `nonZeroWeightedInvokers` should be better. :)
[ Full content available at:
https://github.com/apache/incubator-dubbo/pull/2586 ]
This message was relayed via gitbox.apache.org for
notifications@dubbo.apache.org
#
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2586?src=pr=h1)
Report
> Merging
> [#2586](https://codecov.io/gh/apache/incubator-dubbo/pull/2586?src=pr=desc)
> into
>
> This pull request looks good to me. Nice work!
> The time complexity is O(n), where n is the number of invokers, which is a
> significant improvement to the previous one, which is O(n*w), where n is the
> number of invokers, and w is the max weight of the invokers.
> I'd prefer to have more