[GitHub] [dubbo-go] flycash commented on pull request #237: Ftr: TpsLimitSupport

2019-10-18 Thread GitHub
What you review has been outdated. This has been fixed. [ Full content available at: https://github.com/apache/dubbo-go/pull/237 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] CLAassistant commented on issue #4296: add support for field name convert. e.g. order_id <-> orderId

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License

[GitHub] [dubbo] CLAassistant commented on issue #3897: add socks5 proxy support to 2.6.x netty4 client

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License

[GitHub] [dubbo] CLAassistant commented on issue #3649: [Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License

[GitHub] [dubbo] xinweishao opened issue #5193: 如何做dubbo服务的监控报警

2019-10-18 Thread GitHub
如何做dubbo服务的监控自动报警,短信或者邮件提醒 [ Full content available at: https://github.com/apache/dubbo/issues/5193 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-admin] youpickone commented on issue #519: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $

2019-10-18 Thread GitHub
同样遇到这个问题,请问楼主解决了么 [ Full content available at: https://github.com/apache/dubbo-admin/issues/519 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] manbab closed issue #5176: nacos注册中心不监听routers变更

2019-10-18 Thread GitHub
[ issue closed by manbab ] [ Full content available at: https://github.com/apache/dubbo/issues/5176 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] CLAassistant commented on issue #5192: quick return when scan package is empty

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5192) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License

[GitHub] [dubbo] CLAassistant commented on issue #5067: fix default setting

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5067) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License

[GitHub] [dubbo-js] sunchuanleihit commented on issue #141: we are ready to release dubbo-js@3.0.0

2019-10-18 Thread GitHub
@hufeng Could you help to review this pr https://github.com/apache/dubbo-js/pull/142 [ Full content available at: https://github.com/apache/dubbo-js/issues/141 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-js] sunchuanleihit commented on issue #141: we are ready to release dubbo-js@3.0.0

2019-10-18 Thread GitBox
sunchuanleihit commented on issue #141: we are ready to release dubbo-js@3.0.0 URL: https://github.com/apache/dubbo-js/issues/141#issuecomment-543603258 @hufeng Could you help to review this pr https://github.com/apache/dubbo-js/pull/142

[GitHub] [dubbo-admin] youpickone opened issue #531: Copyright ©2018-2019 The Apache Software Foundation. System Error, please try again later! Message:java.lang.IllegalStateException: Expected BEGIN

2019-10-18 Thread GitHub
dubbo监控页面服务信息和元数据信息都没有 dubbo-admin用的最新的develop分支 dubbo是2.7.0版本 提供者的application.properties `spring.application.name = dubbo-demo-provider server.port = 8081 dubbo.application.name = dubbo-demo-provider mistra.service.version = 1.0.0 dubbo.protocol.name = dubbo dubbo.protocol.port = 20880

[GitHub] [dubbo-admin] meteorice commented on issue #476: 无元数据信息,请升级至Dubbo2.7及以上版本,或者查看application.properties中关于config center的配置

2019-10-18 Thread GitHub
我看老规则获取的地址是 /dubbo/metadata/com.example.demo.service.ICardDictService/1.0/demo-provider/provider/demo-group/service.data 2.7.3 没有service.data 目录元数据直接在demo-group写入。 [ Full content available at: https://github.com/apache/dubbo-admin/issues/476 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo] codecov-io commented on issue #5198: [fix] ApplicationModel basic metadata lose (#5197)

2019-10-18 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5198?src=pr=h1) Report > Merging [#5198](https://codecov.io/gh/apache/dubbo/pull/5198?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/524cf9561da11576a2765e86cdbb24b325a9929d?src=pr=desc) > will **decrease** coverage

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License

[GitHub] [dubbo] RojerAlone opened issue #5200: javadoc of Serialization class need to correct

2019-10-18 Thread GitHub
The javadoc of Serialization.getContentTypeId needs to correct, the content type id should less than ExchangeCodes.SERIALIZATION_MASK. I will create a pr. [ Full content available at: https://github.com/apache/dubbo/issues/5200 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo] jsbxyyx opened issue #5196: dubbo home link not found

2019-10-18 Thread GitHub
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. - [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

[GitHub] [dubbo] Shangxq opened pull request #5198: [fix] ApplicationModel basic metadata lose (#5197)

2019-10-18 Thread GitHub
## What is the purpose of the change fix bug ## Brief changelog ApplicationModel basic metadata lose ## Verifying this change fine Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] [dubbo] CLAassistant commented on issue #3897: add socks5 proxy support to 2.6.x netty4 client

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License

[GitHub] [dubbo] CLAassistant commented on issue #5192: quick return when scan package is empty

2019-10-18 Thread GitHub
[![CLA assistant check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5192) All committers have signed the CLA. [ Full content available at: https://github.com/apache/dubbo/pull/5192 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo] Shangxq opened issue #5197: ApplicationModel basic metadata lose

2019-10-18 Thread GitHub
- [ x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. - [ x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate. ###

[GitHub] [dubbo] Shangxq opened pull request #5199: [fix] ApplicationModel basic metadata lose (#5197)

2019-10-18 Thread GitHub
## What is the purpose of the change fix bug (#5197) ## Brief changelog ApplicationModel basic metadata lose ## Verifying this change fine Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] [dubbo-go] aliiohs commented on pull request #237: Ftr: TpsLimitSupport

2019-10-18 Thread GitHub
这个url的包路径是net.url,我看源码中并没直接初始化 [ Full content available at: https://github.com/apache/dubbo-go/pull/237 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] hufeng closed pull request #142: remove create consumer in watcher

2019-10-18 Thread GitHub
[ pull request closed by hufeng ] [ Full content available at: https://github.com/apache/dubbo-js/pull/142 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] flycash commented on pull request #237: Ftr: TpsLimitSupport

2019-10-18 Thread GitHub
它其实是通过type{}这种方式来初始化的 [ Full content available at: https://github.com/apache/dubbo-go/pull/237 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] hufeng commented on issue #141: we are ready to release dubbo-js@3.0.0

2019-10-18 Thread GitHub
@sunchuanleihit Has been merged   [ Full content available at: https://github.com/apache/dubbo-js/issues/141 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] hufeng commented on issue #141: we are ready to release dubbo-js@3.0.0

2019-10-18 Thread GitBox
hufeng commented on issue #141: we are ready to release dubbo-js@3.0.0 URL: https://github.com/apache/dubbo-js/issues/141#issuecomment-543803281 @sunchuanleihit Has been merged   This is an automated message from the

[GitHub] [dubbo-js] hufeng commented on issue #80: Node进程会偶尔与zk集群断开连接,导致socket无可用agent

2019-10-18 Thread GitHub
dubbo-js@3.0.0合入了针对性的pr,应该可以解决这个问题 [ Full content available at: https://github.com/apache/dubbo-js/issues/80 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] hufeng commented on issue #80: Node进程会偶尔与zk集群断开连接,导致socket无可用agent

2019-10-18 Thread GitBox
hufeng commented on issue #80: Node进程会偶尔与zk集群断开连接,导致socket无可用agent URL: https://github.com/apache/dubbo-js/issues/80#issuecomment-543807004 dubbo-js@3.0.0合入了针对性的pr,应该可以解决这个问题 This is an automated message from the Apache Git

[GitHub] [dubbo-js] hufeng commented on issue #132: Add zookeeper auth supports

2019-10-18 Thread GitBox
hufeng commented on issue #132: Add zookeeper auth supports URL: https://github.com/apache/dubbo-js/pull/132#issuecomment-543827572 @xusd320 感谢你的pr ^_^ 因为后续我们会支持多注册中心,支持开发者很方便的自定义自己的注册中心,所有我前段时间做了注册中心的代码重构,目前的api ```js const dubbo = new Dubbo({ application: {name:

[GitHub] [dubbo-js] hufeng merged pull request #142: remove create consumer in watcher

2019-10-18 Thread GitBox
hufeng merged pull request #142: remove create consumer in watcher URL: https://github.com/apache/dubbo-js/pull/142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [dubbo-js] hufeng edited a comment on issue #132: Add zookeeper auth supports

2019-10-18 Thread GitBox
hufeng edited a comment on issue #132: Add zookeeper auth supports URL: https://github.com/apache/dubbo-js/pull/132#issuecomment-543827572 @xusd320 感谢你的pr ^_^ 因为后续我们会支持多注册中心,支持开发者很方便的自定义自己的注册中心,所有我前段时间做了注册中心的代码重构,这是目前的api ```js const dubbo = new Dubbo({ application:

[GitHub] [dubbo] kimmking commented on pull request #5199: [fix] ApplicationModel basic metadata lose (#5197)

2019-10-18 Thread GitHub
you should make a unit test case for this change [ Full content available at: https://github.com/apache/dubbo/pull/5199 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,