[GitHub] [dubbo-go] pantianying opened pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
**What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.

[GitHub] [dubbo-go] AlexStocks commented on pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
u should add a lock name. [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsu

[GitHub] [dubbo-go] AlexStocks commented on pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
add comment for this file, pls. [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notification

[GitHub] [dubbo-go] AlexStocks commented on pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
so large lock scope. [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [dubbo-go] AlexStocks commented on pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
the lock scope is so large. [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-un

[GitHub] [dubbo-go] Patrick0308 commented on pull request #358: add Rlock for dubbo Invoker

2020-02-14 Thread GitHub
May be using a `isDestroyed` status is good. [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] lcinshu commented on issue #5342: Hutool DateTime Value is changed current time

2020-02-14 Thread GitHub
环境 dubbo version:2.5.3 os:mac os jdk:1.8 我也遇到了类似问题,看了下dubbo和hutool相关源码 简要分析下原因: 1. DateTime是hutool组件自定义的类,继承自Date,底层还是依赖Date类型存储时间,在序列化时使用自定义序列化器(JavaSerializer和JavaDeserializer),Date父类中的字段均为static或transient,因此不会被序列化 2. 反序列化的时候,调用DateTime默认构造方法,赋值为当前时间,由于没有序列化date相关字段,所以反序列化时也不会获取到date类型

[GitHub] [dubbo-go] codecov-io commented on issue #294: Ftr: condition router

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=h1) Report > Merging [#294](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #294: Ftr: condition router

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=h1) Report > Merging [#294](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #294: Ftr: condition router

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=h1) Report > Merging [#294](https://codecov.io/gh/apache/dubbo-go/pull/294?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea

[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy

2020-02-14 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) > will **decrea