[GitHub] [dubbo] lcg72 closed issue #5868: 采用nacos作为注册中心,服务端网络参数改变,客户端持续用旧的参数连接服务端

2020-03-20 Thread GitHub
[ issue closed by lcg72 ] [ Full content available at: https://github.com/apache/dubbo/issues/5868 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] lcg72 commented on issue #5868: 采用nacos作为注册中心,服务端网络参数改变,客户端持续用旧的参数连接服务端

2020-03-20 Thread GitHub
是spring cloud alibaba的缺陷 [ Full content available at: https://github.com/apache/dubbo/issues/5868 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] CodingSinger opened pull request #432: Bug fix

2020-03-20 Thread GitHub
1. modify registryProtocol as a singleton to fix graceful shutdown can't delete the provider url 2. fix notification confusion caused by multiple references sharing the same zk listener [ Full content available at: https://github.com/apache/dubbo-go/pull/432 ] This message was relayed via

[GitHub] [dubbo] beiwei30 commented on issue #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
Great job. @guohao will review this change. [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] codecov-io commented on issue #432: Bug fix

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr=h1) Report > Merging [#432](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de=desc) > will **decrease** coverage by

[GitHub] [dubbo-samples] YuHangZM opened a new issue #155: 垃圾,你不觉得 缺 东西么? 官方文档 他妈 模棱两可,也不注明版本 说明

2020-03-20 Thread GitBox
YuHangZM opened a new issue #155: 垃圾,你不觉得 缺 东西么? 官方文档 他妈 模棱两可,也不注明版本 说明 URL: https://github.com/apache/dubbo-samples/issues/155 这里 的 merger 都是 已经支持的,怎么没有自定义的呢 ? This is an automated message from the Apache Git Service. To

[GitHub] [dubbo-go] fangyincheng commented on pull request #415: [Ftr] add Tag router

2020-03-20 Thread GitHub
format import [ Full content available at: https://github.com/apache/dubbo-go/pull/415 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] fangyincheng commented on pull request #415: [Ftr] add Tag router

2020-03-20 Thread GitHub
you can directly return instead of `else`. [ Full content available at: https://github.com/apache/dubbo-go/pull/415 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] ArvinSpace opened a new issue #206: 调试时超时timeout,而且side=consumer也没解决

2020-03-20 Thread GitBox
ArvinSpace opened a new issue #206: 调试时超时timeout,而且side=consumer也没解决 URL: https://github.com/apache/dubbo-js/issues/206 ### dubbo2.js版本2.3.9 - `import {Dubbo, java, setting} from "dubbo2.js"; const dubboSetting = setting.match(/.*/, {version: '1.0.0'}); const dubbo =

[GitHub] [dubbo] beiwei30 opened issue #5892: depend on new hessian-lite in 2.7.7

2020-03-20 Thread GitHub
hessian-lite has a performance improvement (https://github.com/apache/dubbo-hessian-lite/pull/27), we need to bump up hessian-lite and depend on the new version in the next dubbo release. [ Full content available at: https://github.com/apache/dubbo/issues/5892 ] This message was relayed via

[GitHub] [dubbo] beiwei30 commented on issue #5889: [Dubbo-Performance] Reuse Hessian2Output and Hessian2Input instance to reduce memor…

2020-03-20 Thread GitHub
I filed https://github.com/apache/dubbo/issues/5892 to track this task. [ Full content available at: https://github.com/apache/dubbo/pull/5889 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #433: Add: License checker

2020-03-20 Thread GitHub
@zouyx pls check v1.4 branch and submit a pr again [ Full content available at: https://github.com/apache/dubbo-go/pull/433 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [dubbo-go] AlexStocks commented on issue #433: Add: License checker

2020-03-20 Thread GitHub
LGTM [ Full content available at: https://github.com/apache/dubbo-go/pull/433 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] guohao commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
Line 98 - 115 这里先用 idx = indexOf(":/") 然后判断 idx + 1 的字符是否为 '/' 可以在 file:/path 的情况下减少一次 indexOf [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] guohao commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
这里是否可以直接用decodedBoyd.indexOf('/',startIdx) [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] guohao commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
128 就够了,用不到 65536 [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] zouyx commented on issue #433: Add: License checker

2020-03-20 Thread GitHub
ok [ Full content available at: https://github.com/apache/dubbo-go/pull/433 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] LinShunKang commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
可以使用缓存,但是需要多维护一个类似于 Trie 的代码,这就需要考虑代价与收益了 [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] LinShunKang commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
char 的范围是 [0, 65535] * 如果 HEX2B 大小为 128,那么在 StringUtils#decodeHexNibble(char) 方法中就需要判断入参的大小是否在 128 之内,如果在 128 以内则返回 HEX2B[c],如果不在 128 以内则返回默认值 -1 * 如果 HEX2B 大小为 65536,那么在 StringUtils#decodeHexNibble(char) 方法中就可以直接返回 HEX2B[c] 这个就需要取舍了。 [ Full content available at:

[GitHub] [dubbo] lyh19940304 opened issue #5895: 使用dubbo出现的ERROR级别的日志(不影响运行,无异常)

2020-03-20 Thread GitHub
消费者输出如下: 2020-03-21 00:56:26.163 ERROR 16736 --- [lientWorker-1-3] o.a.d.remoting.transport.CodecSupport: [DUBBO] Serialization extension org.apache.dubbo.common.serialize.kryo.optimized.KryoSerialization2 has duplicate id to Serialization extension

[GitHub] [dubbo] LinShunKang commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
是的,可以,之所以这么写是为了保持上下文逻辑的一致性,统一使用 indexof(String, char, int, int) [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo-go] beiwei30 opened issue #435: Use tool to check license header

2020-03-20 Thread GitHub
In the recent releases, a couple of files are found with license header missing. In order to solve this for now and forever, we should leverage the power of the tool. [ Full content available at: https://github.com/apache/dubbo-go/issues/435 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo-go] codecov-io commented on issue #415: [Ftr] add Tag router

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/415?src=pr=h1) Report > Merging [#415](https://codecov.io/gh/apache/dubbo-go/pull/415?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de?src=pr=desc) > will **decrease**

[GitHub] [dubbo-go] fangyincheng closed pull request #417: Modify registryProtocol as a singleton to fix graceful shutdown

2020-03-20 Thread GitHub
[ pull request closed by fangyincheng ] [ Full content available at: https://github.com/apache/dubbo-go/pull/417 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] fangyincheng commented on issue #416: 服务暴露,只能通过配置文件吗?

2020-03-20 Thread GitHub
当前是可以通过直接构造 ConsumerConfig 以代码的方式 Load 配置的。 [ Full content available at: https://github.com/apache/dubbo-go/issues/416 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [dubbo] LiosWong closed pull request #5896: remove duplicate .flattened-pom.xml from .gitignore

2020-03-20 Thread GitHub
[ pull request closed by LiosWong ] [ Full content available at: https://github.com/apache/dubbo/pull/5896 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go-hessian2] wongoo opened pull request #171: fix the problems of v1.4

2020-03-20 Thread GitHub
**What this PR does**: Fixes #170 **Which issue(s) this PR fixes**: Fixes #170 [ Full content available at: https://github.com/apache/dubbo-go-hessian2/pull/171 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] xujianhai666 opened issue #436: feat: support Json protocol for grpc

2020-03-20 Thread GitHub
[ Full content available at: https://github.com/apache/dubbo-go/issues/436 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] guohao commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
从用法上看 input char 如果 > 128 ,decodeHexNibble 返回 -1 后会抛 IllegalArgumentException,也属于异常场景,实际应用情况应该很少发生。 加一个 if/else 大部分情况可以走分支预测优化掉。 [ Full content available at: https://github.com/apache/dubbo/pull/5880 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] xujianhai666 opened pull request #437: feat: support json protocol with grpc

2020-03-20 Thread GitHub
Closes #436 [ Full content available at: https://github.com/apache/dubbo-go/pull/437 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-io commented on issue #5898: duplicate code in MulticastGroup.java and MulticastExchangeGroup.java

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr=h1) Report > Merging [#5898](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/84bc2616a5c6be6542ab5bb564c51f876d24bdb1=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5898: duplicate code in MulticastGroup.java and MulticastExchangeGroup.java

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr=h1) Report > Merging [#5898](https://codecov.io/gh/apache/dubbo/pull/5898?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/84bc2616a5c6be6542ab5bb564c51f876d24bdb1=desc) > will **decrease** coverage by

[GitHub] [dubbo-go] hetianxia commented on issue #416: 服务暴露,只能通过配置文件吗?

2020-03-20 Thread GitHub
get,set 可以替换references & services [ Full content available at: https://github.com/apache/dubbo-go/issues/416 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] codecov-io commented on issue #437: feat: support json protocol with grpc

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr=h1) Report > Merging [#437](https://codecov.io/gh/apache/dubbo-go/pull/437?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de?src=pr=desc) > will **decrease**

[GitHub] [dubbo] guohao commented on pull request #5880: [Dubbo-Performance] Reduce memory allocation for URL parse

2020-03-20 Thread GitHub
> 其实,相较于 protocol,paramsMap 里的 key 才是更需要优化的 这个问题也可以通过缓存的方式解决。 paramsMap 的 key 和 value 可以分成两种:可枚举和不可枚举。 可枚举的 kv 可以使用预先生成的静态表 + 索引存储,比如bool 值,静态表包含 {0,1},它的值也只需要一个 byte 不可枚举的 kv 可以用动态表 + 索引的方式,动态表是一个全局 array ,包含所有可能值和对应索引,URL 中只存储索引值。这种方式可最大程度减少 URL 的驻留内存。 在服务注册发现场景,多次推送的 URL 大部分都是相同的,可以引入 URL

[GitHub] [dubbo-go] wongoo commented on issue #433: Add: License checker

2020-03-20 Thread GitHub
@zouyx @AlexStocks is it need to add license-header-checker binary tool in source code? suggest to provide a download link in readme, or add it in .travis.yml . [ Full content available at: https://github.com/apache/dubbo-go/pull/433 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo-go-hessian2] codecov-io commented on issue #171: fix the problems of v1.4

2020-03-20 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/171?src=pr=h1) Report > Merging > [#171](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/171?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/0da22914f92b7826a0c76d3ccca3ac8887110b48=desc)