[GitHub] [dubbo] htynkn commented on pull request #5913: windows platform unittest adapt

apache common lang has a tool named 'SystemUtils' to do this check. consider this is a unit test, I suggest add it as test scope dependency and use https://commons.apache.org/proper/commons-lang/apidocs/index.html?org/apache/commons/lang3/SystemUtils.html [ Full content available at:

[GitHub] [dubbo-go] codecov-io commented on issue #453: Service name mapping support

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/453?src=pr=h1) Report > Merging [#453](https://codecov.io/gh/apache/dubbo-go/pull/453?src=pr=desc) > into > [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7=desc) > will

[GitHub] [dubbo] htynkn commented on issue #5913: windows platform unittest adapt

thanks very much for your contribution. it's really nice to have hardcode port number to replace by `available port`, it will make unit test more stable Could you please take a look at my comment when you have time? [ Full content available at: https://github.com/apache/dubbo/pull/5913 ] This

[GitHub] [dubbo] xiaoyaolaotou commented on issue #5911: dubbo部署到k8s, 连接外部的ZK, 外部dubbo连接ZK发现地址不通

这种方式你应用多了, 会造成node节点端口冲突 [ Full content available at: https://github.com/apache/dubbo/issues/5911 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] mercyblitz opened pull request #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

[ Full content available at: https://github.com/apache/dubbo/pull/5910 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo] xiaoyaolaotou commented on issue #5911: dubbo部署到k8s, 连接外部的ZK, 外部dubbo连接ZK发现地址不通

现在dubbo版本都是2.5 [ Full content available at: https://github.com/apache/dubbo/issues/5911 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] CodingSinger commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

有个冲突顺便解决下 [ Full content available at: https://github.com/apache/dubbo/pull/5902 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js]

[ Full content available at: https://github.com/apache/dubbo-js/issues/141 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-js] rocky-zh removed a comment on issue #141: we are ready to release dubbo-js@3.0.0

rocky-zh removed a comment on issue #141: we are ready to release dubbo-js@3.0.0 URL: https://github.com/apache/dubbo-js/issues/141#issuecomment-575967272 > 这次差不多了 rockyzh 于2020年1月15日周三 下午2:36写道： > […](#) > @hufeng apache 的投票效率也太低下了 I think the main

[GitHub] [dubbo] CodingSinger commented on pull request #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

同下 [ Full content available at: https://github.com/apache/dubbo/pull/5902 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo] CodingSinger commented on pull request #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

这里是不是应该考虑并发问题，用ConcurrentHashMap比较合适？ [ Full content available at: https://github.com/apache/dubbo/pull/5902 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-io commented on issue #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr=h1) Report > Merging [#5910](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr=desc) > into > [2.7.6-release](https://codecov.io/gh/apache/dubbo/commit/af4cff2846bdfb9f105bf32b988616a4ed40a072=desc) > will **decrease** coverage

[GitHub] [dubbo] CodingSinger commented on issue #5911: dubbo部署到k8s, 连接外部的ZK, 外部dubbo连接ZK发现地址不通

> 除了打通网络, 和除了用hostNetwork=true, 还有其它方案嘛? hostPort，或者是你直接NodePort注册到zk [ Full content available at: https://github.com/apache/dubbo/issues/5911 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ closed pull request #5912: windows platform unittest adapt

[ pull request closed by AlbumenJ ] [ Full content available at: https://github.com/apache/dubbo/pull/5912 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] flycash commented on issue #420: Align 2.7.5: ServiceDiscoveryRegistry

@lzp0412 you own this. [ Full content available at: https://github.com/apache/dubbo-go/issues/420 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] flycash opened pull request #453: Service name mapping support

**What this PR does**: **Which issue(s) this PR fixes**: Fixes #419 **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/453 ] This message was relayed via

[GitHub] [dubbo]

[ Full content available at: https://github.com/apache/dubbo/pull/5912 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on issue #5913: windows platform unittest adapt

#5877 [ Full content available at: https://github.com/apache/dubbo/pull/5913 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo-go] codecov-io commented on issue #433: Add: License checker

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=h1) Report > Merging [#433](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/9a4db99bb87be3e6e7b4240409b4f2e149d0a6e3?src=pr=desc) > will **increase**

[GitHub] [dubbo] codecov-io commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=h1) Report > Merging [#5902](https://codecov.io/gh/apache/dubbo/pull/5902?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] laddcn commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

@htynkn Please help me to merge this PR [ Full content available at: https://github.com/apache/dubbo/pull/5902 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] htynkn commented on issue #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

I thought rat plugin are doing this check at this moment? [ Full content available at: https://github.com/apache/dubbo/pull/5910 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] AlbumenJ opened pull request #5913: windows platform unittest adapt

## What is the purpose of the change Making unit-test can be correctly running on Windows platform and fixing some static port, which is coded into test cases. ## Brief changelog - fix: in Windows platform content get from resource contains \r delimiter - fix:in Windows Platform hessian2 may

[GitHub] [dubbo] CodingSinger commented on issue #5902: [Dubbo-5885][Dubbo-5899] Fix nacos registry not work bug since 2.7.6

LGTM [ Full content available at: https://github.com/apache/dubbo/pull/5902 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] codecov-io commented on issue #433: Add: License checker

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=h1) Report > Merging [#433](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/9a4db99bb87be3e6e7b4240409b4f2e149d0a6e3?src=pr=desc) > will **increase**

[GitHub] [dubbo-go] Patrick0308 opened pull request #455: (WIP) Align 2.7.5: direct event dispatcher

**What this PR does**: **Which issue(s) this PR fixes**: Fixes #450 **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/455 ] This message was relayed via

[GitHub] [dubbo-go] codecov-io commented on issue #415: [Ftr] add Tag router

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/415?src=pr=h1) Report > Merging [#415](https://codecov.io/gh/apache/dubbo-go/pull/415?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de?src=pr=desc) > will **decrease**

[GitHub] [dubbo-spring-boot-project] Qpm-wen commented on issue #674: dubbo-spring-boot-starter 2.7.5 连接zookeeper失败

同样遇到这个问题。 ``` win7 dubbo.version=2.7.5 zookeeper.version=3.5.7 curator.version=4.0.0 ``` [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/674 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ commented on issue #5877: unable to build dubbo-common ( unit test fail in AdaptiveClassCodeGeneratorTest )

#5913 Already create PR [ Full content available at: https://github.com/apache/dubbo/issues/5877 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] beiwei30 opened issue #4644: dubbo2.7.3 @Method 注解设置重试无效

dubbo2.7.3 @Method 注解设置重试无效 [ Full content available at: https://github.com/apache/dubbo/issues/4644 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-hessian-lite] LinShunKang commented on issue #28: fix: HessianFieldExceptionHessianFieldException

@beiwei30 @chickenlj PTAL. [ Full content available at: https://github.com/apache/dubbo-hessian-lite/pull/28 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-hessian-lite] LinShunKang opened pull request #28: fix: HessianFieldExceptionHessianFieldException

## What is the purpose of the change Fix HessianFieldExceptionHessianFieldException when run `Hessian2StringShortTest#test_string_short_type` ## Brief changelog * Revert commit: https://github.com/apache/dubbo-hessian-lite/commit/40c9d06fd01068f820bcb75d4f7a0448ce1704b8 * Add UT:

[GitHub] [dubbo-go] zouyx commented on pull request #453: Service name mapping support

split package? [ Full content available at: https://github.com/apache/dubbo-go/pull/453 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-go] codecov-io commented on issue #453: Service name mapping support

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/453?src=pr=h1) Report > Merging [#453](https://codecov.io/gh/apache/dubbo-go/pull/453?src=pr=desc) > into > [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/adae0d729b94852bda855eeb78276ce48a8acde7?src=pr=desc) > will

[GitHub] [dubbo] codecov-io commented on issue #5914: upgrade fastjson to 1.2.67

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5914?src=pr=h1) Report > Merging [#5914](https://codecov.io/gh/apache/dubbo/pull/5914?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo] codecov-io commented on issue #5914: upgrade fastjson to 1.2.67

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5914?src=pr=h1) Report > Merging [#5914](https://codecov.io/gh/apache/dubbo/pull/5914?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/332e85f9753d68e5948e5f916f7c11d22c86804e=desc) > will **decrease** coverage by

[GitHub] [dubbo-go] zouyx commented on issue #433: Add: License checker

Fail case：[Build-1579](https://travis-ci.org/github/apache/dubbo-go/builds/666289152). The last case is success case . [ Full content available at: https://github.com/apache/dubbo-go/pull/433 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-samples] chickenlj commented on issue #154: add javax support when use jdk11

chickenlj commented on issue #154: add javax support when use jdk11 URL: https://github.com/apache/dubbo-samples/pull/154#issuecomment-603599511 Temporarily, we can have this dependency for this sample to work. I think fundamentally we need to find a way to replace PostConstruct.

[GitHub] [dubbo-go] codecov-io commented on issue #433: Add: License checker

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=h1) Report > Merging [#433](https://codecov.io/gh/apache/dubbo-go/pull/433?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/c43d705d1a96e0a72efbdaf704dfec47300ef3ad?src=pr=desc) > will **increase**